From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: [PATCH] dw_spi.c can now be built as a module. Date: Thu, 21 Jan 2010 09:55:02 -0700 Message-ID: References: <20100121164349.10132.24020.stgit@station520.octasic.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Jean-Hugues Deschenes Return-path: In-Reply-To: <20100121164349.10132.24020.stgit-PR71IgaHmJalNznWqnLNUK6RkeBMCJyt@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On Thu, Jan 21, 2010 at 9:44 AM, Jean-Hugues Deschenes wrote: > dw_spi.c can now be built as a module. > > Signed-off-by: Jean-Hugues Deschenes I've picked this up, but.... > diff --git a/drivers/spi/dw_spi.c b/drivers/spi/dw_spi.c > index 4b5a9a1..754f21c 100644 > --- a/drivers/spi/dw_spi.c > +++ b/drivers/spi/dw_spi.c > @@ -940,6 +940,17 @@ int dw_spi_resume_host(struct dw_spi *dws) > =A0} > =A0EXPORT_SYMBOL(dw_spi_resume_host); > > +static int __init dw_spi_init(void) > +{ > + =A0 =A0 =A0 return 0; > +} > +module_init(dw_spi_init); > + > +static void __exit dw_spi_exit(void) > +{ > +} > +module_exit(dw_spi_exit); Modules are not required to have module_init() and module_exit() hooks. I've dropped this chunk. g. -- = Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ---------------------------------------------------------------------------= --- Throughout its 18-year history, RSA Conference consistently attracts the world's best and brightest in the field, creating opportunities for Confere= nce attendees to learn about information security's most important issues throu= gh interactions with peers, luminaries and emerging and established companies. http://p.sf.net/sfu/rsaconf-dev2dev