From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: [PATCH] Fixed data sampling on the correct edge Date: Tue, 2 Feb 2010 01:20:28 -0700 Message-ID: References: <95F51F4B902CAC40AF459205F6322F0171E8D4987E@BMK019S01.emtrion.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: "spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org" , Magnus Damm To: "Pietrek, Markus" Return-path: In-Reply-To: <95F51F4B902CAC40AF459205F6322F0171E8D4987E-76KB/CMpcTeJqUQdFWzYuOuPKLVQfWtC@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On Fri, Jan 29, 2010 at 6:37 AM, Pietrek, Markus wrote: > Hi, > > it seems to me that the spi_sh_msiof.c driver configures REDG and TEDG wrongly. TEDG==0 outputs data at the **rising edge** of the clock and REDG==0 samples data at the **falling edge** of the clock. Therefore for SPI, TEDG must be equal to REDG, otherwise the last byte received is not sampled in the SPI mode 3 > > The SH7723 HW Reference Manual explains the setting in Figure 20.20 and Figure 20.21 ("SPI Clock and data timing") > > > Signed-off-by: Markus Pietrek > Acked-by: Magnus Damm Patch is whitespace damaged and so doesn't cleanly apply. It's been picked up anyway since this one is pretty trivial, but you should look into fixing your mailer for sending patches. Thanks, g. ------------------------------------------------------------------------------ The Planet: dedicated and managed hosting, cloud storage, colocation Stay online with enterprise data centers and the best network in the business Choose flexible plans and management services without long-term contracts Personal 24x7 support from experience hosting pros just a phone call away. http://p.sf.net/sfu/theplanet-com