From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: [PATCH 1/5] spi: spi_lock_bus and spi_unlock_bus Date: Tue, 16 Feb 2010 21:47:42 -0700 Message-ID: References: <20100216204450.e043eed8.eschwab@online.de> <20100216205720.ebe949a1.eschwab@online.de> <8bd0f97a1002161607m3c748ccegaffb83c42667287a@mail.gmail.com> <8bd0f97a1002162034r2d3e397eq12ae0f0df1ae2adb@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Cc: David Brownell , Ernst Schwab , spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, yi.li-OyLXuOCK7orQT0dZR+AlfA@public.gmane.org To: Mike Frysinger Return-path: In-Reply-To: <8bd0f97a1002162034r2d3e397eq12ae0f0df1ae2adb-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On Tue, Feb 16, 2010 at 9:34 PM, Mike Frysinger wrot= e: > On Tue, Feb 16, 2010 at 22:48, Grant Likely wrote: >>> there's nothing Blackfin-specific in the implementation of these >>> functions. =A0i think the way we should be handling these is by doing: >>> =A0- remove {lock,unlock}_bus functions from spi_master >>> =A0- move the {lock,unlock}_bus code from spi_bfin5xx.c to spi.c >>> =A0- drop the SPI_BFIN_LOCK Kconfig >> >> Am I missing something. I cannot find any lock related functions in >> the spi code. =A0Is this stuff in mainline? > > i'm proposing what should be done. =A0there is no locking logic anywhere = atm. Okay, but you're talking about removing functions (lock_bus, unlock_bus) and config values (SPI_BFIN_LOCK) which I cannot find anywhere in mainline. g. ---------------------------------------------------------------------------= --- SOLARIS 10 is the OS for Data Centers - provides features such as DTrace, Predictive Self Healing and Award Winning ZFS. Get Solaris 10 NOW http://p.sf.net/sfu/solaris-dev2dev