Re: [PATCH 1/5] spi: spi_lock_bus and spi_unlock_bus

[Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>]

On Tue, Feb 16, 2010 at 10:04 PM, Mike Frysinger <vapier.adi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> On Tue, Feb 16, 2010 at 23:47, Grant Likely wrote:
>> On Tue, Feb 16, 2010 at 9:34 PM, Mike Frysinger wrote:
>>> On Tue, Feb 16, 2010 at 22:48, Grant Likely wrote:
>>>>> there's nothing Blackfin-specific in the implementation of these
>>>>> functions.  i think the way we should be handling these is by doing:
>>>>>  - remove {lock,unlock}_bus functions from spi_master
>>>>>  - move the {lock,unlock}_bus code from spi_bfin5xx.c to spi.c
>>>>>  - drop the SPI_BFIN_LOCK Kconfig
>>>>
>>>> Am I missing something. I cannot find any lock related functions in
>>>> the spi code.  Is this stuff in mainline?
>>>
>>> i'm proposing what should be done.  there is no locking logic anywhere atm.
>>
>> Okay, but you're talking about removing functions (lock_bus,
>> unlock_bus) and config values (SPI_BFIN_LOCK) which I cannot find
>> anywhere in mainline.
>
> they were part of the patchsets that were under discussion

Ah, I misunderstood where you were coming from.

g.

------------------------------------------------------------------------------
SOLARIS 10 is the OS for Data Centers - provides features such as DTrace,
Predictive Self Healing and Award Winning ZFS. Get Solaris 10 NOW
http://p.sf.net/sfu/solaris-dev2dev