[PATCH] of: added documentation for spi chipselects

[PATCH] of: added documentation for spi chipselects

[Ernst Schwab]

From: Ernst Schwab <eschwab-BGeptl67XyCzQB+pC5nmwQ@public.gmane.org>

Added devicetree binding documentation for gpios used as chipselect. The
code to evaluate these is already present in spi_mpc8xxx.c.

Signed-off-by: Ernst Schwab <eschwab-BGeptl67XyCzQB+pC5nmwQ@public.gmane.org>
---
diff -upr a/Documentation/powerpc/dts-bindings/fsl/spi.txt b/Documentation/powerpc/dts-bindings/fsl/spi.txt
--- a/Documentation/powerpc/dts-bindings/fsl/spi.txt
+++ b/Documentation/powerpc/dts-bindings/fsl/spi.txt
@@ -13,6 +13,11 @@ Required properties:
 - interrupt-parent : the phandle for the interrupt controller that
   services interrupts for this device.
 
+Optional properties:
+- gpios : specifies the gpio pins to be used for chipselects. 
+  The gpios will be referred to as reg=<index> in the SPI child nodes.
+  If unspecified, a single SPI device without a chip select can be used.
+
 Example:
 	spi@4c0 {
 		cell-index = <0>;
@@ -21,4 +26,6 @@ Example:
 		interrupts = <82 0>;
 		interrupt-parent = <700>;
 		mode = "cpu";
+		gpios = <&gpio 18 1	// device reg=<0>, low-active
+			 &gpio 19 1>;	// device reg=<1>, low-active
 	};

Re: [PATCH] of: added documentation for spi chipselects

[Grant Likely]

On Tue, Feb 16, 2010 at 11:39 AM, Ernst Schwab <eschwab-BGeptl67XyCzQB+pC5nmwQ@public.gmane.org> wrote:
> From: Ernst Schwab <eschwab-BGeptl67XyCzQB+pC5nmwQ@public.gmane.org>
>
> Added devicetree binding documentation for gpios used as chipselect. The
> code to evaluate these is already present in spi_mpc8xxx.c.
>
> Signed-off-by: Ernst Schwab <eschwab-BGeptl67XyCzQB+pC5nmwQ@public.gmane.org>

Merged, thanks.


> ---
> diff -upr a/Documentation/powerpc/dts-bindings/fsl/spi.txt b/Documentation/powerpc/dts-bindings/fsl/spi.txt
> --- a/Documentation/powerpc/dts-bindings/fsl/spi.txt
> +++ b/Documentation/powerpc/dts-bindings/fsl/spi.txt
> @@ -13,6 +13,11 @@ Required properties:
>  - interrupt-parent : the phandle for the interrupt controller that
>   services interrupts for this device.
>
> +Optional properties:
> +- gpios : specifies the gpio pins to be used for chipselects.
> +  The gpios will be referred to as reg=<index> in the SPI child nodes.
> +  If unspecified, a single SPI device without a chip select can be used.
> +
>  Example:
>        spi@4c0 {
>                cell-index = <0>;
> @@ -21,4 +26,6 @@ Example:
>                interrupts = <82 0>;
>                interrupt-parent = <700>;
>                mode = "cpu";
> +               gpios = <&gpio 18 1     // device reg=<0>, low-active
> +                        &gpio 19 1>;   // device reg=<1>, low-active
>        };
>
>
>



-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.

Re: [PATCH] of: added documentation for spi chipselects

[Wolfram Sang]

[-- Attachment #1.1: Type: text/plain, Size: 1886 bytes --]

On Tue, Feb 16, 2010 at 07:39:57PM +0100, Ernst Schwab wrote:
> From: Ernst Schwab <eschwab-BGeptl67XyCzQB+pC5nmwQ@public.gmane.org>
> 
> Added devicetree binding documentation for gpios used as chipselect. The
> code to evaluate these is already present in spi_mpc8xxx.c.
> 
> Signed-off-by: Ernst Schwab <eschwab-BGeptl67XyCzQB+pC5nmwQ@public.gmane.org>
> ---
> diff -upr a/Documentation/powerpc/dts-bindings/fsl/spi.txt b/Documentation/powerpc/dts-bindings/fsl/spi.txt
> --- a/Documentation/powerpc/dts-bindings/fsl/spi.txt
> +++ b/Documentation/powerpc/dts-bindings/fsl/spi.txt
> @@ -13,6 +13,11 @@ Required properties:
>  - interrupt-parent : the phandle for the interrupt controller that
>    services interrupts for this device.
>  
> +Optional properties:
> +- gpios : specifies the gpio pins to be used for chipselects. 
> +  The gpios will be referred to as reg=<index> in the SPI child nodes.
> +  If unspecified, a single SPI device without a chip select can be used.

Minor: I'd prefer spaces around the '='.

> +
>  Example:
>  	spi@4c0 {
>  		cell-index = <0>;
> @@ -21,4 +26,6 @@ Example:
>  		interrupts = <82 0>;
>  		interrupt-parent = <700>;
>  		mode = "cpu";
> +		gpios = <&gpio 18 1	// device reg=<0>, low-active
> +			 &gpio 19 1>;	// device reg=<1>, low-active

I'd drop the comments. GPIO controllers may have private xlate-functions, so
'1' could theoretically mean something else than "low-active" (although in
practice it hopefully won't).

>  	};
> 
> 
> _______________________________________________
> devicetree-discuss mailing list
> devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
> https://lists.ozlabs.org/listinfo/devicetree-discuss

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

[-- Attachment #2: Type: text/plain, Size: 192 bytes --]

_______________________________________________
devicetree-discuss mailing list
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [PATCH] of: added documentation for spi chipselects

[Ernst Schwab]

Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> wrote:

> Minor: I'd prefer spaces around the '='.
Done.

> I'd drop the comments. GPIO controllers may have private xlate-functions, so
> '1' could theoretically mean something else than "low-active" (although in
> practice it hopefully won't).

I dropped the polarity stuff. The "reg =" comment seems important
to me, I had to find this out by grep'ing and looking at the 
SPI master sourcecode. 
Patch V2 will be reposted.

Regards
Ernst

[PATCH V2] of: added documentation for spi chipselects

[Ernst Schwab]

From: Ernst Schwab <eschwab-BGeptl67XyCzQB+pC5nmwQ@public.gmane.org>

Added devicetree binding documentation for gpios used as chipselect. The
code to evaluate these is already present in spi_mpc8xxx.c.

Signed-off-by: Ernst Schwab <eschwab-BGeptl67XyCzQB+pC5nmwQ@public.gmane.org>
---
diff -upr a/Documentation/powerpc/dts-bindings/fsl/spi.txt b/Documentation/powerpc/dts-bindings/fsl/spi.txt
--- a/Documentation/powerpc/dts-bindings/fsl/spi.txt
+++ b/Documentation/powerpc/dts-bindings/fsl/spi.txt
@@ -13,6 +13,11 @@ Required properties:
 - interrupt-parent : the phandle for the interrupt controller that
   services interrupts for this device.
 
+Optional properties:
+- gpios : specifies the gpio pins to be used for chipselects. 
+  The gpios will be referred to as reg = <index> in the SPI child nodes.
+  If unspecified, a single SPI device without a chip select can be used.
+
 Example:
 	spi@4c0 {
 		cell-index = <0>;
@@ -21,4 +26,6 @@ Example:
 		interrupts = <82 0>;
 		interrupt-parent = <700>;
 		mode = "cpu";
+		gpios = <&gpio 18 1	// device reg = <0>
+			 &gpio 19 1>;	// device reg = <1>
 	};

Re: [PATCH V2] of: added documentation for spi chipselects

[Wolfram Sang]

[-- Attachment #1.1: Type: text/plain, Size: 1961 bytes --]

On Wed, Feb 17, 2010 at 01:23:22PM +0100, Ernst Schwab wrote:
> From: Ernst Schwab <eschwab-BGeptl67XyCzQB+pC5nmwQ@public.gmane.org>
> 
> Added devicetree binding documentation for gpios used as chipselect. The
> code to evaluate these is already present in spi_mpc8xxx.c.
> 
> Signed-off-by: Ernst Schwab <eschwab-BGeptl67XyCzQB+pC5nmwQ@public.gmane.org>

Hmm, as Grant merged the original patch already, it might be necessary to
convert this into a follow-up patch. He will surely tell you. For both
versions, you can add my

Reviewed-by: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>

...

> ---
> diff -upr a/Documentation/powerpc/dts-bindings/fsl/spi.txt b/Documentation/powerpc/dts-bindings/fsl/spi.txt
> --- a/Documentation/powerpc/dts-bindings/fsl/spi.txt
> +++ b/Documentation/powerpc/dts-bindings/fsl/spi.txt
> @@ -13,6 +13,11 @@ Required properties:
>  - interrupt-parent : the phandle for the interrupt controller that
>    services interrupts for this device.
>  
> +Optional properties:
> +- gpios : specifies the gpio pins to be used for chipselects. 

...and perhaps remove the trailing white space here.

> +  The gpios will be referred to as reg = <index> in the SPI child nodes.
> +  If unspecified, a single SPI device without a chip select can be used.
> +
>  Example:
>  	spi@4c0 {
>  		cell-index = <0>;
> @@ -21,4 +26,6 @@ Example:
>  		interrupts = <82 0>;
>  		interrupt-parent = <700>;
>  		mode = "cpu";
> +		gpios = <&gpio 18 1	// device reg = <0>
> +			 &gpio 19 1>;	// device reg = <1>
>  	};
> 
> 
> 
> 
> _______________________________________________
> devicetree-discuss mailing list
> devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
> https://lists.ozlabs.org/listinfo/devicetree-discuss

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

[-- Attachment #2: Type: text/plain, Size: 192 bytes --]

_______________________________________________
devicetree-discuss mailing list
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
https://lists.ozlabs.org/listinfo/devicetree-discuss

[PATCH] of: added documentation for spi chipselects, follow-up patch

[Ernst Schwab]

From: Ernst Schwab <eschwab-BGeptl67XyCzQB+pC5nmwQ@public.gmane.org>

Improved comments and formatting of devicetree binding documentation 
for gpios used as chipselect. 

Signed-off-by: Ernst Schwab <eschwab-BGeptl67XyCzQB+pC5nmwQ@public.gmane.org>
Reviewed-by: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
---
Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> wrote:

> Hmm, as Grant merged the original patch already, it might be necessary to
> convert this into a follow-up patch. He will surely tell you. For both
> versions, you can add my
> 
> Reviewed-by: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>

Ok, I understand - I have to get used to it...

diff -upr a/Documentation/powerpc/dts-bindings/fsl/spi.txt b/Documentation/powerpc/dts-bindings/fsl/spi.txt
--- a/Documentation/powerpc/dts-bindings/fsl/spi.txt
+++ b/Documentation/powerpc/dts-bindings/fsl/spi.txt
@@ -14,8 +14,8 @@ Required properties:
   services interrupts for this device.
 
 Optional properties:
-- gpios : specifies the gpio pins to be used for chipselects. 
-  The gpios will be referred to as reg=<index> in the SPI child nodes.
+- gpios : specifies the gpio pins to be used for chipselects.
+  The gpios will be referred to as reg = <index> in the SPI child nodes.
   If unspecified, a single SPI device without a chip select can be used.
 
 Example:
@@ -26,6 +26,6 @@ Example:
 		interrupts = <82 0>;
 		interrupt-parent = <700>;
 		mode = "cpu";
-		gpios = <&gpio 18 1	// device reg=<0>, low-active
-			 &gpio 19 1>;	// device reg=<1>, low-active
+		gpios = <&gpio 18 1	// device reg = <0>
+			 &gpio 19 1>;	// device reg = <1>
 	};

Re: [PATCH V2] of: added documentation for spi chipselects

[Grant Likely]

On Wed, Feb 17, 2010 at 6:41 AM, Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> wrote:
> On Wed, Feb 17, 2010 at 01:23:22PM +0100, Ernst Schwab wrote:
>> From: Ernst Schwab <eschwab-BGeptl67XyCzQB+pC5nmwQ@public.gmane.org>
>>
>> Added devicetree binding documentation for gpios used as chipselect. The
>> code to evaluate these is already present in spi_mpc8xxx.c.
>>
>> Signed-off-by: Ernst Schwab <eschwab-BGeptl67XyCzQB+pC5nmwQ@public.gmane.org>
>
> Hmm, as Grant merged the original patch already, it might be necessary to
> convert this into a follow-up patch. He will surely tell you. For both
> versions, you can add my
>
> Reviewed-by: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>

I'll just patch up the one in my tree.  Don't worry about it.

g.