From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC924111BD for ; Sat, 27 Jan 2024 03:44:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706327070; cv=none; b=F8uR9MqCauqjs3snsz+VzNFEGhLuaffgQXIpcjbIiCmOJgABYaXLIP66Klfc7IIrUEU2x8NCWMawxKp7YG5vOceFHbp8jEOSRKiHIvICo5WNXXcB6IswE/D26AzRLLY6rchGFmatZ+yffv2nTorVv80P6kRUraCLEI5Okoz3Pr8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706327070; c=relaxed/simple; bh=7hT3+dI5V/0o0Qr0KNiAl1/GrwBe4JNpldb7NWGpaus=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=VOSHv8Z3RYG/xaBfv0x5yN5LptIYl+L03x+9JtPBcLRWRofpMQoNg7WqTu71eyHdOQ9LT9SaYEKCyz9cN6fC1hghy7ALsuUbVCOM97zV6dEAUS4nV1Kt9PmA8eA6oeTqiXFCI6NwZ64E8ZMIhBYqicQRP7GFcWON1kemtWQoWp4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Bc7Sxgsr; arc=none smtp.client-ip=209.85.208.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Bc7Sxgsr" Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-55a90a0a1a1so461558a12.0 for ; Fri, 26 Jan 2024 19:44:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706327067; x=1706931867; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=FeyDcxP6HezAwDjv69G6j/rFie9KDKnEIL+n0uKd+54=; b=Bc7Sxgsrn8PnTTwnrEOqbV1M7XomLilzpb9HFGa1eFhMXafAMfcB7sDBcklfemqePF kXDKIdOl/UAgKPJXX1QMmUUPG4XDyBzaIxCuiytUQOCbMmVac9E4tyNPgeZDs/4WD+b4 K4colMLr+v4oCt+QKkQH2Ub9DPA7Zdf5uiLF7zl5mSlG4JCbFWv7/imAAr6C6D45z54o Jq6hd9XUh6LCFBMZN5TDL7N9TUdpowquZWv9DDBktLP5CHQH+ov0bGZpbP+SGuDu3OZ+ 7CUUtk5EbZdQJuOp143/QTmN7qkhYGFNBnXksii0+TH7pyn7EstjsLnJJE/pO1WnstHv TSRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706327067; x=1706931867; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FeyDcxP6HezAwDjv69G6j/rFie9KDKnEIL+n0uKd+54=; b=fLuxZZrVDsbw9nsnIRDRh5fNNlVU5R0p8yoxGzr4gK5meQ3RM9KDMuUGP0RxI3hDhV omKbPPdLJvhFp2N2lmzBNjLQ4/HUYiUNnmfATwEAYoatt5lvdV8/Ft8o1kSlODKvKXce gBJo05/PmVBPevDY+oG4XJOy7/t3Dp/op5pROIsApdFKqTy5bp35PE42+qITUQ6QDDjJ MEaPcPcenVv2sOEsyH8OUMGV8ii+TbR9hJSAHMlVH540dEh81dE2n4q6XasVPnKEk6hx BodgXUk5PDW9C+xZBcmI8wqYZ5g2v2L+TwwalBpzwZxqjCVa7xcaKLEXWyfPyKl+NYzi ya4w== X-Gm-Message-State: AOJu0YyzolXZdVz3kW2uwgwNtTzoN5wsHfWqvwxG5bFeJtgnpyHr4OA7 sLXmI+AUS3DQwp8W81H7I+VQTwwvVyKR6fDYOupoIFIHrYoQreTglgohzutErNLEVOW0nUTzw41 GC+Q= X-Google-Smtp-Source: AGHT+IEqEpvJIp0hz18eU80/3j5GvnMIeJRDqKNwNDOPA41ttbS9nchooX1lMIHwAbWkeNZsKpsEeA== X-Received: by 2002:aa7:d7cf:0:b0:55d:2bea:a858 with SMTP id e15-20020aa7d7cf000000b0055d2beaa858mr247114eds.41.1706327067034; Fri, 26 Jan 2024 19:44:27 -0800 (PST) Received: from [192.168.2.107] ([79.115.63.202]) by smtp.gmail.com with ESMTPSA id y65-20020a50bb47000000b0055ebc7066e8sm17699ede.88.2024.01.26.19.44.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Jan 2024 19:44:26 -0800 (PST) Message-ID: Date: Sat, 27 Jan 2024 03:44:24 +0000 Precedence: bulk X-Mailing-List: linux-spi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 17/17] spi: s3c64xx: use bitfield access macros Content-Language: en-US To: Sam Protsenko Cc: broonie@kernel.org, andi.shyti@kernel.org, krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, jassi.brar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com References: <20240126171546.1233172-1-tudor.ambarus@linaro.org> <20240126171546.1233172-18-tudor.ambarus@linaro.org> From: Tudor Ambarus In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 1/27/24 03:38, Sam Protsenko wrote: >>>> - val |= S3C64XX_SPI_MODE_BUS_TSZ_HALFWORD; >>>> - val |= S3C64XX_SPI_MODE_CH_TSZ_HALFWORD; >>>> + val |= FIELD_PREP(S3C64XX_SPI_MODE_BUS_TSZ_MASK, >>>> + S3C64XX_SPI_MODE_BUS_TSZ_HALFWORD) | >>>> + FIELD_PREP(S3C64XX_SPI_MODE_CH_TSZ_MASK, >>>> + S3C64XX_SPI_MODE_CH_TSZ_HALFWORD); >>> Two people complained it makes the code harder to read. Yet it's not >>> addressed in v3. Please see my comments for your previous submission >>> explaining what can be done, and also Andi's comment on that matter. >> I kept these intentionally. Please read my reply on that matter or the >> cover letter to this patch set. >> > I read it. But still don't like it 🙂 I'm sure it's possible to do > this modification, but at the same time keep the code clean an easy to > read. The code above -- I don't like at all, sorry. It was much better > before this patch, IMHO. Yeah, I guess Mark will tip the scale. Cheers, ta