linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Walleij <linus.ml.walleij@gmail.com>
To: Mika Westerberg <mika.westerberg@iki.fi>
Cc: spi-devel-general@lists.sourceforge.net, ryan@bluewatersys.com,
	martinwguy@gmail.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [spi-devel-general] [PATCH v6 1/2] spi: implemented driver for Cirrus EP93xx SPI controller
Date: Mon, 3 May 2010 02:18:44 +0200	[thread overview]
Message-ID: <h2r63386a3d1005021718k31125e4fz43a08025997b5c5c@mail.gmail.com> (raw)
In-Reply-To: <0dce0e9fdb6af35854d26d7bd0d8af5a5ea8f76a.1272805161.git.mika.westerberg@iki.fi>

2010/5/2 Mika Westerberg <mika.westerberg@iki.fi>:

> This patch adds an SPI master driver for the Cirrus EP93xx SPI controller found
> in EP93xx chips.
(...)
> +#define SSPCR0                 0x0000
> +#define SSPCR0_MODE_SHIFT      6
> +#define SSPCR0_SCR_SHIFT       8
> +
> +#define SSPCR1                 0x0004
> +#define SSPCR1_RIE             BIT(0)
> +#define SSPCR1_TIE             BIT(1)
> +#define SSPCR1_RORIE           BIT(2)
> +#define SSPCR1_LBM             BIT(3)
> +#define SSPCR1_SSE             BIT(4)
> +#define SSPCR1_MS              BIT(5)
> +#define SSPCR1_SOD             BIT(6)
> +
> +#define SSPDR                  0x0008
> +
> +#define SSPSR                  0x000c
> +#define SSPSR_TFE              BIT(0)
> +#define SSPSR_TNF              BIT(1)
> +#define SSPSR_RNE              BIT(2)
> +#define SSPSR_RFF              BIT(3)
> +#define SSPSR_BSY              BIT(4)
> +#define SSPCPSR                        0x0010
> +
> +#define SSPIIR                 0x0014
> +#define SSPIIR_RIS             BIT(0)
> +#define SSPIIR_TIS             BIT(1)
> +#define SSPIIR_RORIS           BIT(2)
> +#define SSPICR                 SSPIIR

When I look at this it's quite obvious that this is the same hardware or very
close (maybe a redux version) of the thing supported by
drivers/spi/amba-pl022.c.

What is the difference really? I suspect this is a PL022 PrimeCell straight off.
Even the CPSR algorithm is the same, just written differently.

Can you make a hexdump of the PrimeCell ID registers at offset
base+0xffe0..0xffff and post the contents?

Yours,
Linus Walleij

  reply	other threads:[~2010-05-03  0:18 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-02 14:38 [PATCH v6 0/2] spi: driver for Cirrus EP93xx SPI controller Mika Westerberg
     [not found] ` <cover.1272805161.git.mika.westerberg-X3B1VOXEql0@public.gmane.org>
2010-05-02 14:38   ` [PATCH v6 1/2] spi: implemented " Mika Westerberg
2010-05-03  0:18     ` Linus Walleij [this message]
     [not found]       ` <h2r63386a3d1005021718k31125e4fz43a08025997b5c5c-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-05-03  4:21         ` Mika Westerberg
     [not found]           ` <20100503042123.GM26418-WfG2TfFPcQ9S6P4I59wummXnswh1EIUO@public.gmane.org>
2010-05-03 13:18             ` Linus Walleij
2010-05-03 17:00         ` H Hartley Sweeten
     [not found]           ` <0D753D10438DA54287A00B0270842697636E9BA5D3-gaq956PjLg32KbjnnMDalRurcAul1UnsRrxOEX5GOmysTnJN9+BGXg@public.gmane.org>
2010-05-05  9:04             ` Linus Walleij
     [not found]     ` <0dce0e9fdb6af35854d26d7bd0d8af5a5ea8f76a.1272805161.git.mika.westerberg-X3B1VOXEql0@public.gmane.org>
2010-05-03 18:45       ` H Hartley Sweeten
     [not found]         ` <0D753D10438DA54287A00B0270842697636EADDB8E-gaq956PjLg32KbjnnMDalRurcAul1UnsRrxOEX5GOmysTnJN9+BGXg@public.gmane.org>
2010-05-03 19:15           ` Mika Westerberg
2010-05-02 14:39 ` [PATCH v6 2/2] ep93xx: SPI driver platform support code Mika Westerberg
     [not found]   ` <865b5d7ca0fae1977a1fadcdabdb715e3ea1604d.1272805161.git.mika.westerberg-X3B1VOXEql0@public.gmane.org>
2010-05-04 17:21     ` H Hartley Sweeten
     [not found]       ` <0D753D10438DA54287A00B0270842697636EB838E1-gaq956PjLg32KbjnnMDalRurcAul1UnsRrxOEX5GOmysTnJN9+BGXg@public.gmane.org>
2010-05-05 14:26         ` Russell King - ARM Linux
2010-05-11  0:24           ` H Hartley Sweeten
     [not found]             ` <0D753D10438DA54287A00B0270842697636EE74B65-gaq956PjLg32KbjnnMDalRurcAul1UnsRrxOEX5GOmysTnJN9+BGXg@public.gmane.org>
2010-05-11  6:13               ` Mika Westerberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=h2r63386a3d1005021718k31125e4fz43a08025997b5c5c@mail.gmail.com \
    --to=linus.ml.walleij@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=martinwguy@gmail.com \
    --cc=mika.westerberg@iki.fi \
    --cc=ryan@bluewatersys.com \
    --cc=spi-devel-general@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).