From: Grant Likely <grant.likely@secretlab.ca>
To: Cory Maccarrone <darkstar6262@gmail.com>
Cc: spi-devel-general@lists.sourceforge.net,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
David Brownell <dbrownell@users.sourceforge.net>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Subject: Re: 32-bit transfers broken in OMAP SPI driver?
Date: Mon, 19 Apr 2010 06:42:29 -0600 [thread overview]
Message-ID: <t2yfa686aa41004190542s2e1596abs11e0762e60ef73d@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1004190950380.4080@axis700.grange>
Cory, can you please take a look at this?
Thanks,
g.
On Mon, Apr 19, 2010 at 1:58 AM, Guennadi Liakhovetski
<g.liakhovetski@gmx.de> wrote:
> Ran across drivers/spi/omap_spi_100k.c and its handling of > 16-bit
> transfers seems buggy to me. Firstly, addresses do not get incremented in
> omap1_spi100k_txrx_pio() (word_len <= 32) case, a fix for which seems to
> be obvious, secondly, spi100k_write_data() and spi100k_read_data() only
> write / read 16-bit data blocks, for which I'm not adventurous enough to
> propose a patch without even touching the hardware;) Am I right? Maybe
> just disable > 16-bit transfers altogether, since they are broken, and
> thus, obviously, unused.
>
> Thanks
> Guennadi
> ---
> Guennadi Liakhovetski, Ph.D.
> Freelance Open-Source Software Developer
> http://www.open-technology.de/
>
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
prev parent reply other threads:[~2010-04-19 12:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-19 7:58 32-bit transfers broken in OMAP SPI driver? Guennadi Liakhovetski
2010-04-19 12:42 ` Grant Likely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=t2yfa686aa41004190542s2e1596abs11e0762e60ef73d@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=darkstar6262@gmail.com \
--cc=dbrownell@users.sourceforge.net \
--cc=g.liakhovetski@gmx.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).