* 32-bit transfers broken in OMAP SPI driver?
@ 2010-04-19 7:58 Guennadi Liakhovetski
2010-04-19 12:42 ` Grant Likely
0 siblings, 1 reply; 2+ messages in thread
From: Guennadi Liakhovetski @ 2010-04-19 7:58 UTC (permalink / raw)
To: spi-devel-general
Cc: linux-arm-kernel, linux-omap, David Brownell, Grant Likely
Ran across drivers/spi/omap_spi_100k.c and its handling of > 16-bit
transfers seems buggy to me. Firstly, addresses do not get incremented in
omap1_spi100k_txrx_pio() (word_len <= 32) case, a fix for which seems to
be obvious, secondly, spi100k_write_data() and spi100k_read_data() only
write / read 16-bit data blocks, for which I'm not adventurous enough to
propose a patch without even touching the hardware;) Am I right? Maybe
just disable > 16-bit transfers altogether, since they are broken, and
thus, obviously, unused.
Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: 32-bit transfers broken in OMAP SPI driver?
2010-04-19 7:58 32-bit transfers broken in OMAP SPI driver? Guennadi Liakhovetski
@ 2010-04-19 12:42 ` Grant Likely
0 siblings, 0 replies; 2+ messages in thread
From: Grant Likely @ 2010-04-19 12:42 UTC (permalink / raw)
To: Cory Maccarrone
Cc: spi-devel-general, linux-arm-kernel, linux-omap, David Brownell,
Guennadi Liakhovetski
Cory, can you please take a look at this?
Thanks,
g.
On Mon, Apr 19, 2010 at 1:58 AM, Guennadi Liakhovetski
<g.liakhovetski@gmx.de> wrote:
> Ran across drivers/spi/omap_spi_100k.c and its handling of > 16-bit
> transfers seems buggy to me. Firstly, addresses do not get incremented in
> omap1_spi100k_txrx_pio() (word_len <= 32) case, a fix for which seems to
> be obvious, secondly, spi100k_write_data() and spi100k_read_data() only
> write / read 16-bit data blocks, for which I'm not adventurous enough to
> propose a patch without even touching the hardware;) Am I right? Maybe
> just disable > 16-bit transfers altogether, since they are broken, and
> thus, obviously, unused.
>
> Thanks
> Guennadi
> ---
> Guennadi Liakhovetski, Ph.D.
> Freelance Open-Source Software Developer
> http://www.open-technology.de/
>
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-04-19 12:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-19 7:58 32-bit transfers broken in OMAP SPI driver? Guennadi Liakhovetski
2010-04-19 12:42 ` Grant Likely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).