From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Guy Subject: Re: [PATCH v2 1/3] spi: implemented driver for Cirrus EP93xx SPI controller Date: Tue, 6 Apr 2010 22:28:53 +0100 Message-ID: References: <9de3769ae253830fb0eebc98d299137c59c69b8c.1268930557.git.mika.westerberg@iki.fi> <56d259a01003250649ubf0e32ejc15e4f3b45ec43cd@mail.gmail.com> <20100325184316.GB20512@gw.healthdatacare.com> <20100406054418.GA27465@gw.healthdatacare.com> <20100406181839.GA2685@gw.healthdatacare.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Mika Westerberg Return-path: In-Reply-To: <20100406181839.GA2685-WfG2TfFPcQ9S6P4I59wummXnswh1EIUO@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On 4/6/10, Mika Westerberg wrote: > I only have one ep9302 board and 2 SPI devices If you'd like one of the MMC-only boards to test on, I can ship it to you - please provide smail mail address by private mail if that would be welcome > > Lastly, what is the meaning of conditional operator(s) in > > return t->bits_per_word ?: msg->spi->bits_per_word; > > It compiles, but it's the first time I've seen this construct in 27 > > years of C programming. What is the "normal" syntax for this? > > It is an GCC extension: > > http://gcc.gnu.org/onlinedocs/gcc-4.4.3/gcc/Conditionals.html#Conditionals > > I've been using it once I saw it somewhere in the kernel source. OK, I suggest we don't use "GNU extensions" if they can be avoided, and program in C. The GCC monoculture is ending, thanks to llvm. and those gnu-heads are not the most wise people on the planet. (OK, the ANSI committe are worse, but.... :) M ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev