From: Martin Guy <martinwguy-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Mika Westerberg <mika.westerberg-X3B1VOXEql0@public.gmane.org>
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v2 1/3] spi: implemented driver for Cirrus EP93xx SPI controller
Date: Mon, 12 Apr 2010 11:03:58 +0100 [thread overview]
Message-ID: <y2q56d259a01004120303wff208c27kf601a6b6699a48e9@mail.gmail.com> (raw)
In-Reply-To: <20100410155443.GG2685-WfG2TfFPcQ9S6P4I59wummXnswh1EIUO@public.gmane.org>
and
- if (espi->tx == 0 && espi->rx == 0)
- espi->fifo_level = 0;
since it's always created as 0 and is always reset to 0 by the end of a transfer
and if you like
/* is transfer finished? */
- if (espi->tx == t->len && espi->rx == t->len) {
+ if (espi->fifo_level == 0) {
to save a couple of instructions
M
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
prev parent reply other threads:[~2010-04-12 10:03 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-18 16:59 [PATCH v2 0/3] spi: driver for Cirrus EP93xx SPI controller Mika Westerberg
[not found] ` <cover.1268930557.git.mika.westerberg-X3B1VOXEql0@public.gmane.org>
2010-03-18 17:00 ` [PATCH v2 1/3] spi: implemented " Mika Westerberg
[not found] ` <c222c3df9c94d9ec919817f640a953e4f45ae99b.1268930557.git.mika.westerberg-X3B1VOXEql0@public.gmane.org>
2010-03-18 17:00 ` [PATCH v2 3/3] ep93xx: SPI driver platform support code Mika Westerberg
2010-03-18 17:27 ` [PATCH v2 2/3] ep93xx: added chip revision reading function H Hartley Sweeten
[not found] ` <0D753D10438DA54287A00B02708426976368AC725D-gaq956PjLg32KbjnnMDalRurcAul1UnsRrxOEX5GOmysTnJN9+BGXg@public.gmane.org>
2010-03-25 9:06 ` Mika Westerberg
[not found] ` <20100325090638.GA20512-WfG2TfFPcQ9S6P4I59wummXnswh1EIUO@public.gmane.org>
2010-03-25 17:20 ` H Hartley Sweeten
[not found] ` <0D753D10438DA54287A00B02708426976368F66FD1-gaq956PjLg32KbjnnMDalRurcAul1UnsRrxOEX5GOmysTnJN9+BGXg@public.gmane.org>
2010-03-26 15:40 ` Martin Guy
[not found] ` <9de3769ae253830fb0eebc98d299137c59c69b8c.1268930557.git.mika.westerberg-X3B1VOXEql0@public.gmane.org>
2010-03-18 17:00 ` Mika Westerberg
2010-03-25 13:49 ` [PATCH v2 1/3] spi: implemented driver for Cirrus EP93xx SPI controller Martin Guy
[not found] ` <56d259a01003250649ubf0e32ejc15e4f3b45ec43cd-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-03-25 18:43 ` Mika Westerberg
[not found] ` <20100325184316.GB20512-WfG2TfFPcQ9S6P4I59wummXnswh1EIUO@public.gmane.org>
2010-04-01 0:15 ` Martin Guy
[not found] ` <s2n56d259a01003311715ke5b93a96v9d453ec32f08ec29-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-04-01 3:00 ` Ryan Mallon
2010-04-01 6:26 ` Mika Westerberg
2010-04-06 5:44 ` Mika Westerberg
[not found] ` <20100406054418.GA27465-WfG2TfFPcQ9S6P4I59wummXnswh1EIUO@public.gmane.org>
2010-04-06 12:50 ` Martin Guy
[not found] ` <s2g56d259a01004060550me72bd64cr35e4a83c495d6909-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-04-06 18:18 ` Mika Westerberg
[not found] ` <20100406181839.GA2685-WfG2TfFPcQ9S6P4I59wummXnswh1EIUO@public.gmane.org>
2010-04-06 21:28 ` Martin Guy
[not found] ` <x2r56d259a01004061428raffb32e9o1d42570c79c0ee56-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-04-09 17:56 ` Martin Guy
[not found] ` <l2j56d259a01004091056i91598adub4201b47c4a86a90-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-04-09 18:08 ` Martin Guy
2010-04-10 15:54 ` Mika Westerberg
[not found] ` <20100410155443.GG2685-WfG2TfFPcQ9S6P4I59wummXnswh1EIUO@public.gmane.org>
2010-04-11 14:24 ` Martin Guy
2010-04-12 10:03 ` Martin Guy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=y2q56d259a01004120303wff208c27kf601a6b6699a48e9@mail.gmail.com \
--to=martinwguy-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=mika.westerberg-X3B1VOXEql0@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).