From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Guy Subject: Re: [PATCH v2 1/3] spi: implemented driver for Cirrus EP93xx SPI controller Date: Mon, 12 Apr 2010 11:03:58 +0100 Message-ID: References: <56d259a01003250649ubf0e32ejc15e4f3b45ec43cd@mail.gmail.com> <20100325184316.GB20512@gw.healthdatacare.com> <20100406054418.GA27465@gw.healthdatacare.com> <20100406181839.GA2685@gw.healthdatacare.com> <20100410155443.GG2685@gw.healthdatacare.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Mika Westerberg Return-path: In-Reply-To: <20100410155443.GG2685-WfG2TfFPcQ9S6P4I59wummXnswh1EIUO@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org and - if (espi->tx == 0 && espi->rx == 0) - espi->fifo_level = 0; since it's always created as 0 and is always reset to 0 by the end of a transfer and if you like /* is transfer finished? */ - if (espi->tx == t->len && espi->rx == t->len) { + if (espi->fifo_level == 0) { to save a couple of instructions M ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev