From: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
To: Juuso Oikarinen
<juuso.oikarinen-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
Cc: "spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org"
<spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
"Tereshonkov Roman \(Nokia-D/Helsinki\)"
<roman.tereshonkov-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>,
Samuel Ortiz
<samuel.ortiz-EmnPodGKVbzby3iVrkZq2A@public.gmane.org>
Subject: Re: [PATCH 1/2] spi: Add support for dma_min_bytes configuration.
Date: Thu, 8 Apr 2010 22:56:35 -0600 [thread overview]
Message-ID: <z2tfa686aa41004082156tb4b150fao671ed749cb83c9e1@mail.gmail.com> (raw)
In-Reply-To: <1270785939.10120.1141.camel-gZysiALljqf+W+uuys5jPoH6Mc4MB0Vx@public.gmane.org>
On Thu, Apr 8, 2010 at 10:05 PM, Juuso Oikarinen
<juuso.oikarinen-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org> wrote:
> AFAIK performing the SPI transfer optimally should not affect other SPI
> clients in a negative way, and AFAIK there are no other SPI clients in
> Dali than the wl1271, so I guess this new threshold value could also be
> hard-coded into the omap2_mcspi driver.
Okay, good. Then I recommend preparing and posting a patch to change
the default value. Include the rational behind the change, how you
came up with the final number, and be sure to cc: the original
developer of that driver.
g.
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
next prev parent reply other threads:[~2010-04-09 4:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-06 10:39 [PATCH 1/2] spi: Add support for dma_min_bytes configuration Roman Tereshonkov
[not found] ` <1270550389-30392-1-git-send-email-roman.tereshonkov-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2010-04-06 10:39 ` [PATCH 2/2] omap2_mcspi: Use dma_min_bytes parameter when it is configured Roman Tereshonkov
2010-04-08 6:26 ` [PATCH 1/2] spi: Add support for dma_min_bytes configuration Grant Likely
[not found] ` <z2rfa686aa41004072326z5ff8c044l46330b85dfd7ae74-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-04-08 10:33 ` roman.tereshonkov-xNZwKgViW5gAvxtiuMwx3w
[not found] ` <E1C7579D1379824DAE67858071C8103828208BC339-xJW1crHCIS+8kqYwC468Frtp2NbXvJi8gfoxzgwHRXE@public.gmane.org>
2010-04-08 15:08 ` Grant Likely
[not found] ` <s2vfa686aa41004080808o443dd6b7ge4d23c513a1f80a8-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-04-08 15:25 ` roman.tereshonkov-xNZwKgViW5gAvxtiuMwx3w
[not found] ` <E1C7579D1379824DAE67858071C8103828208BC539-xJW1crHCIS+8kqYwC468Frtp2NbXvJi8gfoxzgwHRXE@public.gmane.org>
2010-04-08 16:27 ` Grant Likely
2010-04-09 4:05 ` Juuso Oikarinen
[not found] ` <1270785939.10120.1141.camel-gZysiALljqf+W+uuys5jPoH6Mc4MB0Vx@public.gmane.org>
2010-04-09 4:56 ` Grant Likely [this message]
2010-04-09 7:49 ` roman.tereshonkov-xNZwKgViW5gAvxtiuMwx3w
[not found] ` <E1C7579D1379824DAE67858071C8103828208BC90A-xJW1crHCIS+8kqYwC468Frtp2NbXvJi8gfoxzgwHRXE@public.gmane.org>
2010-04-09 7:52 ` Juuso Oikarinen
[not found] ` <1270799541.10120.1146.camel-gZysiALljqf+W+uuys5jPoH6Mc4MB0Vx@public.gmane.org>
2010-04-09 8:38 ` roman.tereshonkov-xNZwKgViW5gAvxtiuMwx3w
[not found] ` <E1C7579D1379824DAE67858071C8103828208BC96F-xJW1crHCIS+8kqYwC468Frtp2NbXvJi8gfoxzgwHRXE@public.gmane.org>
2010-04-09 14:52 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=z2tfa686aa41004082156tb4b150fao671ed749cb83c9e1@mail.gmail.com \
--to=grant.likely-s3s/wqlpoipyb63q8fvjnq@public.gmane.org \
--cc=juuso.oikarinen-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org \
--cc=roman.tereshonkov-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org \
--cc=samuel.ortiz-EmnPodGKVbzby3iVrkZq2A@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).