From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: [PATCH 1/2] spi: Add support for dma_min_bytes configuration. Date: Thu, 8 Apr 2010 22:56:35 -0600 Message-ID: References: <1270550389-30392-1-git-send-email-roman.tereshonkov@nokia.com> <1270785939.10120.1141.camel@wimaxnb.nmp.nokia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: "spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org" , "Tereshonkov Roman \(Nokia-D/Helsinki\)" , Samuel Ortiz To: Juuso Oikarinen Return-path: In-Reply-To: <1270785939.10120.1141.camel-gZysiALljqf+W+uuys5jPoH6Mc4MB0Vx@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On Thu, Apr 8, 2010 at 10:05 PM, Juuso Oikarinen wrote: > AFAIK performing the SPI transfer optimally should not affect other SPI > clients in a negative way, and AFAIK there are no other SPI clients in > Dali than the wl1271, so I guess this new threshold value could also be > hard-coded into the omap2_mcspi driver. Okay, good. Then I recommend preparing and posting a patch to change the default value. Include the rational behind the change, how you came up with the final number, and be sure to cc: the original developer of that driver. g. ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev