From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from m228-62.mailgun.net (m228-62.mailgun.net [159.135.228.62]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 40DD23D61 for ; Mon, 18 Apr 2022 23:31:15 +0000 (UTC) DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=codeagain.dev; q=dns/txt; s=smtp; t=1650324675; h=In-Reply-To: Content-Type: MIME-Version: References: Message-ID: Subject: Subject: To: To: From: From: Date: Sender: Sender; bh=cUyk4WeVp+7lDDXFiewp5XkVKA3vNjvg2iTdrwTV7jk=; b=hk3muPzTyA0wwBHEog/3pySXFiQwR+IWyvZQop5x7fyCVdk7kqeRpZJIyDtefnuji7G4b0ZF zoc/siDn9g7LE9ItD0A8/aZ2tonyVd7QZigpbMndKzt5nBzkIybdToRxborLFnI5NjwazXeD 7+Vfeq5m5pL+Oo/sZsg8zd2TTwRxtXfh0L3Ins9VvEimTWzJtDzFQKRSgM7RyrSyu6wt/xNa 57tx0ABGK0/6ZbCt0/M6oeU7+37a3/nyzv8M/eJlE7yPm88N9o2ilbHVRsEcuRW3dmPTjOqu d3qOy4vm0LtEUN/guCEcvXujk58G2vUevlV4jk6r1QG/VGAl8Zq+xg== X-Mailgun-Sending-Ip: 159.135.228.62 X-Mailgun-Sid: WyI4MTlhZCIsICJsaW51eC1zdGFnaW5nQGxpc3RzLmxpbnV4LmRldiIsICJiZTljNmQiXQ== Received: from AN5Bruno (186-250-90-1.mhnet.com.br [186.250.90.1]) by smtp-out-n02.prod.us-east-1.postgun.com with SMTP id 625df4c157b6987692272703 (version=TLS1.3, cipher=TLS_AES_128_GCM_SHA256); Mon, 18 Apr 2022 23:31:13 GMT Sender: codeagain@codeagain.dev Date: Mon, 18 Apr 2022 20:31:09 -0300 From: Bruno Moreira-Guedes To: Greg Kroah-Hartman , Martyn Welch , Manohar Vanga , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev, Bruno's Patch Watchbox Subject: [PATCH v2 2/3] staging: vme: Add VME_BUS dependency to Kconfig Message-ID: <00de5644d7c2f8c8878eccf86b761e0602732080.1650321310.git.codeagain@codeagain.dev> References: Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="puumcnxop7gnfgad" Content-Disposition: inline In-Reply-To: --puumcnxop7gnfgad Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable The KConfig file for VME_USER ('drivers/staging/vme/devices/Kconfig') sourced at "drivers/vme/boards/KConfig" misses a `depends on` line for VME_BUS, which is unnoticeable for menuconfig users who aren't be able to select it through this interface without setting the CONFIG_VME_BUS option because it's nested on VME_BUS menu entry. A patch to move appropriately this driver to the "Staging" submenu ([PATCH 1/3], originally sent as a single patch submitted at https://lore.kernel.org/linux-staging/3fbc5325e94b9ae0666a1f5a56a4e5372bfce= a1d.camel@codeagain.dev/T/#t), however, unveiled this missing `depends on` line, since it moved the `source` line for VME_USER's KConfig to somewhere else, allowing it to be compiled without the support for VME_BUS. While it compiles fine and seems to initialize the driver fine (tested both as module and as built- in), it seems to make no sense having VME_USER without VME_BUS. This patches addresses it by adding the VME_BUS to the `depends on` line at "drivers/staging/vme/devices/Kconfig". Signed-off-by: Bruno Moreira-Guedes --- drivers/staging/vme/devices/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vme/devices/Kconfig b/drivers/staging/vme/devi= ces/Kconfig index 5651bb16b28b..e8b4461bf27f 100644 --- a/drivers/staging/vme/devices/Kconfig +++ b/drivers/staging/vme/devices/Kconfig @@ -3,7 +3,7 @@ comment "VME Device Drivers" =20 config VME_USER tristate "VME user space access driver" - depends on STAGING + depends on STAGING && VME_BUS help If you say Y here you want to be able to access a limited number of VME windows in a manner at least semi-compatible with the interface --=20 2.35.3 --puumcnxop7gnfgad Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQQTUrsHCxGmQ5vyKRAZtd3tyEY2kgUCYl30vQAKCRAZtd3tyEY2 kohYAQDEeD7sf3Z3MEfQ4IbsXM+kMkMKZFFU7UTHectNWRtjGgEAleJ6U7vvTNA8 TbWm4PGZ6Auk3ajk62MwvZUGnEJOuwM= =DWuN -----END PGP SIGNATURE----- --puumcnxop7gnfgad--