From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 466D12C80 for ; Thu, 30 Dec 2021 11:32:56 +0000 (UTC) Received: by mail-qt1-f181.google.com with SMTP id q14so21386308qtx.10 for ; Thu, 30 Dec 2021 03:32:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=a+3drHr85ha2baZful+nRJ7uBfrZaAbysA+5tvBlqBY=; b=qPtzEAgNBKbi3F8mzlujZv/gYnhOvqhIviEvIuYvKHcBnL1trShVtjmds0pGd2hf79 liFxw3cM75vsuO4svQ2s3GgC7/2uBAes/Vcvy+/v8DC0tRhnv+4xSLcrxzptF2nmQkI8 YV9aKyqADMLP1qpBgZStSDBs6fCLTe3qX08bvjMP+knZB3h1CIQ3XM7r/kBTqitdFn87 Bw5NxzIQ2d6iDtHxBo5vVLZ0FF0dRuNApfGF2BlgH7O2YTETm2Y2eym5o3L7kZ9Gh3M9 9rX2Jul5hJPmEiL37bWzrNIHOoIZFNdPajiUyeB0m96hmwVAT+udeMoeycCHtEzLGuwd LolQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=a+3drHr85ha2baZful+nRJ7uBfrZaAbysA+5tvBlqBY=; b=Sfs3YPxgbGTqKud28Sutv3AYD6joW4+6RVdsSlakVpqs/cwtPTl9KUwFY5o43ER/UY LZ4JRzOIkUsXife+lYy2h6IJQgQqrQQw0GnUQ7ePlN1tLVdSFtkwUcIHziLHrA4DWSXG Ijri7TBsGejzly7PJX8ObxRsk4VW+UH1lQdgHOjw6e6yVHOagLcVgqBcHEGfye9FrNo1 Bm9dd2A6Mmxr+p1nEB8OhhkUNjQovLv0HqTqnvTr8H+444he9ONdhmYXvDSUWKg8MaQe EjelcoJazKM7It5fHrqu6sJwgPHP2uSfZtfWquo5dzGtvgSBLOv9L03miid9TzeTrais PaFQ== X-Gm-Message-State: AOAM530012s5pQCQPsZIhXPHJOyurDhXkjGJoep0MQNw2MI2SfO9ZpYq TpmC9re3GjSz3eb3DZByoSGUQ+58DSMQCQ== X-Google-Smtp-Source: ABdhPJycnyd4H24DA5r2pASiGfeQVL5PDTMuBWNjmfl03v0nt+qlhV0ox7sLYQwz0sd6ruO2U1lfQQ== X-Received: by 2002:a05:622a:144:: with SMTP id v4mr25727272qtw.191.1640863975231; Thu, 30 Dec 2021 03:32:55 -0800 (PST) Received: from localhost.localdomain ([181.23.70.139]) by smtp.gmail.com with ESMTPSA id v5sm20348559qkp.126.2021.12.30.03.32.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Dec 2021 03:32:54 -0800 (PST) From: Gaston Gonzalez To: linux-staging@lists.linux.dev Cc: gregkh@linuxfoundation.org, nsaenz@kernel.org, f.fainelli@gmail.com, rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, juerg.haefliger@canonical.com, rdunlap@infradead.org, dave.stevenson@raspberrypi.com, stefan.wahren@i2se.com, unixbhaskar@gmail.com, mitaliborkar810@gmail.com, phil@raspberrypi.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, gascoar@gmail.com Subject: [PATCH v2 2/3] staging: vc04_services: bcm2835-camera: avoid the use of typedef for function pointers Date: Thu, 30 Dec 2021 08:31:27 -0300 Message-Id: <0418e6e19e1580fff4abfc4bb2f4269dc206df44.1640776340.git.gascoar@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace typedef bm2835_mmal_v4l2_ctrl_cb with equivalent declaration to better align with the linux kernel coding style. Signed-off-by: Gaston Gonzalez --- .../staging/vc04_services/bcm2835-camera/controls.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/staging/vc04_services/bcm2835-camera/controls.c b/drivers/staging/vc04_services/bcm2835-camera/controls.c index b096a12387f7..3696dfb5a020 100644 --- a/drivers/staging/vc04_services/bcm2835-camera/controls.c +++ b/drivers/staging/vc04_services/bcm2835-camera/controls.c @@ -65,13 +65,6 @@ enum bm2835_mmal_ctrl_type { MMAL_CONTROL_TYPE_CLUSTER, /* special cluster entry */ }; -struct bm2835_mmal_v4l2_ctrl; - -typedef int(bm2835_mmal_v4l2_ctrl_cb)( - struct bm2835_mmal_dev *dev, - struct v4l2_ctrl *ctrl, - const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl); - struct bm2835_mmal_v4l2_ctrl { u32 id; /* v4l2 control identifier */ enum bm2835_mmal_ctrl_type type; @@ -84,7 +77,8 @@ struct bm2835_mmal_v4l2_ctrl { u64 step; /* step size of the control */ const s64 *imenu; /* integer menu array */ u32 mmal_id; /* mmal parameter id */ - bm2835_mmal_v4l2_ctrl_cb *setter; + int (*setter)(struct bm2835_mmal_dev *dev, struct v4l2_ctrl *ctrl, + const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl); }; struct v4l2_to_mmal_effects_setting { -- 2.34.1