From: Luka Gejak <luka.gejak@linux.dev>
To: josh.hesketh@gmail.com
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev, straube.linux@gmail.com,
luka.gejak@linux.dev
Subject: Re: [PATCH 1/2] staging: rtl8723bs: fix coding style issues in sdio_halinit.c
Date: Sun, 12 Apr 2026 07:32:42 +0200 [thread overview]
Message-ID: <0586BB0B-507F-4409-9294-1C08E8FED3CB@linux.dev> (raw)
In-Reply-To: <20260411214001.8849-1-josh.hesketh@gmail.com>
On Sat, 11 Apr 2026 22:40:00 +0100, Josh Hesketh wrote:
-/* u8 bMacPwrCtrlOn; */
+/* u8 bMacPwrCtrlOn; */
Instead of fixing the spacing in commented-out code, please just
remove dead code entirely. Git tracks previous versions for us.
-/* ==== Reset digital sequence ====== */
+/* ==== Reset digital sequence ====== */
Fixing standard comments like this one is fine, but the commented-out
code blocks above should be removed.
- u8 bResult = _SUCCESS;
+ u8 bResult = _SUCCESS;
This change is good and follows kernel coding style.
You should split patch 1 into 3 patches: one for deleting the
commented-out code, another for the legitimate whitespace fixes
and one for adding newlines. Also one more thing this patch series
doesn't apply on top of staging-next so please rebase on staging-next
branch in v2 and don't forget to write changes in v2 part under --- in
patch 1 and patch 2.
Best regards,
Luka Gejak
prev parent reply other threads:[~2026-04-12 5:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-11 21:40 [PATCH 1/2] staging: rtl8723bs: fix coding style issues in sdio_halinit.c Josh Hesketh
2026-04-11 21:40 ` [PATCH 2/2] staging: rtl8723bs: remove unnecessary else after return " Josh Hesketh
2026-04-12 5:32 ` Luka Gejak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0586BB0B-507F-4409-9294-1C08E8FED3CB@linux.dev \
--to=luka.gejak@linux.dev \
--cc=gregkh@linuxfoundation.org \
--cc=josh.hesketh@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox