From: Fabio Aiuto <fabioaiuto83@gmail.com>
To: gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Fabio Aiuto <fabioaiuto83@gmail.com>
Subject: [PATCH 11/15] staging: rtl8723bs: put parentheses on macros with complex values in include/rtw_debug.h
Date: Fri, 26 Mar 2021 10:09:18 +0100 [thread overview]
Message-ID: <0634873fdf3b0ff61e61fa8cd9a74c5959a50efa.1616748885.git.fabioaiuto83@gmail.com> (raw)
In-Reply-To: <cover.1616748885.git.fabioaiuto83@gmail.com>
fix the following checkpatch warning:
ERROR: Macros starting with if should be enclosed by a
do - while loop to avoid possible if/else logic defects
+ #define RT_PRINT_DATA(_Comp, _Level,
_TitleString, _HexData, _HexDataLen) \
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
---
drivers/staging/rtl8723bs/include/rtw_debug.h | 28 ++++++++++---------
1 file changed, 15 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/rtl8723bs/include/rtw_debug.h b/drivers/staging/rtl8723bs/include/rtw_debug.h
index d1c557818305..b00f8a6c4312 100644
--- a/drivers/staging/rtl8723bs/include/rtw_debug.h
+++ b/drivers/staging/rtl8723bs/include/rtw_debug.h
@@ -236,19 +236,21 @@
#if defined(_dbgdump)
#undef RT_PRINT_DATA
#define RT_PRINT_DATA(_Comp, _Level, _TitleString, _HexData, _HexDataLen) \
- if (((_Comp) & GlobalDebugComponents) && (_Level <= GlobalDebugLevel)) \
- { \
- int __i; \
- u8 *ptr = (u8 *)_HexData; \
- _dbgdump("%s", DRIVER_PREFIX); \
- _dbgdump(_TitleString); \
- for (__i = 0; __i < (int)_HexDataLen; __i++) \
- { \
- _dbgdump("%02X%s", ptr[__i], (((__i + 1) % 4) == 0)?" ":" "); \
- if (((__i + 1) % 16) == 0) _dbgdump("\n"); \
- } \
- _dbgdump("\n"); \
- }
+ do { \
+ if (((_Comp) & GlobalDebugComponents) && (_Level <= GlobalDebugLevel)) \
+ { \
+ int __i; \
+ u8 *ptr = (u8 *)_HexData; \
+ _dbgdump("%s", DRIVER_PREFIX); \
+ _dbgdump(_TitleString); \
+ for (__i = 0; __i < (int)_HexDataLen; __i++) \
+ { \
+ _dbgdump("%02X%s", ptr[__i], (((__i + 1) % 4) == 0)?" ":" "); \
+ if (((__i + 1) % 16) == 0) _dbgdump("\n"); \
+ } \
+ _dbgdump("\n"); \
+ } \
+ } while (0)
#endif /* defined(_dbgdump) */
#endif /* DEBUG_RTL871X */
--
2.20.1
next prev parent reply other threads:[~2021-03-26 9:09 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 9:09 [PATCH 00/15] staging: rtl8723bs: fix checkpatch errors on macros Fabio Aiuto
2021-03-26 9:09 ` [PATCH 01/15] staging: rtl8723bs: inlcude macros in a do..while loop in core/rtw_security.c Fabio Aiuto
2021-03-26 9:52 ` Dan Carpenter
2021-03-26 11:04 ` Fabio Aiuto
2021-03-26 9:09 ` [PATCH 02/15] staging: rtl8723bs: put parentheses on macros with complex values in hal/HalBtcOutSrc.h Fabio Aiuto
2021-03-26 9:54 ` Dan Carpenter
2021-03-26 11:09 ` Fabio Aiuto
2021-03-26 9:09 ` [PATCH 03/15] staging: rtl8723bs: put parentheses on macros with complex values in hal/odm_debug.h Fabio Aiuto
2021-03-26 9:09 ` [PATCH 04/15] staging: rtl8723bs: put parentheses on macros with complex values in include/basic_types.h Fabio Aiuto
2021-03-26 10:04 ` Dan Carpenter
2021-03-26 11:12 ` Fabio Aiuto
2021-03-26 14:06 ` Greg KH
2021-03-26 9:09 ` [PATCH 05/15] staging: rtl8723bs: put parentheses on macros with complex values in include/drv_types.h Fabio Aiuto
2021-03-26 14:22 ` Dan Carpenter
2021-03-26 15:12 ` Fabio Aiuto
2021-03-26 9:09 ` [PATCH 06/15] staging: rtl8723bs: put parentheses on macros with complex values in include/hal_com.h Fabio Aiuto
2021-03-26 9:09 ` [PATCH 07/15] staging: rtl8723bs: put parentheses on macros with complex values in include/hal_com_reg.h Fabio Aiuto
2021-03-26 9:09 ` [PATCH 08/15] staging: rtl8723bs: put parentheses on macros with complex values in include/hal_data.h Fabio Aiuto
2021-03-26 9:09 ` [PATCH 09/15] staging: rtl8723bs: put parentheses on macros with complex values in include/hal_phy.h Fabio Aiuto
2021-03-26 9:09 ` [PATCH 10/15] staging: rtl8723bs: put parentheses on macros with complex values in include/ieee80211.h Fabio Aiuto
2021-03-26 9:09 ` Fabio Aiuto [this message]
2021-03-26 9:09 ` [PATCH 12/15] staging: rtl8723bs: put parentheses on macros with complex values in include/rtw_pwrctrl.h Fabio Aiuto
2021-03-26 9:09 ` [PATCH 13/15] staging: rtl8723bs: add spaces around operator " Fabio Aiuto
2021-03-26 9:09 ` [PATCH 14/15] staging: rtl8723bs: put parentheses on macros with complex values in include/sta_info.h Fabio Aiuto
2021-03-26 13:39 ` David Laight
2021-03-26 13:57 ` Fabio Aiuto
2021-03-26 9:09 ` [PATCH 15/15] staging: rtl8723bs: put parentheses on macros with complex values in include/wifi.h Fabio Aiuto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0634873fdf3b0ff61e61fa8cd9a74c5959a50efa.1616748885.git.fabioaiuto83@gmail.com \
--to=fabioaiuto83@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox