From: Michael Straube <straube.linux@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>
Cc: Greg KH <gregkh@linuxfoundation.org>,
"open list:STAGING SUBSYSTEM" <linux-staging@lists.linux.dev>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: staging: r8188eu: Can odm_DynamicTxPowerNIC() be removed?
Date: Sat, 18 Sep 2021 19:32:31 +0200 [thread overview]
Message-ID: <0701af92-b341-f7b0-8a0c-3bea8a69f580@gmail.com> (raw)
In-Reply-To: <89d9424a-d792-633a-d8e8-cebe7c3a2e20@lwfinger.net>
On 9/18/21 18:46, Larry Finger wrote:
> On 9/18/21 08:31, Michael Straube wrote:
>> Hi Larry, Phillip and all.
>>
>> While removing code that checks for the chip type I stumbled upon this:
>>
>>
>> void odm_DynamicTxPowerNIC(struct odm_dm_struct *pDM_Odm)
>> {
>> if (!(pDM_Odm->SupportAbility & ODM_BB_DYNAMIC_TXPWR))
>> return;
>>
>> if (pDM_Odm->SupportICType == ODM_RTL8188E) {
>> /* ??? */
>> /* This part need to be redefined. */
>> }
>> }
>>
>>
>> (pDM_Odm->SupportICType == ODM_RTL8188E) is always true in this driver.
>> Currently the function does nothing and the driver seems to work fine.
>> Because of the comment I'm not sure if the whole function can just be
>> removed?
>
> Yes, I agree. No later driver does anything with this routine, thus it
> is dead and can be removed.
>
> Larry
>
Ok, thank you.
Regards,
Michael
next prev parent reply other threads:[~2021-09-18 17:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-18 13:31 staging: r8188eu: Can odm_DynamicTxPowerNIC() be removed? Michael Straube
2021-09-18 16:46 ` Larry Finger
2021-09-18 17:32 ` Michael Straube [this message]
2021-09-20 8:33 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0701af92-b341-f7b0-8a0c-3bea8a69f580@gmail.com \
--to=straube.linux@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox