From: Hans de Goede <hansg@kernel.org>
To: Adarsh Das <adarshdas950@gmail.com>,
Andy Shevchenko <andy@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: media: atomisp: remove functions doing ftrace like logging
Date: Fri, 27 Mar 2026 20:39:00 +0100 [thread overview]
Message-ID: <0aa6fdc7-986b-4673-b687-e2db7c01e1f5@kernel.org> (raw)
In-Reply-To: <20260201142415.83595-1-adarshdas950@gmail.com>
Hi,
On 1-Feb-26 15:24, Adarsh Das wrote:
> Remove ia_css_debug_dtrace() calls which only log function entry.
> ftrace should be used instead.
>
> Signed-off-by: Adarsh Das <adarshdas950@gmail.com>
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <johannes.goede@oss.qualcomm.com>
Regards,
Hans
> ---
> .../media/atomisp/pci/ia_css_isp_configs.c | 26 -------------------
> 1 file changed, 26 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/ia_css_isp_configs.c b/drivers/staging/media/atomisp/pci/ia_css_isp_configs.c
> index 38c9c62366d6..1dce9fa926ab 100644
> --- a/drivers/staging/media/atomisp/pci/ia_css_isp_configs.c
> +++ b/drivers/staging/media/atomisp/pci/ia_css_isp_configs.c
> @@ -18,8 +18,6 @@ int ia_css_configure_iterator(const struct ia_css_binary *binary,
> unsigned int offset = 0;
> unsigned int size = 0;
>
> - ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE_PRIVATE, "%s:\n", __func__);
> -
> if (!binary->info->mem_offsets.offsets.config)
> return 0;
>
> @@ -41,8 +39,6 @@ int ia_css_configure_copy_output(const struct ia_css_binary *binary,
> unsigned int offset = 0;
> unsigned int size = 0;
>
> - ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE_PRIVATE, "%s:\n", __func__);
> -
> if (!binary->info->mem_offsets.offsets.config)
> return 0;
>
> @@ -66,8 +62,6 @@ int ia_css_configure_crop(const struct ia_css_binary *binary,
> unsigned int offset = 0;
> unsigned int size = 0;
>
> - ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE_PRIVATE, "%s:\n", __func__);
> -
> if (!binary->info->mem_offsets.offsets.config)
> return 0;
>
> @@ -89,8 +83,6 @@ int ia_css_configure_fpn(const struct ia_css_binary *binary,
> unsigned int offset = 0;
> unsigned int size = 0;
>
> - ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE_PRIVATE, "%s:\n", __func__);
> -
> if (!binary->info->mem_offsets.offsets.config)
> return 0;
>
> @@ -111,8 +103,6 @@ int ia_css_configure_dvs(const struct ia_css_binary *binary,
> unsigned int offset = 0;
> unsigned int size = 0;
>
> - ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE_PRIVATE, "%s:\n", __func__);
> -
> if (!binary->info->mem_offsets.offsets.config)
> return 0;
>
> @@ -133,8 +123,6 @@ int ia_css_configure_qplane(const struct ia_css_binary *binary,
> unsigned int offset = 0;
> unsigned int size = 0;
>
> - ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE_PRIVATE, "%s:\n", __func__);
> -
> if (!binary->info->mem_offsets.offsets.config)
> return 0;
>
> @@ -156,8 +144,6 @@ int ia_css_configure_output0(const struct ia_css_binary *binary,
> unsigned int offset = 0;
> unsigned int size = 0;
>
> - ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE_PRIVATE, "%s:\n", __func__);
> -
> if (!binary->info->mem_offsets.offsets.config)
> return 0;
>
> @@ -179,8 +165,6 @@ int ia_css_configure_output1(const struct ia_css_binary *binary,
> unsigned int offset = 0;
> unsigned int size = 0;
>
> - ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE_PRIVATE, "%s:\n", __func__);
> -
> if (!binary->info->mem_offsets.offsets.config)
> return 0;
>
> @@ -202,8 +186,6 @@ int ia_css_configure_output(const struct ia_css_binary *binary,
> unsigned int offset = 0;
> unsigned int size = 0;
>
> - ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE_PRIVATE, "%s:\n", __func__);
> -
> if (!binary->info->mem_offsets.offsets.config)
> return 0;
>
> @@ -225,8 +207,6 @@ int ia_css_configure_raw(const struct ia_css_binary *binary,
> unsigned int offset = 0;
> unsigned int size = 0;
>
> - ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE_PRIVATE, "%s:\n", __func__);
> -
> if (!binary->info->mem_offsets.offsets.config)
> return 0;
>
> @@ -248,8 +228,6 @@ int ia_css_configure_tnr(const struct ia_css_binary *binary,
> unsigned int offset = 0;
> unsigned int size = 0;
>
> - ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE_PRIVATE, "%s:\n", __func__);
> -
> if (!binary->info->mem_offsets.offsets.config)
> return 0;
>
> @@ -271,8 +249,6 @@ int ia_css_configure_ref(const struct ia_css_binary *binary,
> unsigned int offset = 0;
> unsigned int size = 0;
>
> - ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE_PRIVATE, "%s:\n", __func__);
> -
> if (!binary->info->mem_offsets.offsets.config)
> return 0;
>
> @@ -294,8 +270,6 @@ int ia_css_configure_vf(const struct ia_css_binary *binary,
> unsigned int offset = 0;
> unsigned int size = 0;
>
> - ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE_PRIVATE, "%s:\n", __func__);
> -
> if (!binary->info->mem_offsets.offsets.config)
> return 0;
>
prev parent reply other threads:[~2026-03-27 19:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-01 14:24 [PATCH] staging: media: atomisp: remove functions doing ftrace like logging Adarsh Das
2026-02-03 8:09 ` Andy Shevchenko
2026-03-27 19:39 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0aa6fdc7-986b-4673-b687-e2db7c01e1f5@kernel.org \
--to=hansg@kernel.org \
--cc=adarshdas950@gmail.com \
--cc=andy@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox