From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88A5E2C82 for ; Fri, 28 Jan 2022 15:29:01 +0000 (UTC) Received: by mail-lf1-f52.google.com with SMTP id x23so12613373lfc.0 for ; Fri, 28 Jan 2022 07:29:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=N4J//Mo9xUttrK0yF032bWbn0KZLi4C3IbfSaVZ898E=; b=nMCCJwPleajqB6C9nJrLYmYyxvYJDjsPBaeAckGvpvNJDlogXVNDX5CMorLz8EkXwK tOGGJLbUBQ5vVXgmuATMWVHVp6zRhthE/Z4c3fXvDzusCCvuSOLi2PeQqPPynXDiEqJa wpkWD/KytYGfhbLSPodHYTZ193CEPYVnW8yYjqop2VUUI19OJJSNODw9+MHhdzD6OI8n reTz6lWlg50Q6pG/G+MdGVZEs7E/JstVtaC73N7E3+wALEq524Y3vPRmf0zJQjvvlg5R cR0EZAoEAIZxSDSUjdrrZQayHItW8C9PmvfUhNyD52CwO42YQFOTC1TF8xhvGNG+gp0E rLPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=N4J//Mo9xUttrK0yF032bWbn0KZLi4C3IbfSaVZ898E=; b=qkSZr1x8b9fF+0Ql/VVkctXIRDaEsblEzYxQEESBsemuK8AbBOORRULBQCP0I/ULAI rS0/yoG5Njm+LsPIvQVEHwp+QkpGwzJqofBdnn8/lOcmUq7xb3AGImgi9/CS/eaiad4s 6QoB+dIHiuv5FCLDFAvCY20BJGRZ+Xgg6F4Ii6dYt7eKXIcJpAyTa6deVdA9I39Tp++K lZWfs9QTsSEdoJCwhXXrs1ce37n3WVd5C5Gvfdff3De1fQoGHha6cyZ3pz40W8DExT7A dhAF12ex+BsTl5GY+S7OLAQZlCMS/sxf6V6mLoqrkf+k91Caj3prklU9eZoAcyxv5lUJ nk7w== X-Gm-Message-State: AOAM531+zB7kmE1Pp3ussmqeDzFjSXy+7K19gzbOZFaBWPq2lFHWJEYA +u/nyJqAeIC5lJaWGIjQNYk= X-Google-Smtp-Source: ABdhPJyQ9v4PdBJzaie5bbiSmHbBxFsVgyJTcSUuDvUITdCGgIiqmLYFQd/isDs0HBzExLgZ/Z5wJg== X-Received: by 2002:a05:6512:3a96:: with SMTP id q22mr6579539lfu.521.1643383739523; Fri, 28 Jan 2022 07:28:59 -0800 (PST) Received: from [192.168.1.103] ([31.173.86.67]) by smtp.gmail.com with ESMTPSA id z11sm2563451lfu.106.2022.01.28.07.28.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Jan 2022 07:28:58 -0800 (PST) Subject: Re: [PATCH 4/7] mfd: hi6421-spmi-pmic: Use generic_handle_irq_safe(). To: Lee Jones Cc: Sebastian Andrzej Siewior , greybus-dev@lists.linaro.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, linux-usb@vger.kernel.org, netdev@vger.kernel.org, "David S. Miller" , Alex Elder , Arnd Bergmann , Greg Kroah-Hartman , Hans de Goede , Jakub Kicinski , Johan Hovold , Rui Miguel Silva , Thomas Gleixner , UNGLinuxDriver@microchip.com, Wolfram Sang , Woojung Huh References: <20220127113303.3012207-1-bigeasy@linutronix.de> <20220127113303.3012207-5-bigeasy@linutronix.de> <44b42c37-67a4-1d20-e2ff-563d4f9bfae2@gmail.com> From: Sergei Shtylyov Message-ID: <0daa924f-790c-cdc7-a1c0-4eb91917e084@gmail.com> Date: Fri, 28 Jan 2022 18:28:57 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 1/28/22 4:33 PM, Lee Jones wrote: >>> generic_handle_irq() is invoked from a regular interrupt service >>> routing. This handler will become a forced-threaded handler on >> >> s/routing/routine/? >> >>> PREEMPT_RT and will be invoked with enabled interrupts. The >>> generic_handle_irq() must be invoked with disabled interrupts in order >>> to avoid deadlocks. >>> >>> Instead of manually disabling interrupts before invoking use >>> generic_handle_irq() which can be invoked with enabled and disabled >>> interrupts. >>> >>> Signed-off-by: Sebastian Andrzej Siewior >> [...] >> >> MBR, Sergey > > What does that mean? That means that I think you had a typo in the word "routing". The s/// comes from vim, I think --where it means search and replace. MBR, Sergey