From: Fabio Aiuto <fabioaiuto83@gmail.com>
To: gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH v3 02/43] staging: rtl8723bs: remove if-else blocks left empty by ODM_RT_TRACE deletion
Date: Fri, 30 Apr 2021 16:56:24 +0200 [thread overview]
Message-ID: <0e1196ebf56787f62dcbfbcba1fcbc2ed37a65ce.1619794331.git.fabioaiuto83@gmail.com> (raw)
In-Reply-To: <cover.1619794331.git.fabioaiuto83@gmail.com>
remove if-else blocks left empty by ODM_RT_TRACE deletion.
remove unused variables to suppress compiler warnings.
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
---
drivers/staging/rtl8723bs/hal/HalPhyRf.c | 13 -------------
drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c | 9 +--------
drivers/staging/rtl8723bs/hal/odm_PathDiv.c | 8 --------
3 files changed, 1 insertion(+), 29 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/HalPhyRf.c b/drivers/staging/rtl8723bs/hal/HalPhyRf.c
index 2e10817bf3dd..b8e385fdda89 100644
--- a/drivers/staging/rtl8723bs/hal/HalPhyRf.c
+++ b/drivers/staging/rtl8723bs/hal/HalPhyRf.c
@@ -118,9 +118,6 @@ void ODM_TXPowerTrackingCallback_ThermalMeter(struct adapter *Adapter)
/* 4 3. Initialize ThermalValues of RFCalibrateInfo */
- if (pDM_Odm->RFCalibrateInfo.bReloadtxpowerindex)
- {}
-
/* 4 4. Calculate average thermal meter */
pDM_Odm->RFCalibrateInfo.ThermalValue_AVG[pDM_Odm->RFCalibrateInfo.ThermalValue_AVG_index] = ThermalValue;
@@ -273,16 +270,6 @@ void ODM_TXPowerTrackingCallback_ThermalMeter(struct adapter *Adapter)
/* to increase TX power. Otherwise, EVM will be bad. */
/* */
/* 2012/04/25 MH Add for tx power tracking to set tx power in tx agc for 88E. */
- if (ThermalValue > pDM_Odm->RFCalibrateInfo.ThermalValue) {
- if (c.RfPathCount > 1)
- {}
-
- } else if (ThermalValue < pDM_Odm->RFCalibrateInfo.ThermalValue) { /* Low temperature */
-
- if (c.RfPathCount > 1)
- {}
-
- }
if (ThermalValue > pHalData->EEPROMThermalMeter) {
for (p = ODM_RF_PATH_A; p < c.RfPathCount; p++)
diff --git a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c
index 471418f3f724..858aafc24931 100644
--- a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c
+++ b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c
@@ -689,8 +689,7 @@ static u8 phy_PathA_RxIQK8723B(
(tmp < 0xf)
)
result |= 0x02;
- else /* if Tx not OK, ignore Rx */
- {}
+
return result;
}
@@ -988,8 +987,6 @@ static u8 phy_PathB_RxIQK8723B(struct adapter *padapter, bool configPathB)
(tmp < 0xf)
)
result |= 0x02;
- else
- {}
return result;
}
@@ -1500,7 +1497,6 @@ static void phy_IQCalibrate_8723B(
result[t][2] = (PHY_QueryBBReg(pDM_Odm->Adapter, rRx_Power_Before_IQK_A_2, bMaskDWord)&0x3FF0000)>>16;
result[t][3] = (PHY_QueryBBReg(pDM_Odm->Adapter, rRx_Power_After_IQK_A_2, bMaskDWord)&0x3FF0000)>>16;
break;
- } else {
}
}
@@ -1533,13 +1529,10 @@ static void phy_IQCalibrate_8723B(
result[t][6] = (PHY_QueryBBReg(pDM_Odm->Adapter, rRx_Power_Before_IQK_A_2, bMaskDWord)&0x3FF0000)>>16;
result[t][7] = (PHY_QueryBBReg(pDM_Odm->Adapter, rRx_Power_After_IQK_A_2, bMaskDWord)&0x3FF0000)>>16;
break;
- } else {
}
}
/* Allen end */
- if (0x00 == PathBOK) {
- }
}
/* Back to BB mode, load original value */
diff --git a/drivers/staging/rtl8723bs/hal/odm_PathDiv.c b/drivers/staging/rtl8723bs/hal/odm_PathDiv.c
index cfcbc3741803..bedce2c10b22 100644
--- a/drivers/staging/rtl8723bs/hal/odm_PathDiv.c
+++ b/drivers/staging/rtl8723bs/hal/odm_PathDiv.c
@@ -9,16 +9,8 @@
void odm_PathDiversityInit(void *pDM_VOID)
{
- struct dm_odm_t *pDM_Odm = (struct dm_odm_t *)pDM_VOID;
-
- if (!(pDM_Odm->SupportAbility & ODM_BB_PATH_DIV))
- {}
}
void odm_PathDiversity(void *pDM_VOID)
{
- struct dm_odm_t *pDM_Odm = (struct dm_odm_t *)pDM_VOID;
-
- if (!(pDM_Odm->SupportAbility & ODM_BB_PATH_DIV))
- {}
}
--
2.20.1
next prev parent reply other threads:[~2021-04-30 14:57 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-30 14:56 [PATCH v3 00/43] staging: rtl8723bs: clean up driver from private debug facilities Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 01/43] staging: rtl8723bs: remove ODM_RT_TRACE logs Fabio Aiuto
2021-04-30 14:56 ` Fabio Aiuto [this message]
2021-05-03 7:27 ` [PATCH v3 02/43] staging: rtl8723bs: remove if-else blocks left empty by ODM_RT_TRACE deletion Dan Carpenter
2021-05-03 7:42 ` Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 03/43] staging: rtl8723bs: remove empty functions Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 04/43] staging: rtl8723bs: remove empty hal/odm_PathDiv.c source file Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 05/43] staging: rtl8723bs: remove undefined function prototypes Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 06/43] staging: rtl8723bs: remove empty header file Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 07/43] staging: rtl8723bs: remove ODM_RT_TRACE* unused macro defs Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 08/43] staging: rtl8723bs: remove all commented out ODM_RT_TRACE logs Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 09/43] staging: rtl8723bs: replace ODM_RT_ASSERT with netdev_dbg() Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 10/43] staging: rtl8723bs: remove unused ODM_RT_ASSERT macro Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 11/43] staging: rtl8723bs: remove unused ODM_PRINT_ADDR macro Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 12/43] staging: rtl8723bs: remove unused ODM_dbg_trace macro Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 13/43] staging: rtl8723bs: remove unused ODM_dbg_enter Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 14/43] staging: rtl8723bs: remove unused ODM_dbg_exit macro Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 15/43] staging: rtl8723bs: remove empty ifdef block Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 16/43] staging: rtl8723bs: remove unused ASSERT macro Fabio Aiuto
2021-05-03 7:31 ` Dan Carpenter
2021-05-03 7:43 ` Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 17/43] staging: rtl8723bs: remove empty #ifndef block Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 18/43] staging: rtl8723bs: remove commented out RT_ASSERT occurrences Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 19/43] staging: rtl8723bs: remove unused RT_PRINTK macro Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 20/43] staging: rtl8723bs: remove BTC_PRINT logs Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 21/43] staging: rtl8723bs: remove empty if-else blocks after BTC_PRINT removal Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 22/43] staging: rtl8723bs: remove braces around single statement in if block Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 23/43] staging: rtl8723bs: remove commented out BTC_PRINT logs Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 24/43] staging: rtl8723bs: remove BTC_PRINT macro definitions Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 25/43] staging: rtl8723bs: remove BTC_PRINT_ADDR " Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 26/43] staging: rtl8723bs: remove BTC_PRINT_DATA definitions Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 27/43] staging: rtl8723bs: remove BTC_PRINT_F macro definition Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 28/43] staging: rtl8723bs: remove empty #ifdef block Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 29/43] staging: rtl8723bs: remove unsed hal_btcoex_SetDBG() function Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 30/43] staging: rtl8723bs: remove hal_btcoex_GetDBG() function Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 31/43] staging: rtl8723bs: remove unnecessary halbtcoutsrc_DbgInit() function Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 32/43] staging: rtl8723bs: remove obsolete GLBtcDbgType array declarations Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 33/43] staging: rtl8723bs: remove unused enum Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 34/43] staging: rtl8723bs: remove obsolete debug macros Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 35/43] staging: rtl8723bs: remove commented out DbgPrint logs Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 36/43] staging: rtl8723bs: remove unused DbgPrint macro Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 37/43] staging: rtl8723bs: remove commented out *RT_DISP logs Fabio Aiuto
2021-04-30 14:57 ` [PATCH v3 38/43] staging: rtl8723bs: remove RT_DISP macro definition Fabio Aiuto
2021-04-30 14:57 ` [PATCH v3 39/43] staging: rtl8723bs: remove ODM_InitDebugSetting() function Fabio Aiuto
2021-04-30 14:57 ` [PATCH v3 40/43] staging: rtl8723bs: remove empty hal/odm_debug.c file Fabio Aiuto
2021-04-30 14:57 ` [PATCH v3 41/43] staging: rtl8723bs: remove member in dm_odm_t struct Fabio Aiuto
2021-04-30 14:57 ` [PATCH v3 42/43] staging: rtl8723bs: remove DebugLevel " Fabio Aiuto
2021-04-30 14:57 ` [PATCH v3 43/43] staging: rtl8723bs: remove odm_debug.h header file Fabio Aiuto
2021-05-03 7:52 ` [PATCH v3 00/43] staging: rtl8723bs: clean up driver from private debug facilities Dan Carpenter
2021-05-03 8:17 ` Fabio Aiuto
2021-05-03 9:24 ` Sergio Paracuellos
2021-05-03 10:34 ` Fabio Aiuto
2021-05-03 11:48 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e1196ebf56787f62dcbfbcba1fcbc2ed37a65ce.1619794331.git.fabioaiuto83@gmail.com \
--to=fabioaiuto83@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox