From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6691C10798 for ; Thu, 1 Dec 2022 22:45:37 +0000 (UTC) Received: from [192.168.1.139] ([37.4.248.27]) by mrelayeu.kundenserver.de (mreue010 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MUY5o-1pRJ9q0q2K-00QV4K; Thu, 01 Dec 2022 23:45:26 +0100 Message-ID: <0f683076-43e6-3f65-e5e1-052059ce7c86@i2se.com> Date: Thu, 1 Dec 2022 23:45:22 +0100 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 00/14] staging: vc04_services: bcm2835-isp support To: Umang Jain , linux-media@vger.kernel.org, kernel-list@raspberrypi.com, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, Broadcom internal kernel review list Cc: Dave Stevenson , Florian Fainelli , Naushir Patuck , David Plowman , Kieran Bingham , Laurent Pinchart References: <20221121214722.22563-1-umang.jain@ideasonboard.com> Content-Language: en-US From: Stefan Wahren In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:AVI9HLFirIbBTe9u1s/kpHdsYNAsYCtTE1hCN3UyP/yXGQzfy7d ZGRAGDezR0tYOI1WUZ/7tPXgAvgx/nATHY222skj3dt02+nUvBml3huiupYPhfK/BTHQdJf 8NwGQihNa0M2TvjqOMz12w7HWOIY2ZGuDIWgLEMMWsnalIpy9WIAF3FwDyxUeo7v4Vdfweo XxjzDRzxv6fZ9AchqFj1Q== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:D6o8F6DY/+s=:WU5L+AmhqeWuHvQOWdr+6Y ilrs3AX/B74is7TQGcT4OJRzPXa3BW7pdo2oTs/vAtSI/PxYB2Y++bXe1ybE4tF4250JpCLv1 SX0xo1uOnPwLNaak/Aijwp9NX6N/MmwufeE9b1Mvm0XqU6yTwxjzTHpk4srKDcdXDefCyDnqo v1QYoVqnmLdCmZzv1A6BM2VebmNVckU/uJzvjkcO6/0H8GqCCT3neIzAp+Mcy5jflrFPBz5GM q/z69jbcHih5v/Tuuvv8FFIzQNfd9vHTTCdxgoKPj75KSbeRqAQMckzydiewh7jWfUCFO6xEC mF8Ci0rJkxCCi16FfTUCG3wVzrch7dzXj2H4AD56dpN3pXosupxqa2sZ/gkTClPqarKCueVFr +1zKlOHJ2PYPSmPOqX08aJCZLULNIgubVXRD2uknegngu+CtCULVil+Wy4QAWeGTZpNkXD45k QDRdAtTqE65d1j04h8Y3GjJzxlA0Ush4uGJ9aLb4Q3T4/BfJG/K4A857wywBbptEUvsKjXFiK ivCqZSApkSc4GNKb/Qgt5iCrj7Fkcwqvh0df+BFdVLSXp7VeUTg2aOkcQGvXQFZhc8QHck7CB 3zQW1D6lErS0FCJQODwFPWYZb9ljZ1tnjutQnQDpsDBHKU0vnTzqZi/o4pNx8vVH6l1FqrAR7 dckDDF/0yvp40OAQ39vNsKYbVYUq3fyvp5kS5Lz4+TbWw6d2TXCI+2+VZE7fdYd1xWtOY9Yy0 RHHMiYZGQrKJXdtiByGrpzaQNzzghCu+vjuEHIz1GAItYeFOqClFGeY8HDDA7eQiTMhL2bJJm 0WsOgoc Hi Umang, Am 30.11.22 um 11:58 schrieb Umang Jain: > Hi Stefan, > > On 11/27/22 6:56 AM, Stefan Wahren wrote: >> Hi Umang, >> >> Am 26.11.22 um 17:26 schrieb Umang Jain: >>> Hi Stefan >>> >>> On 11/26/22 8:12 PM, Stefan Wahren wrote: >>>> Hi Umang, >>>> >>>> Am 21.11.22 um 22:47 schrieb Umang Jain: >>>>> This series aims to upport bcm2835-isp from the RPi kernel [1] and >>>>> is a >>>>> independent subset of earlier series [2] posted to upport CSI-2/CCP2 >>>>> receiver IP core("Unicam) + the ISP driver found in BCM283x and >>>>> compatible >>>>> SoCs (namely BCM2711). Unicam is still under active development to >>>>> work >>>>> with multistream support to get into mainline. Hence only the ISP >>>>> driver >>>>> will remain the primary area of this series. >>>> >>>> thanks for working on this. But honestly i would prefer that vchiq >>>> comes out of staging before adding more features. As Greg said some >>>> time ago staging is not a place to "dump code and run away". These >>>> new files are in the same bad shape as the rest of vc04 before the >>>> clean-up here in staging started. >>> >>> Certainly, I am not here to do that - but I am still learning the >>> ropes. >> no problem. >>> >>> If the staging issue is becoming a blocker for bcm2835-isp going >>> upstream, I would be happy to help here! Though I must mention that >>> I still have limited visibility so my aim would be to chart out a >>> plan of things needed to be done to get vc04_services out of staging! >> >> The vchiq driver is in staging since 2016, so every step forwards is >> good. Unfortunately all of the low hanging fruits has been gathered. >> >> For me the most important, but not to tricky steps to get vchiq out >> of staging would be: >> >> * Cleanup logging mechanism >> >> * Get rid of custom function return values >> >> There was already an attempt for this [1] >> >> * Get rid of all non essential global structures and create a proper per >> device structure >> >>> >>>> >>>> I agree that VCSM is on the TODO list for vchiq, but this driver is >>>> not necessary for making bcm2835-audio & bcm2835-camera leave >>>> staging. It just binds more resources on a new feature. > > bcm2835-camera is the legacy camera stack which probably need to be > dropped from hereon... I don't not know if there any users left, so i would be careful here. Can bcm2835-isp completely replace bcm2835-camera? Sorry, for this dumb question but i'm not expert here. >>> >>> I see two TODO files in vc04_services: >>>     ./bcm2835-camera/TODO >>>     ./interface/TODO >>> >>> One of the bcm2835-camera TODO points to the vc-sm-cma driver >>> itself. So that's address in the series. The other remaining one - I >>> will need to take a deeper look before commenting on it. >>> >>> The main chunk of TODO are in vc04_services/interfaces/TODO. Doing a >>> cursory reading of them suggests that these apply to *all* >>> vc04_services components? Am I right? >> Actually these applies just for the interfaces directory. Some of >> them could apply to the services, but this is no priority. > > By no priority, you mean this doesn't affect the criteria required to > ful-fill to get these out of staging? Correct >>> >>> Are these are the specific bits of cleanup you are referring to in >>> your comment? >> >> You mean about bcm2835-isp? There were too many changes to vchiq that >> i don't remember them all. The first that come to my mind was those >> fancy comment sections which is not kernel coding style. It has been >> removed. > > No, I don't mean the bcm2835-isp changes (those are upcoming / > out-of-tree still so...). I mean what are the specific bits / points > that needs to be addressed to get vc04_services out of the staging. These were the points which i mentioned in my last email. They came from interface/TODO. > > You have mentioned it above now, so I'll follow up on those. That would be great :) > The many vchiq changes you referred to above comment (that you don't > remember) are from [1] as well or some other series ? Sorry, for the confusing. The many changes i refer were the dozens of clean up patches for vc04_interfaces in mainline staging since the last years. [1] was just a single patch which has been accepted yet. > >> >> [1] - >> https://lore.kernel.org/linux-staging/20220712181928.17547-1-jslebodn@redhat.com/ >> >>> >>> >>>> >>>> Unfortuntately i hadn't much time to work on vchiq by myself. >>>> >>>> Just my two cents >>>> Stefan >>>> >>> >>> >>> _______________________________________________ >>> linux-arm-kernel mailing list >>> linux-arm-kernel@lists.infradead.org >>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >