Re: [PATCH v3 3/6] staging: r8188eu: add error handling of rtw_read8

Pavel Skripkin
2021-08-25T12:17:11Z

On 8/25/21 3:05 PM, kernel test robot wrote:
> Hi Pavel,
>
> Thank you for the patch! Yet something to improve:
>
> [auto build test ERROR on staging/staging-testing]
>
> url: https://github.com/0day-ci/linux/commits/Pavel-Skripkin/staging-r8188eu-remove-read-write-_macreg/20210824-162756
> base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 093991aaadf0fbb34184fa37a46e7a157da3f386
> config: arm-buildonly-randconfig-r001-20210825 (attached as .config)
> compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project ea08c4cd1c0869ec5024a8bb3f5cdf06ab03ae83)
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # install arm cross compiling tool for clang build
> # apt-get install 11.1.1
> # https://github.com/0day-ci/linux/commit/d4e4bbed4e59df37967086f60fe92cb1b4504d37
> git remote add linux-review https://github.com/0day-ci/linux
> git fetch --no-tags linux-review Pavel-Skripkin/staging-r8188eu-remove-read-write-_macreg/20210824-162756
> git checkout d4e4bbed4e59df37967086f60fe92cb1b4504d37
> # save the attached .config to linux build tree
> mkdir build_dir
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross O=build_dir ARCH=arm SHELL=/bin/bash drivers/staging/r8188eu/
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
>>> drivers/staging/r8188eu/hal/usb_halinit.c:2022:3: error: expected expression
> u8 tmp;
> ^
> 1 error generated.
>
> Kconfig warnings: (for reference only)
> WARNING: unmet direct dependencies detected for QCOM_SCM
> Depends on (ARM || ARM64) && HAVE_ARM_SMCCC
> Selected by
> - ARM_QCOM_SPM_CPUIDLE && CPU_IDLE && (ARM || ARM64) && (ARCH_QCOM || COMPILE_TEST && !ARM64 && MMU
>
>

We need to fix Kconfig, ok, I will take a look at it later

> vim +2022 drivers/staging/r8188eu/hal/usb_halinit.c
>

> 2020 case HW_VAR_BCN_VALID:
> 2021 /* BCN_VALID, BIT(16) of REG_TDECTRL = BIT(0) of REG_TDECTRL+2, write 1 to clear, Clear by sw */
>> 2022 u8 tmp;

Hm, I don't know anything about ARM compilers, so should I wrap this
code block with {}?

My local gcc 11.1.1 (x86_64) does not produce any warnings/errors

> 2023
> 2024 error = rtw_read8(Adapter, REG_TDECTRL + 2, &tmp);
> 2025 if (error)
> 2026 return;
> 2027
> 2028 rtw_write8(Adapter, REG_TDECTRL + 2, tmp | BIT(0));
> 2029 break;
> 2030 default:
> 2031 break;
> 2032 }
> 2033
>

With regards,
Pavel Skripkin