Re: [PATCH v3 0/6] staging: r8188eu: avoid uninit value bugs

Pavel Skripkin
2021-08-27T07:53:03Z

On 8/27/21 10:49 AM, Kari Argillander wrote:
> On Tue, Aug 24, 2021 at 10:25:45AM +0300, Pavel Skripkin wrote:
>> Hi, Greg, Larry and Phillip!
>>
>> I noticed, that new staging driver was added like 3 weeks ago and I decided
>> to look at the code, because drivers in staging directory are always buggy.
>>
>> The first thing I noticed is *no one* was checking read operations result, but
>> it can fail and driver may start writing random stack values into registers. It
>> can cause driver misbehavior or device misbehavior.
>>
>> To avoid this type of bugs, i've changed rtw_read* API. Now all rtw_read
>> funtions return an error, when something went wrong with usb transfer.
>>
>> It helps callers to break/return earlier and don't write random values to
>> registers or to rely on random values.
>>
>>
>> v2 -> v3:
>
> Hi Pavel.
>
> If v4 is needed can you please send it without replying to old message.
> This thread is so hard to follow because always new version is answer to
> old subject. This depens a little bit how you setup your email, but some
> of us is grouping all emails in same thread and this thread is out of
> control :D
>

Hi, Kari!

v4 will be posted soon, yep. I will post v4 as separate thread :) It's
unreal to follow the discussion for sure. I often spend about a minute
to find an actual mail to reply xd

With regards,
Pavel Skripkin