From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 25EBA6AAC; Tue, 12 Jul 2022 21:28:59 +0000 (UTC) Received: by mail-ej1-f50.google.com with SMTP id ez10so16570930ejc.13; Tue, 12 Jul 2022 14:28:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BknaE/Kld0FnjC1aUofNUzwSa+QGAFkBMskakzse0z8=; b=oN5XoqcVxMnycuXA07RCPGjZGDbKv2XzrtoJdpEJqM+T/yQqztcOiBEJz+KqUqqJga kw+SX/a38LI8HrpIyvN00Sbql19iG/4qDMO5R7dVKWLrNZjZ/E32SM4Ct8/1sjlnQEvY jgrD6Usb1wE4swF5y3adFtdK17D5h5AYUAjgGh/JcsuDFRQPGc3krlBvRWHgeV2FqwN6 xxHG4wI1ZSJHbHvfA9ksmdK3ND3XVYsJVUcmpkbzGs8o0eU+i+pf2oTxtDfcO2p+SzWu BcSKR36gyCkwm6wLNXFThR7tMjPOh084ssJxilJ4bp2NcqjfmpdRq5ufZU69xOQ4AF9a EjLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BknaE/Kld0FnjC1aUofNUzwSa+QGAFkBMskakzse0z8=; b=7KsVBA+zuS+RCkgM4j/SAX9H3DPtM86zpgDBKZ0j04j2vaHuKLfcPrANhkNbWUolb4 2NlYhoZ0teYL145WqTMUkJOTRC9xwxfIXo0KICC5yunXqA3viNCj2QhHwZwqzPdOX+gV 4ICSNnJ/aD9y/1iDtv2Ue15QTSbt8ZrvQBNyYFuOrpUV12Fu7Y2CGQ7aaycdiHBbFVF7 x6K5Xz5Wax2pxkBNVFpQXMqm4ccKqaQ6K2x05zy+OrkDTdekxoEFVLNjaPkCREeHayLP d19t+WnP6zy1QLGkeF+6FQm0206UVUqC7x3416OnReH0CuJNArNh0pe0KRRcc+VwffM+ 8FtQ== X-Gm-Message-State: AJIora9MLbIVA8TznoGMESVE74IU4qjCc7HwqcbJlFq0SArnI+0KBxo/ cQ0nT2Qa94xgCnE0E1MyBik= X-Google-Smtp-Source: AGRyM1ty94Bi/kThUyYCtcONkfQEatSMxB4zQNDcet6s1fIeNCkp6cZN9Ip6+R4/UZLfNCXrGMqLvg== X-Received: by 2002:a17:907:d18:b0:726:3172:2266 with SMTP id gn24-20020a1709070d1800b0072631722266mr129773ejc.476.1657661337442; Tue, 12 Jul 2022 14:28:57 -0700 (PDT) Received: from kista.localnet (213-161-3-76.dynamic.telemach.net. [213.161.3.76]) by smtp.gmail.com with ESMTPSA id c17-20020a056402121100b00437e08d319csm6572339edw.61.2022.07.12.14.28.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jul 2022 14:28:56 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: mripard@kernel.org, paul.kocialkowski@bootlin.com, wens@csie.org, samuel@sholland.org Cc: mchehab@kernel.org, gregkh@linuxfoundation.org, hverkuil-cisco@xs4all.nl, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/7] media: cedrus: h265: Implement tiles support Date: Tue, 12 Jul 2022 23:28:55 +0200 Message-ID: <12371972.VsHLxoZxqI@kista> In-Reply-To: <20220620175517.648767-1-jernej.skrabec@gmail.com> References: <20220620175517.648767-1-jernej.skrabec@gmail.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Dne ponedeljek, 20. junij 2022 ob 19:55:10 CEST je Jernej Skrabec napisal(a): > Now that we have full and stable HEVC uAPI, let's implement last big > missing piece of HEVC in Cedrus - tiles support. This is done in > last patch. Before that, there are bug fixes (patch 1 & 2, previously > submitted separately in [1]), error handling improvements (patch 3, 4) > and added helper for dealing with dynamic arrays (patch 5). > > These patches are based on top of [2]. > > Final fluster score with this series is 125/147. 11 bitstreams are > MAIN10, which is not yet properly supported. 5 bitstreams need better > memory management with auxiliary buffers (wip patches exists). 4 are > too big and 2 probably fails due to ffmpeg implementation. > > Used ffmpeg source is in [3]. > > Note - Cedrus driver currently supports only one slice per request since > HW takes data for 1 slice only. This can be improved by loading data for > next slice automatically after HW signalled end of decoding. Something > for later. > > Please take a look. > > Best regards, > Jernej > > [1] https://patchwork.linuxtv.org/project/linux-media/list/?series=8187 > [2] https://patchwork.linuxtv.org/project/linux-media/list/?series=8208 > [3] https://github.com/jernejsk/FFmpeg/commits/hevc-mainline > > Jernej Skrabec (7): > media: cedrus: h265: Fix flag name > media: cedrus: h265: Fix logic for not low delay flag > media: cedrus: Improve error messages for controls > media: cedrus: Add error handling for failed setup > media: cedrus: h265: Add a couple of error checks > media: cedrus: Add helper for determining number of elements > media: cedrus: h265: Implement support for tiles Hi Hans, do you mind picking patch 6 and 7? They are reviewed and don't depend on patch 5. Best regards, Jernej