From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0DB34C62A for ; Sat, 20 Apr 2024 23:15:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713654960; cv=none; b=LByzTxlJqU70ZDaRNphMrxA/Q8omB4+urMWwTRptWikbXdf7kskiy6wcu/O1Sx9O9nnMu/SCElPfkcGN6+/z17Ngp+obevF260X4/JU3heFi/GrNiJMwGipdVgjxj42lUGd96cVSYbGXOjTnk/aETTAwbQtakx3vDqo1LtzvPvM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713654960; c=relaxed/simple; bh=NUrvewJBcU9hHyp8pm+RCmXt1n//pDwbkcHy0aq0J3A=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RToEJGL84eCsgxc6Q3gOgphlrYrGE3KdN8nmB4PEdG6JEvCW5iNaMlhW8PNMdBwzrJJzLM1U4zDCGbNK4fRiWPQHlaktkfAIo4cb6r/gnqdpAwMS8GyoNq5sYcOLkZLI5U8z4vPNnvuMZQFZa9ckuLq5YG31M5drOGecI+MGquk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=UWayZwsb; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="UWayZwsb" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-41a24251123so1571145e9.2 for ; Sat, 20 Apr 2024 16:15:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713654957; x=1714259757; darn=lists.linux.dev; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kQknuL+r9cbmTtmVlTx7T5fh7q9KKWBimZWASaRekHw=; b=UWayZwsbE63i6TN34lYVIr5LzuYxhetsjMMktv0WoJQGo3qC6FiqTxvAqJ+M0JMzJi hoBhGldht20RKZu7Q4fTCn7MgyIJyz4r8W27JoH3aixsYyqasC1feeRdyEcDykbDZfvR 8Hf3yJXtPsoqoQZQCfeqa8hGVspqpieDup+0dFOByPnKcJKgDt3aRRkIadnOEQZ6jpmJ 2rkkuvcWeLx5oqTkuU00AYKNnpAdLsgbtepBkN/1AYJPcGeDrW7iLfZ3H7nLRxKmDrcy lsoVKE+PlNJEieaZfvD1kum5JdOwaQKzs/54HRPcwZtX4UNR3ZqH5z+K/34TOW2kh0FM N67A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713654957; x=1714259757; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kQknuL+r9cbmTtmVlTx7T5fh7q9KKWBimZWASaRekHw=; b=uYmc5uVNx/4v15uNH3FwUcpt28SemUP8ZOul9ZaVcTjCnqfEpiDH8AAd90CK6IEurt iQBuGUM98us1kc1m+apEWYxLJFR1IuDJ+Ao0ovtICjmh2tFuPiPZO/KNSXCKDMCE7LNo PxpjVH8VvZ9FKwzjhNM7xaqbDqees0Ec2KiMxUsbG/ZpTaJmMdOBRCLRyThOromU7nhE WA3GFcULJdYfiobAobZr0v328D+/JGXYLOh4XNuC6z4ZI+js6rPDOOscjQONGgcACVQe nxP/STLUc06nKlVG7TAANtVBoiAaVXKeOtZ7+gbS3oJu9fVv0T8FQRM9YhSY9ppHBW4L ET8A== X-Forwarded-Encrypted: i=1; AJvYcCWE8vbR4jF+EgxStBmqz0X8pk6yTw8rC5AiRwc1i1JZClvs8xbxSbmMagneHCeQekqn+0y6YaTT1NYYmDCo4jUP66GhwWjdN2lEThSPYA== X-Gm-Message-State: AOJu0YzM0Bps3B2xHsdD1/QISOsj4FXSte4TOkLLCofHw9zwDXwtGDhd voPvr6PSH1NQUbUgaJkYvHOs5esFlMqcJ4s4m2w7dJGMFCUoPP5EeUT1gSMZ4pM= X-Google-Smtp-Source: AGHT+IEJ0pmo+Vbh8mjcD98mOO7pRnAuIGNTQ6Q1qc2nTTg8q3KESPbMSdkxwInYUTYo3kcHGC3OsQ== X-Received: by 2002:a05:600c:5486:b0:419:f497:632f with SMTP id iv6-20020a05600c548600b00419f497632fmr1710464wmb.29.1713654957220; Sat, 20 Apr 2024 16:15:57 -0700 (PDT) Received: from [192.168.0.102] ([176.61.106.68]) by smtp.gmail.com with ESMTPSA id q2-20020adfab02000000b00349d8717feasm7913040wrc.56.2024.04.20.16.15.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 20 Apr 2024 16:15:56 -0700 (PDT) Message-ID: <124e35b3-5b0d-4bd7-848a-5c848b339157@linaro.org> Date: Sun, 21 Apr 2024 00:15:55 +0100 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 06/26] media: stm32-dcmipp: Remove redundant printk To: Ricardo Ribalda , Martin Tuma , Mauro Carvalho Chehab , Laurent Pinchart , Hugues Fruchet , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Paul Kocialkowski , Greg Kroah-Hartman , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Sakari Ailus , Thierry Reding , Jonathan Hunter , Sowjanya Komatineni , Luca Ceresoli , Matthias Brugger , AngeloGioacchino Del Regno , Hans Verkuil , Sergey Kozlov , Abylay Ospan , Ezequiel Garcia , Dmitry Osipenko , Benjamin Mugnier , Sylvain Petinot , Stanimir Varbanov , Vikash Garodia , Bjorn Andersson , Konrad Dybcio Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org References: <20240419-fix-cocci-v2-0-2119e692309c@chromium.org> <20240419-fix-cocci-v2-6-2119e692309c@chromium.org> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <20240419-fix-cocci-v2-6-2119e692309c@chromium.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 19/04/2024 10:47, Ricardo Ribalda wrote: > - if (irq <= 0) { > - return irq ? irq : -ENXIO; > - } You're dropping the original intent of the driver author there no ? when irq == 0 they want to return -ENXIO. --- bod