From: Hans de Goede <hdegoede@redhat.com>
To: Chris Morgan <macroalpha82@gmail.com>, linux-staging@lists.linux.dev
Cc: gregkh@linuxfoundation.org, fabioaiuto83@gmail.com,
kuba@kernel.org, saurav.girepunje@gmail.com,
Chris Morgan <macromorgan@hotmail.com>
Subject: Re: [PATCH] staging: rtl8723bs: Change rtw_ndev_notifier_call message to dbg
Date: Wed, 23 Mar 2022 16:49:30 +0100 [thread overview]
Message-ID: <13a5173d-d4c6-4539-8303-e6a5ff72ef13@redhat.com> (raw)
In-Reply-To: <20220323154237.21736-1-macroalpha82@gmail.com>
Hi,
On 3/23/22 16:42, Chris Morgan wrote:
> From: Chris Morgan <macromorgan@hotmail.com>
>
> The message received in the kernel log for the state of the notifier
> call doesn't seem to be of much help to end users. Changing the message
> type from info to dbg to hide the message unless you are debugging
> the kernel or the network subsystem.
>
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/staging/rtl8723bs/os_dep/os_intfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> index 05482341eefe..bc58bd8c38b2 100644
> --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> @@ -389,7 +389,7 @@ static int rtw_ndev_notifier_call(struct notifier_block *nb, unsigned long state
> if (dev->netdev_ops->ndo_do_ioctl != rtw_ioctl)
> return NOTIFY_DONE;
>
> - netdev_info(dev, FUNC_NDEV_FMT " state:%lu\n", FUNC_NDEV_ARG(dev),
> + netdev_dbg(dev, FUNC_NDEV_FMT " state:%lu\n", FUNC_NDEV_ARG(dev),
> state);
>
> return NOTIFY_DONE;
prev parent reply other threads:[~2022-03-23 15:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-23 15:42 [PATCH] staging: rtl8723bs: Change rtw_ndev_notifier_call message to dbg Chris Morgan
2022-03-23 15:49 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13a5173d-d4c6-4539-8303-e6a5ff72ef13@redhat.com \
--to=hdegoede@redhat.com \
--cc=fabioaiuto83@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kuba@kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=macroalpha82@gmail.com \
--cc=macromorgan@hotmail.com \
--cc=saurav.girepunje@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox