From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f46.google.com (mail-ot1-f46.google.com [209.85.210.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 945142CA0 for ; Tue, 7 Dec 2021 14:58:13 +0000 (UTC) Received: by mail-ot1-f46.google.com with SMTP id i5-20020a05683033e500b0057a369ac614so18358523otu.10 for ; Tue, 07 Dec 2021 06:58:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:in-reply-to:references:subject:date :message-id; bh=VgYpRv7FKDRFJkyswgOt8jfkEjY4KcUU5jFAaY5SUrw=; b=Gcb9A29kI/wqIdCAS+qFAxyKQDNfo3hjafVfLrxiiSqZ4lWQgGlcFp1/kWO83GBljK I6udXxhMZW3SsgHe2M3jFtITDrzICKNB7ir0ouFDNEHQIHg9Sdrsu3joskZrxQL557Ox ye+PWJeHMgYH1WX8dQEuaySus0JFDd0CP62SyO+GJGcrH+avTGL+H21Et6WU5TX+UQ2p +SNx3z5gA5SRTf0otuv8XFh6s/H9KlPY2+UzmiGOP8GqbZiaQuAlmffwEoBW9OHJCwRs y0KxiyvJqYmhI7YpLm4aa42fOH26NtZuN8EXVcGO3VargHUeyq4chUqr+S480nd4Ctzx 9ijA== X-Gm-Message-State: AOAM530KQPGTOgcLL7yvl27FcUrxy97yy51DrHvjtyLnLCp90OYwkF3W ckBhd6jFtadfpvQsB5lq0g== X-Google-Smtp-Source: ABdhPJxI+GdBHmtxK/QcTh3tcIy1ZwNfkubLUnPPWtqNhLRymXjSM4MMyk6de2SMgFGNU+/WHw79vA== X-Received: by 2002:a9d:4f0b:: with SMTP id d11mr35759185otl.227.1638889092708; Tue, 07 Dec 2021 06:58:12 -0800 (PST) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id m2sm2815394oop.12.2021.12.07.06.58.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Dec 2021 06:58:11 -0800 (PST) Received: (nullmailer pid 5797 invoked by uid 1000); Tue, 07 Dec 2021 14:58:10 -0000 From: Rob Herring To: Adam Ford Cc: linux-rockchip@lists.infradead.org, linux-staging@lists.linux.dev, linux-media@vger.kernel.org, Lucas Stach , Pengutronix Kernel Team , devicetree@vger.kernel.org, Ezequiel Garcia , Shawn Guo , Sascha Hauer , linux-kernel@vger.kernel.org, benjamin.gaignard@collabora.com, Rob Herring , Greg Kroah-Hartman , Fabio Estevam , NXP Linux Team , Mauro Carvalho Chehab , hverkuil@xs4all.nl, Philipp Zabel , linux-arm-kernel@lists.infradead.org, cphealy@gmail.com In-Reply-To: <20211207015446.1250854-4-aford173@gmail.com> References: <20211207015446.1250854-1-aford173@gmail.com> <20211207015446.1250854-4-aford173@gmail.com> Subject: Re: [RFC V2 3/6] dt-bindings: media: nxp,imx8mq-vpu: Update the bindings for G2 support Date: Tue, 07 Dec 2021 08:58:10 -0600 Message-Id: <1638889090.684232.5796.nullmailer@robh.at.kernel.org> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: On Mon, 06 Dec 2021 19:54:42 -0600, Adam Ford wrote: > From: Benjamin Gaignard > > Introducing the G2 hevc video decoder requires modifications of the bindings to allow > one node per VPU. > > VPUs share one hardware control block which is provided as a phandle on > a syscon. > Each node has now one reg and one interrupt. > Add a compatible for G2 hardware block: nxp,imx8mq-vpu-g2. > > To be compatible with older DT the driver is still capable to use the 'ctrl' > reg-name even if it is deprecated now. > > Signed-off-by: Benjamin Gaignard > Signed-off-by: Adam Ford > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/nxp,imx8mq-vpu.yaml: properties:clock-names:oneOf: [{'const': 'g1'}, {'const': 'g2'}] should not be valid under {'items': {'propertyNames': {'const': 'const'}, 'required': ['const']}} hint: Use 'enum' rather than 'oneOf' + 'const' entries from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/nxp,imx8mq-vpu.yaml: properties:interrupt-names:oneOf: [{'const': 'g1'}, {'const': 'g2'}] should not be valid under {'items': {'propertyNames': {'const': 'const'}, 'required': ['const']}} hint: Use 'enum' rather than 'oneOf' + 'const' entries from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/nxp,imx8mq-vpu.yaml: properties:compatible:oneOf: [{'const': 'nxp,imx8mq-vpu-g1'}, {'const': 'nxp,imx8mq-vpu-g2'}] should not be valid under {'items': {'propertyNames': {'const': 'const'}, 'required': ['const']}} hint: Use 'enum' rather than 'oneOf' + 'const' entries from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/nxp,imx8mq-vpu.yaml: ignoring, error in schema: properties: interrupt-names: oneOf warning: no schema found in file: ./Documentation/devicetree/bindings/media/nxp,imx8mq-vpu.yaml Error: Documentation/devicetree/bindings/media/nxp,imx8mq-vpu.example.dts:26.27-31 syntax error FATAL ERROR: Unable to parse input tree make[1]: *** [scripts/Makefile.lib:373: Documentation/devicetree/bindings/media/nxp,imx8mq-vpu.example.dt.yaml] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:1413: dt_binding_check] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1564457 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.