public inbox for linux-staging@lists.linux.dev
 help / color / mirror / Atom feed
From: Fabio Aiuto <fabioaiuto83@gmail.com>
To: gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH 04/25] staging: rtl8723bs: remove all if-blocks left empty by DBG_8192C-remove coccinelle script
Date: Sat, 10 Apr 2021 16:20:17 +0200	[thread overview]
Message-ID: <1676083964fe176e996c2c05dfdcb723b49febb6.1618064274.git.fabioaiuto83@gmail.com> (raw)
In-Reply-To: <cover.1618064274.git.fabioaiuto83@gmail.com>

remove all empty if blocks left empty by coccinelle
script for DBG_8192C macro removal.

Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
---
 drivers/staging/rtl8723bs/hal/sdio_ops.c        | 17 -----------------
 .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c   | 15 +--------------
 2 files changed, 1 insertion(+), 31 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c b/drivers/staging/rtl8723bs/hal/sdio_ops.c
index 763dd6062c74..4403ccdaf2ee 100644
--- a/drivers/staging/rtl8723bs/hal/sdio_ops.c
+++ b/drivers/staging/rtl8723bs/hal/sdio_ops.c
@@ -596,12 +596,6 @@ s32 sdio_local_write(
 	s32 err;
 	u8 *tmpbuf;
 
-	if (addr & 0x3)
-		{}
-
-	if (cnt  & 0x3)
-		{}
-
 	intfhdl = &adapter->iopriv.intf;
 
 	hal_sdio_get_cmd_addr_8723b(adapter, SDIO_LOCAL_DEVICE_ID, addr, &addr);
@@ -926,11 +920,6 @@ void sd_int_dpc(struct adapter *adapter)
 		}
 	}
 
-	if (hal->sdio_hisr & SDIO_HISR_TXBCNOK)
-		{}
-
-	if (hal->sdio_hisr & SDIO_HISR_TXBCNERR)
-		{}
 	if (hal->sdio_hisr & SDIO_HISR_C2HCMD) {
 		struct c2h_evt_hdr_88xx *c2h_evt;
 
@@ -952,12 +941,6 @@ void sd_int_dpc(struct adapter *adapter)
 		}
 	}
 
-	if (hal->sdio_hisr & SDIO_HISR_RXFOVW)
-		{}
-
-	if (hal->sdio_hisr & SDIO_HISR_RXERR)
-		{}
-
 	if (hal->sdio_hisr & SDIO_HISR_RX_REQUEST) {
 		struct recv_buf *recvbuf;
 		int alloc_fail_time = 0;
diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
index b7dffdaffda7..6d5109aa4b69 100644
--- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
+++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
@@ -1635,13 +1635,6 @@ static int rtw_cfg80211_set_wpa_ie(struct adapter *padapter, u8 *pie, size_t iel
 
 	memcpy(buf, pie, ielen);
 
-	/* dump */
-	{
-		int i;
-		for (i = 0; i < ielen; i = i + 8)
-			{}
-	}
-
 	if (ielen < RSN_HEADER_LEN) {
 		ret  = -1;
 		goto exit;
@@ -1874,11 +1867,6 @@ static int cfg80211_rtw_connect(struct wiphy *wiphy, struct net_device *ndev,
 	ndis_ssid.SsidLength = sme->ssid_len;
 	memcpy(ndis_ssid.Ssid, (u8 *)sme->ssid, sme->ssid_len);
 
-
-	if (sme->bssid)
-		{}
-
-
 	if (check_fwstate(pmlmepriv, _FW_UNDER_LINKING) == true) {
 		ret = -EBUSY;
 		goto exit;
@@ -2440,8 +2428,7 @@ static int rtw_add_beacon(struct adapter *adapter, const u8 *head, size_t head_l
 	len = head_len+tail_len-24;
 
 	/* check wps ie if inclued */
-	if (rtw_get_wps_ie(pbuf+_FIXED_IE_LENGTH_, len-_FIXED_IE_LENGTH_, NULL, &wps_ielen))
-		{}
+	rtw_get_wps_ie(pbuf+_FIXED_IE_LENGTH_, len-_FIXED_IE_LENGTH_, NULL, &wps_ielen);
 
 	/* pbss_network->IEs will not include p2p_ie, wfd ie */
 	rtw_ies_remove_ie(pbuf, &len, _BEACON_IE_OFFSET_, WLAN_EID_VENDOR_SPECIFIC, P2P_OUI, 4);
-- 
2.20.1


  parent reply	other threads:[~2021-04-10 14:20 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-10 14:20 [PATCH 00/25] staging: rtl8723bs: remove DBG_8192C tracing macro Fabio Aiuto
2021-04-10 14:20 ` [PATCH 01/25] staging: rtl8723bs: remove all DBG_8192C logs Fabio Aiuto
2021-04-10 14:20 ` [PATCH 02/25] staging: rtl8723bs: remove all commented out " Fabio Aiuto
2021-04-10 14:20 ` [PATCH 03/25] staging: rtl8723bs: remove DBG_8192C macro definitions Fabio Aiuto
2021-04-10 14:20 ` Fabio Aiuto [this message]
2021-04-10 14:20 ` [PATCH 05/25] staging: rtl8723bs: put spaces around operators Fabio Aiuto
2021-04-10 14:20 ` [PATCH 06/25] staging: rtl8723bs: remove unused code blocks guarded by DEBUG_RTL871X Fabio Aiuto
2021-04-10 14:20 ` [PATCH 07/25] staging: rtl8723bs: remove commented out DEBUG_RTL871X definition Fabio Aiuto
2021-04-10 14:20 ` [PATCH 08/25] staging: rtl8723bs: remove code blocks guarded by DEBUG symbol Fabio Aiuto
2021-04-10 14:20 ` [PATCH 09/25] staging: rtl8723bs: remove empty code block guarded by DBG_CCX Fabio Aiuto
2021-04-10 14:20 ` [PATCH 10/25] staging: rtl8723bs: remove code block guarded by undefined SDIO_DEBUG_IO Fabio Aiuto
2021-04-10 14:20 ` [PATCH 11/25] staging: rtl8723bs: remove commented out SDIO_DEBUG_IO symbol definition Fabio Aiuto
2021-04-10 14:20 ` [PATCH 12/25] staging: rtl8723bs: remove empty ifdef blocks conditioned to DEBUG_CFG80211 definition Fabio Aiuto
2021-04-10 14:20 ` [PATCH 13/25] staging: rtl8723bs: remove commented out DEBUG_CFG80211 symbol definition Fabio Aiuto
2021-04-10 14:20 ` [PATCH 14/25] staging: rtl8723bs: remove unnecessary bracks Fabio Aiuto
2021-04-10 14:20 ` [PATCH 15/25] staging: rtl8723bs: fix comparison to null Fabio Aiuto
2021-04-10 14:20 ` [PATCH 16/25] staging: rtl8723bs: put spaces around operators Fabio Aiuto
2021-04-10 14:20 ` [PATCH 17/25] staging: rtl8723bs: split long line Fabio Aiuto
2021-04-10 14:20 ` [PATCH 18/25] staging: rtl8723bs: put constant on the right side of the test Fabio Aiuto
2021-04-10 14:20 ` [PATCH 19/25] staging: rtl8723bs: remove empty if and else blocks Fabio Aiuto
2021-04-10 14:20 ` [PATCH 20/25] staging: rtl8723bs: put constant on the right side of a test in os_dep/ioctl_cfg80211.c Fabio Aiuto
2021-04-10 14:20 ` [PATCH 21/25] staging: rtl8723bs: remove unnecessary parentheses " Fabio Aiuto
2021-04-10 14:20 ` [PATCH 22/25] staging: rtl8723bs: remove empty else block " Fabio Aiuto
2021-04-10 14:20 ` [PATCH 23/25] staging: rtl8723bs: fix comparison to true issue Fabio Aiuto
2021-04-10 14:20 ` [PATCH 24/25] staging: rtl8723bs: remove more unnecessary parentheses Fabio Aiuto
2021-04-10 14:20 ` [PATCH 25/25] staging: rtl8723bs: remove more empty if blocks after DBG_8192C deletion Fabio Aiuto
2021-04-10 17:23   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1676083964fe176e996c2c05dfdcb723b49febb6.1618064274.git.fabioaiuto83@gmail.com \
    --to=fabioaiuto83@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox