Re: [PATCH 2/9] media: atomisp: Rename atomisp_set_crop_and_fmt()

[Kieran Bingham <kieran.bingham@ideasonboard.com>]

Quoting Hans de Goede (2024-02-17 11:24:31)
> Rename atomisp_set_crop_and_fmt() to atomisp_set_sensor_crop_and_fmt()
> to make clear that it operates on the sensor subdev.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
>  drivers/staging/media/atomisp/pci/atomisp_cmd.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/media/atomisp/pci/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
> index 8593ba90605f..eb37bb6e41f9 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp_cmd.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
> @@ -3721,9 +3721,9 @@ void atomisp_get_padding(struct atomisp_device *isp, u32 width, u32 height,
>         *padding_h = max_t(u32, *padding_h, min_pad_h);
>  }
>  
> -static int atomisp_set_crop_and_fmt(struct atomisp_device *isp,
> -                                   struct v4l2_mbus_framefmt *ffmt,
> -                                   int which)
> +static int atomisp_set_sensor_crop_and_fmt(struct atomisp_device *isp,
> +                                          struct v4l2_mbus_framefmt *ffmt,
> +                                          int which)

I went to look this up and I only see atomisp_set_crop() so I guess I've
missed some patches.

Does the atomisp use the usual v4l2-subdev drivers for sensors? or are
they separate for now ?

I'm curious about how it's handling the binning in that function, but
that's not specific to this patch which looks reasonable so far so:

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

>  {
>         struct atomisp_input_subdev *input = &isp->inputs[isp->asd.input_curr];
>         struct v4l2_subdev_selection sel = {
> @@ -3817,7 +3817,7 @@ int atomisp_try_fmt(struct atomisp_device *isp, struct v4l2_pix_format *f,
>  
>         dev_dbg(isp->dev, "try_mbus_fmt: try %ux%u\n", ffmt.width, ffmt.height);
>  
> -       ret = atomisp_set_crop_and_fmt(isp, &ffmt, V4L2_SUBDEV_FORMAT_TRY);
> +       ret = atomisp_set_sensor_crop_and_fmt(isp, &ffmt, V4L2_SUBDEV_FORMAT_TRY);
>         if (ret)
>                 return ret;
>  
> @@ -4263,7 +4263,7 @@ static int atomisp_set_fmt_to_snr(struct video_device *vdev, const struct v4l2_p
>  
>         /* Disable dvs if resolution can't be supported by sensor */
>         if (asd->params.video_dis_en && asd->run_mode->val == ATOMISP_RUN_MODE_VIDEO) {
> -               ret = atomisp_set_crop_and_fmt(isp, &ffmt, V4L2_SUBDEV_FORMAT_TRY);
> +               ret = atomisp_set_sensor_crop_and_fmt(isp, &ffmt, V4L2_SUBDEV_FORMAT_TRY);
>                 if (ret)
>                         return ret;
>  
> @@ -4281,7 +4281,7 @@ static int atomisp_set_fmt_to_snr(struct video_device *vdev, const struct v4l2_p
>                 }
>         }
>  
> -       ret = atomisp_set_crop_and_fmt(isp, &ffmt, V4L2_SUBDEV_FORMAT_ACTIVE);
> +       ret = atomisp_set_sensor_crop_and_fmt(isp, &ffmt, V4L2_SUBDEV_FORMAT_ACTIVE);
>         if (ret)
>                 return ret;
>  
> -- 
> 2.43.0
>