From: "Rob Herring (Arm)" <robh@kernel.org>
To: Cosmin Tanislav <demonsingur@gmail.com>
Cc: devicetree@vger.kernel.org,
"Biju Das" <biju.das.jz@bp.renesas.com>,
"Will Deacon" <will@kernel.org>,
"Dan Carpenter" <dan.carpenter@linaro.org>,
"Hans Verkuil" <hverkuil@xs4all.nl>,
"Umang Jain" <umang.jain@ideasonboard.com>,
"Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
"Taniya Das" <quic_tdas@quicinc.com>,
"Tomi Valkeinen" <tomi.valkeinen@ideasonboard.com>,
"Benjamin Mugnier" <benjamin.mugnier@foss.st.com>,
"Cosmin Tanislav" <cosmin.tanislav@analog.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
linux-gpio@vger.kernel.org,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
"Ricardo Ribalda" <ribalda@chromium.org>,
"Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
"Dongcheng Yan" <dongcheng.yan@intel.com>,
"Tommaso Merciai" <tomm.merciai@gmail.com>,
"Nícolas F . R . A . Prado" <nfraprado@collabora.com>,
linux-staging@lists.linux.dev,
"Ross Burton" <ross.burton@arm.com>,
"Conor Dooley" <conor+dt@kernel.org>,
"Javier Carrasco" <javier.carrasco@wolfvision.net>,
linux-kernel@vger.kernel.org,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
linux-arm-kernel@lists.infradead.org,
"Mark Brown" <broonie@kernel.org>,
"Eric Biggers" <ebiggers@google.com>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
linux-media@vger.kernel.org,
"Linus Walleij" <linus.walleij@linaro.org>,
"Bjorn Andersson" <quic_bjorande@quicinc.com>,
"Julien Massot" <julien.massot@collabora.com>,
"Ihor Matushchak" <ihor.matushchak@foobox.net>,
"Laurentiu Palcu" <laurentiu.palcu@oss.nxp.com>,
"Heiko Stuebner" <heiko@sntech.de>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Zhi Mao" <zhi.mao@mediatek.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Kieran Bingham" <kieran.bingham@ideasonboard.com>
Subject: Re: [RFC PATCH 04/24] dt-bindings: media: i2c: max96717: add support for pinctrl/pinconf
Date: Sat, 08 Mar 2025 14:44:57 -0600 [thread overview]
Message-ID: <174146669680.3550268.1623859001392058870.robh@kernel.org> (raw)
In-Reply-To: <20250308183410.3013996-5-demonsingur@gmail.com>
On Sat, 08 Mar 2025 20:33:33 +0200, Cosmin Tanislav wrote:
> MAX96717 is capable of configuring various pin properties.
>
> Add pinctrl/pinconf properties to support this usecase.
>
> Signed-off-by: Cosmin Tanislav <demonsingur@gmail.com>
> ---
> .../media/i2c/maxim,max96717-pinctrl.yaml | 71 +++++++++++++++++++
> .../bindings/media/i2c/maxim,max96717.yaml | 16 ++++-
> MAINTAINERS | 1 +
> 3 files changed, 87 insertions(+), 1 deletion(-)
> create mode 100644 Documentation/devicetree/bindings/media/i2c/maxim,max96717-pinctrl.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/maxim,max96717-pinctrl.yaml: properties:maxim,gmsl-rx-id: 'anyOf' conditional failed, one must be fixed:
'min' is not one of ['$ref', 'additionalItems', 'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies', 'dependentRequired', 'dependentSchemas', 'deprecated', 'description', 'else', 'enum', 'exclusiveMaximum', 'exclusiveMinimum', 'items', 'if', 'minItems', 'minimum', 'maxItems', 'maximum', 'multipleOf', 'not', 'oneOf', 'pattern', 'patternProperties', 'properties', 'required', 'then', 'typeSize', 'unevaluatedProperties', 'uniqueItems']
'type' was expected
from schema $id: http://devicetree.org/meta-schemas/keywords.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/maxim,max96717-pinctrl.yaml: properties:maxim,gmsl-rx-id: 'anyOf' conditional failed, one must be fixed:
'max' is not one of ['$ref', 'additionalItems', 'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies', 'dependentRequired', 'dependentSchemas', 'deprecated', 'description', 'else', 'enum', 'exclusiveMaximum', 'exclusiveMinimum', 'items', 'if', 'minItems', 'minimum', 'maxItems', 'maximum', 'multipleOf', 'not', 'oneOf', 'pattern', 'patternProperties', 'properties', 'required', 'then', 'typeSize', 'unevaluatedProperties', 'uniqueItems']
'type' was expected
from schema $id: http://devicetree.org/meta-schemas/keywords.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/maxim,max96717-pinctrl.yaml: properties:maxim,rclkout-clock: 'anyOf' conditional failed, one must be fixed:
'min' is not one of ['$ref', 'additionalItems', 'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies', 'dependentRequired', 'dependentSchemas', 'deprecated', 'description', 'else', 'enum', 'exclusiveMaximum', 'exclusiveMinimum', 'items', 'if', 'minItems', 'minimum', 'maxItems', 'maximum', 'multipleOf', 'not', 'oneOf', 'pattern', 'patternProperties', 'properties', 'required', 'then', 'typeSize', 'unevaluatedProperties', 'uniqueItems']
'type' was expected
from schema $id: http://devicetree.org/meta-schemas/keywords.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/maxim,max96717-pinctrl.yaml: properties:maxim,rclkout-clock: 'anyOf' conditional failed, one must be fixed:
'max' is not one of ['$ref', 'additionalItems', 'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies', 'dependentRequired', 'dependentSchemas', 'deprecated', 'description', 'else', 'enum', 'exclusiveMaximum', 'exclusiveMinimum', 'items', 'if', 'minItems', 'minimum', 'maxItems', 'maximum', 'multipleOf', 'not', 'oneOf', 'pattern', 'patternProperties', 'properties', 'required', 'then', 'typeSize', 'unevaluatedProperties', 'uniqueItems']
'type' was expected
from schema $id: http://devicetree.org/meta-schemas/keywords.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/maxim,max96717-pinctrl.yaml: properties:maxim,gmsl-tx-id: 'anyOf' conditional failed, one must be fixed:
'min' is not one of ['$ref', 'additionalItems', 'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies', 'dependentRequired', 'dependentSchemas', 'deprecated', 'description', 'else', 'enum', 'exclusiveMaximum', 'exclusiveMinimum', 'items', 'if', 'minItems', 'minimum', 'maxItems', 'maximum', 'multipleOf', 'not', 'oneOf', 'pattern', 'patternProperties', 'properties', 'required', 'then', 'typeSize', 'unevaluatedProperties', 'uniqueItems']
'type' was expected
from schema $id: http://devicetree.org/meta-schemas/keywords.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/maxim,max96717-pinctrl.yaml: properties:maxim,gmsl-tx-id: 'anyOf' conditional failed, one must be fixed:
'max' is not one of ['$ref', 'additionalItems', 'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies', 'dependentRequired', 'dependentSchemas', 'deprecated', 'description', 'else', 'enum', 'exclusiveMaximum', 'exclusiveMinimum', 'items', 'if', 'minItems', 'minimum', 'maxItems', 'maximum', 'multipleOf', 'not', 'oneOf', 'pattern', 'patternProperties', 'properties', 'required', 'then', 'typeSize', 'unevaluatedProperties', 'uniqueItems']
'type' was expected
from schema $id: http://devicetree.org/meta-schemas/keywords.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/maxim,max96717.example.dtb: serializer@40: i2c-gate: 'anyOf' conditional failed, one must be fixed:
Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'sensor@10' were unexpected)
1 is not of type 'object'
0 is not of type 'object'
Unevaluated properties are not allowed ('VANA-supply', 'VCORE-supply', 'VDDIO-supply', 'clocks', 'compatible', 'port', 'reg', 'reset-gpios' were unexpected)
from schema $id: http://devicetree.org/schemas/media/i2c/maxim,max96717.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250308183410.3013996-5-demonsingur@gmail.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2025-03-08 20:44 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-08 18:33 [RFC PATCH 00/24] media: i2c: add Maxim GMSL2/3 serializer and deserializer drivers Cosmin Tanislav
2025-03-08 18:33 ` [RFC PATCH 01/24] dt-bindings: media: i2c: max96717: add myself as maintainer Cosmin Tanislav
2025-03-08 18:33 ` [RFC PATCH 02/24] dt-bindings: media: i2c: max96717: reflow text Cosmin Tanislav
2025-03-08 18:33 ` [RFC PATCH 03/24] dt-bindings: media: i2c: max96717: add support for I2C ATR Cosmin Tanislav
2025-03-08 18:33 ` [RFC PATCH 04/24] dt-bindings: media: i2c: max96717: add support for pinctrl/pinconf Cosmin Tanislav
2025-03-08 20:44 ` Rob Herring (Arm) [this message]
2025-03-08 18:33 ` [RFC PATCH 05/24] dt-bindings: media: i2c: max96717: add support for MAX9295A Cosmin Tanislav
2025-03-08 18:33 ` [RFC PATCH 06/24] dt-bindings: media: i2c: max96717: add support for MAX96793 Cosmin Tanislav
2025-03-08 18:33 ` [RFC PATCH 07/24] dt-bindings: media: i2c: max96714: add myself as maintainer Cosmin Tanislav
2025-03-08 18:33 ` [RFC PATCH 08/24] dt-bindings: media: i2c: max96714: reflow text Cosmin Tanislav
2025-03-08 18:33 ` [RFC PATCH 09/24] dt-bindings: media: i2c: max96714: make i2c-gate conditional on compatible Cosmin Tanislav
2025-03-08 20:44 ` Rob Herring (Arm)
2025-03-10 12:32 ` Rob Herring
2025-03-10 12:52 ` Cosmin Tanislav
2025-03-08 18:33 ` [RFC PATCH 10/24] dt-bindings: media: i2c: max96714: make ports " Cosmin Tanislav
2025-03-08 18:33 ` [RFC PATCH 11/24] dt-bindings: media: i2c: max96714: make supply " Cosmin Tanislav
2025-03-08 18:33 ` [RFC PATCH 12/24] dt-bindings: media: i2c: max96714: add support for MAX9296A Cosmin Tanislav
2025-03-08 18:33 ` [RFC PATCH 13/24] dt-bindings: media: i2c: max96714: add support for MAX96716A Cosmin Tanislav
2025-03-08 18:33 ` [RFC PATCH 14/24] dt-bindings: media: i2c: max96714: add support for MAX96792A Cosmin Tanislav
2025-03-08 18:33 ` [RFC PATCH 15/24] dt-bindings: media: i2c: max96712: add myself as maintainer Cosmin Tanislav
2025-03-08 18:33 ` [RFC PATCH 16/24] dt-bindings: media: i2c: max96712: use pattern properties for input ports Cosmin Tanislav
2025-03-08 18:33 ` [RFC PATCH 17/24] dt-bindings: media: i2c: max96712: increase number of output ports Cosmin Tanislav
2025-03-08 18:33 ` [RFC PATCH 18/24] dt-bindings: media: i2c: max96712: add support for I2C MUX Cosmin Tanislav
2025-03-08 19:44 ` Rob Herring (Arm)
2025-03-08 18:33 ` [RFC PATCH 19/24] dt-bindings: media: i2c: max96712: add support for POC supplies Cosmin Tanislav
2025-03-08 19:59 ` Rob Herring (Arm)
2025-03-08 18:33 ` [RFC PATCH 20/24] media: i2c: add Maxim GMSL2/3 serializer and deserializer drivers Cosmin Tanislav
2025-03-08 18:33 ` [RFC PATCH 21/24] arm64: defconfig: disable deprecated MAX96712 driver Cosmin Tanislav
2025-03-08 18:33 ` [RFC PATCH 22/24] staging: media: remove " Cosmin Tanislav
2025-03-08 18:33 ` [RFC PATCH 23/24] media: i2c: remove MAX96717 driver Cosmin Tanislav
2025-03-08 18:33 ` [RFC PATCH 24/24] media: i2c: remove MAX96714 driver Cosmin Tanislav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174146669680.3550268.1623859001392058870.robh@kernel.org \
--to=robh@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=benjamin.mugnier@foss.st.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=cosmin.tanislav@analog.com \
--cc=dan.carpenter@linaro.org \
--cc=demonsingur@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dongcheng.yan@intel.com \
--cc=ebiggers@google.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=hverkuil@xs4all.nl \
--cc=ihor.matushchak@foobox.net \
--cc=javier.carrasco@wolfvision.net \
--cc=julien.massot@collabora.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=laurentiu.palcu@oss.nxp.com \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=nfraprado@collabora.com \
--cc=niklas.soderlund@ragnatech.se \
--cc=quic_bjorande@quicinc.com \
--cc=quic_tdas@quicinc.com \
--cc=ribalda@chromium.org \
--cc=ross.burton@arm.com \
--cc=sakari.ailus@linux.intel.com \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=tomm.merciai@gmail.com \
--cc=umang.jain@ideasonboard.com \
--cc=will@kernel.org \
--cc=zhi.mao@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox