From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 350612F6560 for ; Wed, 3 Sep 2025 13:48:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756907295; cv=none; b=Ie4FLPz1uTgaLa62hP4dNTKXL+II8XNYo6gs24UVzTbZ7rRPMBz/zSwkqvl7Y+Qb0HrqM4B7nyPUXgp3twXNxBwKBYeLthnj/ejTPviquEc2QkWvj8und+3WTW2scFWq3xPsYhcK5TQbyQOzBjZ/qLwyEOcnf9BgGwmfwDt+Wks= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756907295; c=relaxed/simple; bh=wHSYdEndGYVsU4nyD1UO39BeJ41HSWWrWO3/X8oENnI=; h=Content-Type:MIME-Version:In-Reply-To:References:Subject:From:Cc: To:Date:Message-ID; b=pmTBR/VoMp+V8kd1A78+mJqDLk5/Z89FPs9yjXBvmbYEW4Z/q5eF4OKjXrLOeRUE+K2vcLyHsBesNoTjj52/OTSForiSoBzUvT2P6vkYGF0nDmZNsyajh/xPfZ8GLykbJReSLZ8JnON1fhsVbdkyvorR3hEBXM+3fboYz3jW3V8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=j/80TZBI; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="j/80TZBI" Received: from mail.ideasonboard.com (unknown [IPv6:2401:4900:1c69:480e:e039:1d0b:c5ff:a9e2]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 8F429C6D; Wed, 3 Sep 2025 15:47:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1756907223; bh=wHSYdEndGYVsU4nyD1UO39BeJ41HSWWrWO3/X8oENnI=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=j/80TZBIS2ZgBtU2z7ngDSkl6Xqsr7xzKUvqOtwBn4fLRbLIAv/OAaMnCP5kjLf+d mecrk4AEnkcwsQYiOg7rj/MqqMcn+gS2p0cN6uKWd0+Teq0EfCBa6cWFDXGUvVNIIX 71MiP5VLXJjCIqvxK2NjVm0JRXfY8wghQfeqdWZ4= Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: References: <20250827-vchiq-destage-v1-0-5052a0d81c42@ideasonboard.com> <20250827-vchiq-destage-v1-1-5052a0d81c42@ideasonboard.com> <20250827124016.GF5650@pendragon.ideasonboard.com> <8ed6519a-6e45-4793-b11b-7b63c1703d6e@gmx.net> <910dae68-0545-46fa-b41f-8e4fb32ed649@broadcom.com> Subject: Re: [PATCH 1/5] include: linux: Destage VCHIQ interface headers From: Jai Luthra Cc: Broadcom internal kernel review list , Greg Kroah-Hartman , Ray Jui , Scott Branden , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, kernel-list@raspberrypi.com To: Florian Fainelli , Laurent Pinchart , Stefan Wahren , Umang Jain , Dave Stevenson Date: Wed, 03 Sep 2025 19:18:06 +0530 Message-ID: <175690728665.8095.6551736878574350999@freya> User-Agent: alot/0.12.dev28+gd2c823fe Hi Florian, Stefan, Quoting Stefan Wahren (2025-08-28 11:49:47) > Hi Florian, >=20 > Am 28.08.25 um 04:17 schrieb Florian Fainelli: > > > > > > On 8/27/2025 12:05 PM, Stefan Wahren wrote: > >> Hi, > >> > >> Am 27.08.25 um 16:33 schrieb Umang Jain: > >>> On Wed, Aug 27, 2025 at 02:40:16PM +0200, Laurent Pinchart wrote: > >>>> Hi Jai, > >>>> > >>>> Thank you for the patch. > >>>> > >>>> On Wed, Aug 27, 2025 at 11:54:08AM +0530, Jai Luthra wrote: > >>>>> From: Umang Jain > >>>>> > >>>>> Move the VCHIQ headers from drivers/staging/vc04_services/include to > >>>>> include/linux/vchiq > >>>>> > >>>>> This is done so that they can be shared between the VCHIQ interface > >>>>> (which is going to be de-staged in a subsequent commit from staging) > >>>>> and the VCHIQ drivers left in the staging/vc04_services (namely > >>>>> bcm2835-audio, bcm2835-camera). > >>>>> > >>>>> The include/linux/vchiq/ provides a central location to serve both > >>>>> of these areas. > >>>> Lots of SoC-specific headers are stored in include/linux/soc/$vendor= /. > >>>> This would be include/linux/soc/bcm/vchiq/ in this case. I'm also fi= ne > >>>> with include/linux/vchiq/ but other people may have a preference. > >>> I agree with this point and I might have missed to notice the > >>> include/linux/soc earlier. That's seems a better location to me since > >>> it's actually broadcom-specific. > >> I would expect that headers and source would be more related. > >> > >> For example: > >> > >> include/linux/soc/bcm > >> > >> drivers/soc/bcm/ > > > > This is not Broadcom code, it is Raspberry Pi AFAICT, therefore, just=20 > > like drivers/firmware/raspberrypi.c, we would need some namespacing=20 > > here that reflects that, ideally. > The VCHIQ code originally comes from Broadcom, but the current=20 > implementation has been adapted and tested for Raspberry Pi. I'm not=20 > against a Raspberry Pi specific namespace. Thanks for the suggestions. For v2 I'll use: include/linux/soc/raspberrypi drivers/soc/raspberrypi >=20 > Should this also apply to the DT bindings? >=20 > Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml >=20 > Best regards >=20 Thanks, Jai