From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E12BB2C82 for ; Thu, 28 Oct 2021 14:31:58 +0000 (UTC) Received: by mail-wr1-f45.google.com with SMTP id p14so10527103wrd.10 for ; Thu, 28 Oct 2021 07:31:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=G1URQ8lQTbKqKyy5iIiPH2GPZERZgQDiwncSKKtO3yA=; b=fBHmbjTKwbBV7gQItocG0wuyAy3bf5EBgQUyDfKMLm92xGS1KdK3ElxDwMrekIV/4E 18hPsWS+TZLWBXgxqV2DRCkEmPmmrhlQr7l17pJNdFgJnGJq7DCwbJ4wWX7+pbdvEryR flIqtVwIMaUVc+HS+/siJkB7FS+4KrSgg18nvaVRFGw6phKW/ekqUUgDLQzJDvIubANZ gPqWACUta8NJLoG+p33Dzh7cgf70VksltNhfBZDIPlKyt1ZG00r4MukiwYgHHo7YHMiy YYp6EB0Q2GgmK7WVo3cxKv6F2V/PUcJ67OYqlVYWgUK5xbHlm4fGxO7HWHSpq5COJAzV Q/1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=G1URQ8lQTbKqKyy5iIiPH2GPZERZgQDiwncSKKtO3yA=; b=WTMWnpKYvuXUR/dsZJKva2TShzDW0O7todPdS4dlAr6RO97qZgbbDBT3c/jY8s/Ec5 kvIuT8Q1ahdhWsZwaym52p66KggJQWLP1Pp8tRsVE4pEjtfeJcGPzSDsjCR4kuw1f6mF 2Flanr0tX8Jubea1TlL4yxSeaszRcyvSz/5gcg1uXycj787qjrL/36eAE3SHdnsyX6Qm D40k+9QfnOVFUbY5WG6VIsXECNxnFpgVANWBDraMPYxUfAlo/K4CJN5yW3kBiZolXVk8 vcKrpDEUpD8KorQYEqE4u6yDOR82kDF5kjuYRewfacTZRLCsnDa3N/Kh5YrmHJGFwi0/ 950w== X-Gm-Message-State: AOAM532/0Lte+GRYikJHS6IH8qMr9L0mm76N6LcbReavTNTFr66RvBC/ 1i7D2TeuZy0B3PqjTPUXcaE= X-Google-Smtp-Source: ABdhPJxHXS8cxJcuL94+fXL/rbO0pFVs3/yhI0DSigN5Eupyioy+0wUxoViDjj0DOECe+w3Vvem8SQ== X-Received: by 2002:a05:6000:18c7:: with SMTP id w7mr6074015wrq.411.1635431517243; Thu, 28 Oct 2021 07:31:57 -0700 (PDT) Received: from ?IPv6:2a01:4b00:f411:e700:e085:8cb7:7bf6:5d62? ([2a01:4b00:f411:e700:e085:8cb7:7bf6:5d62]) by smtp.gmail.com with ESMTPSA id c16sm3211643wrm.46.2021.10.28.07.31.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Oct 2021 07:31:56 -0700 (PDT) Message-ID: <186358f460f2093dc8a60a8120be3dc6f830c81f.camel@gmail.com> Subject: Re: [Outreachy kernel] [PATCH 4/7] staging: vt6655: Introduce `data` temporary variable From: Karolina Drobnik To: "Fabio M. De Francesco" , Julia Lawall Cc: outreachy-kernel@googlegroups.com, gregkh@linuxfoundation.org, forest@alittletooquiet.net, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Date: Thu, 28 Oct 2021 15:31:55 +0100 In-Reply-To: <39890856.3BBMun7449@localhost.localdomain> References: <2039159.k92FijXA2m@localhost.localdomain> <39890856.3BBMun7449@localhost.localdomain> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.3-1 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi Fabio and Julia, Thank you very much for looking at my changes. On Thu, 2021-10-28 at 13:21 +0200, Fabio M. De Francesco wrote: > Hi Karolina, > > I think you are using redundant parentheses in "* (data ++)" but > understand that those increments and dereferences are equivalent to  > "* data ++" (according to the C precedence rules). Yes, I added them on purpose to improve readability (+ that's also my preference anyway) > While we are at it, please notice that Maintainers of different > subsystems may see this topic from a different point of view and that > they might very well ask you for removing those redundant > parentheses. I understand, thanks for letting me know. On Thu, 2021-10-28 at 13:32 +0200, Julia Lawall wrote: > Would it be better as data[i] ? > > Could there be a better name than "data"? Perhaps "table"? Hmm, now when I'm thinking about, it indeed looks like a better option. I would even say that `data` (or `table`/`init_table`) can be only used in the AL7320 case and we can go with `al2230_init_table` for AL2230. The line would be 61 characters long, way below the limit. What do you think? Many thanks, Karolina