From: Menna Mahmoud <eng.mennamahmoud.mm@gmail.com>
To: Julia Lawall <julia.lawall@inria.fr>
Cc: gregkh@linuxfoundation.org, outreachy@lists.linux.dev,
johan@kernel.org, elder@kernel.org, vireshk@kernel.org,
thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de,
greybus-dev@lists.linaro.org, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev, linux-pwm@vger.kernel.org
Subject: Re: [PATCH 0/3] edits in greybus driver
Date: Tue, 21 Mar 2023 18:22:44 +0200 [thread overview]
Message-ID: <196b5d53-701f-e2dd-596c-9fdb6a59f5cd@gmail.com> (raw)
In-Reply-To: <ee77a227-13bd-70ad-1d8e-f9719970e0f8@inria.fr>
On ٢١/٣/٢٠٢٣ ١٣:٤٦, Julia Lawall wrote:
>
> On Tue, 21 Mar 2023, Menna Mahmoud wrote:
>
>> This patchset includes change happened in greybus driver in three
>> different files two of them patch one and three related to
>> checkpatch issue and in second patch convert two
>> `container_of` macros into inline functions.
>>
>> Menna Mahmoud (3):
>> staging: greybus: remove unnecessary blank line
>> staging: greybus: use inline function for macros
>> staging: greybus: remove unnecessary blank line
> Different patches should have different subject lines.
But I have already the same edit in both file, so should I re-write the
subject for one of them?
> You need to either
> be more specific about the file affected or merge the two patches with the
> same subject into one.
each patch related to different file. So, Can I to merge two commits for
different files but have the same edit in one patch?
but in this case no need to create patchset for all changes in `greybus`
driver, right?
If okay with that, should I versioning the patches to resend them again,
or should add "RESEND" subject prefix?
please tell me the best way to resend these patches, appreciate your help.
Menna
>
> julia
>
>> drivers/staging/greybus/gbphy.h | 10 ++++++++--
>> drivers/staging/greybus/greybus_authentication.h | 1 -
>> drivers/staging/greybus/pwm.c | 1 -
>> 3 files changed, 8 insertions(+), 4 deletions(-)
>>
>> --
>> 2.34.1
>>
>>
>>
next prev parent reply other threads:[~2023-03-21 16:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 23:04 [PATCH 0/3] edits in greybus driver Menna Mahmoud
2023-03-20 23:04 ` [PATCH 1/3] staging: greybus: remove unnecessary blank line Menna Mahmoud
2023-03-20 23:04 ` [PATCH 2/3] staging: greybus: use inline function for macros Menna Mahmoud
2023-03-21 15:47 ` Uwe Kleine-König
2023-03-21 15:59 ` Julia Lawall
2023-03-21 16:26 ` Uwe Kleine-König
2023-03-21 16:35 ` Julia Lawall
2023-03-21 17:01 ` Greg KH
2023-03-21 16:25 ` Menna Mahmoud
2023-03-21 16:42 ` Uwe Kleine-König
2023-03-21 17:21 ` Menna Mahmoud
2023-03-20 23:04 ` [PATCH 3/3] staging: greybus: remove unnecessary blank line Menna Mahmoud
2023-03-21 11:46 ` [PATCH 0/3] edits in greybus driver Julia Lawall
2023-03-21 16:22 ` Menna Mahmoud [this message]
2023-03-21 16:26 ` Greg KH
2023-03-21 17:24 ` Menna Mahmoud
2023-03-21 16:39 ` Julia Lawall
2023-03-21 17:26 ` Menna Mahmoud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=196b5d53-701f-e2dd-596c-9fdb6a59f5cd@gmail.com \
--to=eng.mennamahmoud.mm@gmail.com \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=julia.lawall@inria.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox