From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay5.hostedemail.com (relay5.hostedemail.com [64.99.140.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AEAB7614F for ; Sat, 12 Mar 2022 22:06:34 +0000 (UTC) Received: from omf14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 1D73920F38; Sat, 12 Mar 2022 21:27:45 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf14.hostedemail.com (Postfix) with ESMTPA id 2A62433; Sat, 12 Mar 2022 21:27:38 +0000 (UTC) Message-ID: <19a139d0dde6fadfce79c10d40c9810b50702fb1.camel@perches.com> Subject: Re: [PATCH] staging: android: ashmem: Declared file operation with const keyword Warning found by checkpatch.pl script. From: Joe Perches To: shaikh kamal Cc: Greg Kroah-Hartman , Arve =?ISO-8859-1?Q?Hj=F8nnev=E5g?= , Todd Kjos , Martijn Coenen , Joel Fernandes , Christian Brauner , Hridya Valsaraju , Suren Baghdasaryan , linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Date: Sat, 12 Mar 2022 13:27:37 -0800 In-Reply-To: <20220312204128.3942-1-shaikhkamal2012@gmail.com> References: <20220312204128.3942-1-shaikhkamal2012@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.40.4-1ubuntu2 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.35 X-Stat-Signature: rtm1zbfs7dogbjaq5k5daswbtt1e356n X-Rspamd-Server: rspamout03 X-Rspamd-Queue-Id: 2A62433 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX1+se1DJYpmi2MVwrgiCDdqWbmGhMkicYQY= X-HE-Tag: 1647120458-668950 On Sun, 2022-03-13 at 03:11 +0530, shaikh kamal wrote: [] > diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c [] > @@ -377,7 +377,7 @@ ashmem_vmfile_get_unmapped_area(struct file *file, unsigned long addr, > > static int ashmem_mmap(struct file *file, struct vm_area_struct *vma) > { > - static struct file_operations vmfile_fops; > + static const struct file_operations vmfile_fops; Make sure to compile any files modified by your suggested patches _before_ sending the patches.