From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D6DE272 for ; Mon, 10 May 2021 12:26:09 +0000 (UTC) Received: by mail-lj1-f170.google.com with SMTP id c15so6037760ljr.7 for ; Mon, 10 May 2021 05:26:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=j28BzUpIKRTnonhZ9O0uQVwNvZfw8g36Oo4gUhmWtik=; b=Zz27Lf7qIqSjK4ZI+aR0IJ9nK2qZt6aL28GU/G+gfVFpoBv9sGtC9dC5lIVFHww/7P bEZHj8sdPCNYc3E/EDqc332H8beriFcV4vsp1/b3RP+rz4JkbVhSVvx5aFb/8drBIRZ9 5e+JjBOs3rA46Vb88syHDSQCTcC4CdJt0ebl0uakRPiSK+DvM7XK+/wB8/34bVzsSgto nvzmXfLmyh375Nzq8AOt4U1tT14qTVi0wZp+3hgBGgAjXaT6N9M1ezsNVqcohVjT+ov0 LqzH48ceGN916e09G5/qt9NTxLTEE2kqmZ/X5VUypo76tqcFmGs0nhVSoRaoAnKx4NG8 qwTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=j28BzUpIKRTnonhZ9O0uQVwNvZfw8g36Oo4gUhmWtik=; b=B4V9qo58qY2j+1A90vfEcXadRHb7AkmcLVPkwN7ZZIwxFUCGit58aWVRR/rApiLSwy N83hE5mdmSGmOLD72nk85jhFJFAqkXag8L2IdLKm0/3vsbF6fD+EQLyb5k6b2Tvy6c56 cJldBFEI2BHJQQcAlGwzFwTVO20Sd/B1kmMWvSSBjEazj+vSNH9xqZdZGKb/Mo6XL3GS kzdGm8+Jfj4ffJlovDLSJDqWUEAWGAVH7en7KnRea7veVd5Ed2ZLuWT5c+4DnKt7xxRx v2Bjv1vTGQdlfRlUOUtVlRFd8RkkH4A0lLbDGZ/qDfJUQDDLFPOZFt5CJUeN8OU/V3rF 14Kg== X-Gm-Message-State: AOAM532m6UXKRm9kO6juWbmGA18jz78OAxecjXHA6+s+9b5jmmxQGaJz VYFvrTwmGJTJ9zZu2DRAYnU= X-Google-Smtp-Source: ABdhPJwlZ+hniuV/V3LLIaCld7lAnnvjREuO4c85FmndhkAxGiaw9UdiF6fYd5Od6Eu7Z0KZ+0v3XQ== X-Received: by 2002:a2e:b4f3:: with SMTP id s19mr19847967ljm.229.1620649568119; Mon, 10 May 2021 05:26:08 -0700 (PDT) Received: from [192.168.2.145] (109-252-193-91.dynamic.spd-mgts.ru. [109.252.193.91]) by smtp.googlemail.com with ESMTPSA id x1sm3127652ljd.61.2021.05.10.05.26.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 May 2021 05:26:07 -0700 (PDT) Subject: Re: [PATCH v5 05/25] staging: media: tegra-vde: use pm_runtime_resume_and_get() To: Dan Carpenter , Mauro Carvalho Chehab Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, Greg Kroah-Hartman , Jonathan Hunter , Mauro Carvalho Chehab , Thierry Reding , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-tegra@vger.kernel.org References: <20210507051333.GE1955@kadam> From: Dmitry Osipenko Message-ID: <19a73d97-3679-0c1d-eefc-a944971effac@gmail.com> Date: Mon, 10 May 2021 15:26:06 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20210507051333.GE1955@kadam> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit 07.05.2021 08:13, Dan Carpenter пишет: > On Thu, May 06, 2021 at 05:25:43PM +0200, Mauro Carvalho Chehab wrote: >> @@ -1069,11 +1071,19 @@ static int tegra_vde_probe(struct platform_device *pdev) >> * power-cycle it in order to put hardware into a predictable lower >> * power state. >> */ >> - pm_runtime_get_sync(dev); >> + if (pm_runtime_resume_and_get(dev) < 0) >> + goto err_pm_runtime; > > Needs an error code on this path. These days the kbuild bot will send > a warning for this eventually. Good catch, thank you.