From: Pavel Skripkin <paskripkin@gmail.com>
To: Martin Kaiser <martin@kaiser.cx>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>,
Michael Straube <straube.linux@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/6] staging: r8188eu: cnt is set but not used
Date: Sat, 26 Feb 2022 19:57:57 +0300 [thread overview]
Message-ID: <1c44c931-5b90-03d8-94bd-5e68682c4787@gmail.com> (raw)
In-Reply-To: <20220226144843.1118951-4-martin@kaiser.cx>
Hi Martin,
On 2/26/22 17:48, Martin Kaiser wrote:
> In function recv_func, the cnt variable is set but not used.
> It can be removed.
>
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> ---
> drivers/staging/r8188eu/core/rtw_recv.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/core/rtw_recv.c b/drivers/staging/r8188eu/core/rtw_recv.c
> index 0144c4642911..9a2e2bc2e294 100644
> --- a/drivers/staging/r8188eu/core/rtw_recv.c
> +++ b/drivers/staging/r8188eu/core/rtw_recv.c
> @@ -1798,11 +1798,9 @@ static int recv_func(struct adapter *padapter, struct recv_frame *rframe)
> if (check_fwstate(mlmepriv, WIFI_STATION_STATE) &&
> psecuritypriv->busetkipkey) {
> struct recv_frame *pending_frame;
> - int cnt = 0;
>
> pending_frame = rtw_alloc_recvframe(&padapter->recvpriv.uc_swdec_pending_queue);
> while (pending_frame) {
Just out of curiosity: is this thing infinity loop?
> - cnt++;
> recv_func_posthandle(padapter, pending_frame);
> }
Nit: bracers can be removed
> }
With regards,
Pavel Skripkin
next prev parent reply other threads:[~2022-02-26 16:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-26 14:48 [PATCH 0/6] staging: r8188eu: another round of removals Martin Kaiser
2022-02-26 14:48 ` [PATCH 1/6] staging: r8188eu: smooth_rssi_data is not used Martin Kaiser
2022-02-26 14:48 ` [PATCH 2/6] staging: r8188eu: irq_prepare_beacon_tasklet is unused Martin Kaiser
2022-02-26 14:48 ` [PATCH 3/6] staging: r8188eu: cnt is set but not used Martin Kaiser
2022-02-26 16:57 ` Pavel Skripkin [this message]
2022-02-26 17:32 ` Pavel Skripkin
2022-02-26 18:07 ` Martin Kaiser
2022-02-26 18:09 ` Pavel Skripkin
2022-02-26 17:59 ` Martin Kaiser
2022-02-26 14:48 ` [PATCH 4/6] staging: r8188eu: recvframe_push is " Martin Kaiser
2022-02-26 14:48 ` [PATCH 5/6] staging: r8188eu: get_rx_status " Martin Kaiser
2022-02-26 14:48 ` [PATCH 6/6] staging: r8188eu: remove unused define Martin Kaiser
2022-02-26 18:14 ` [PATCH v2 0/7] staging: r8188eu: some removals, fix an endless loop Martin Kaiser
2022-02-26 18:14 ` [PATCH v2 1/7] staging: r8188eu: smooth_rssi_data is not used Martin Kaiser
2022-02-26 18:14 ` [PATCH v2 2/7] staging: r8188eu: irq_prepare_beacon_tasklet is unused Martin Kaiser
2022-02-26 18:14 ` [PATCH v2 3/7] staging: r8188eu: fix endless loop in recv_func Martin Kaiser
2022-02-26 18:14 ` [PATCH v2 4/7] staging: r8188eu: cnt is set but not used Martin Kaiser
2022-02-26 18:14 ` [PATCH v2 5/7] staging: r8188eu: recvframe_push is " Martin Kaiser
2022-02-26 18:14 ` [PATCH v2 6/7] staging: r8188eu: get_rx_status " Martin Kaiser
2022-02-26 18:14 ` [PATCH v2 7/7] staging: r8188eu: remove unused define Martin Kaiser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c44c931-5b90-03d8-94bd-5e68682c4787@gmail.com \
--to=paskripkin@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=martin@kaiser.cx \
--cc=phil@philpotter.co.uk \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox