From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 337711FC5; Sun, 12 Mar 2023 13:40:00 +0000 (UTC) Received: by mail-wm1-f53.google.com with SMTP id r19-20020a05600c459300b003eb3e2a5e7bso6272288wmo.0; Sun, 12 Mar 2023 06:40:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678628398; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=pW3SYoJSfYigvun40dUyfsdJwqphbL/38YBc34ttyCo=; b=YhkYASX7a74CAsFNiKpJWvIMR1ENdKDvxrtH595UKIWI4fV6J2X0y6ji3Ri0tSopvV NrijF/N2W9Sh7pculPdZ1KQrU7uButTTnkkA2tJ987jNOprgTgbDRcaTDr4xZSBAiOya pTdLvhARtdlxSVlBLoBKx/dyaF0/hhcn6BTqs4Rc6AMXywuNhT+yJGirNaFYEEq9hpkv qZpYG43aCAsoSqpEBHnuewH0jWWYhVgnGGTOtV5puQZvS/gbqC/pedktrqrWhwucbrlf fcQCH0lumhZ7306XmrubeVdBmVsL+89qWNxXR3lrxE3dQfLxx5UqfjtLRxIV79+rw0Cc vGEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678628398; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pW3SYoJSfYigvun40dUyfsdJwqphbL/38YBc34ttyCo=; b=ySuoqTzjCMSJZq8RdCQQ62oAHku2lXPYZ/LRbvVxITgx2LlgMVj/LV2ieqyFwmNHjR 1lzRIlighDLOyxdUIggKOMG0NWoE2KCRfB5b0L4HRgPgjEhaSJP9zHk1pf6BxJ6ZpH7n 1z9AhziveBLZ6FOz/GhrfCX5vbjDBZlLllx9dELKMonf++ym13yPA2DXSQkE5eg42fZk NqH+ze5OvMbc40X04crXneNNvdzAeCrF+OEQgX1+FlEnXEpCjVqyV92yzQm7M9mZJcpm Wq1CCoEC5x5b8HB6/6S2SjZUaYsYFQNvBiKcwnXyQ3b6rmrtHGLZ5gECrdqlNDnfiUyv DfUw== X-Gm-Message-State: AO0yUKUP9U0ngy65vz4AqmQ9d1cA3LL5lc0X+oAHSvxKQvdhRyzLWZmY uzzZ41aBCJjGPXMzYYF6NE8= X-Google-Smtp-Source: AK7set/Puwux94bwB+pHKftXFM9AZEJDRXkcO3uxKEjnksL/INtvCvoixKCiQSDWOhfcojHCeYlMTQ== X-Received: by 2002:a05:600c:1c95:b0:3eb:2b69:c3c6 with SMTP id k21-20020a05600c1c9500b003eb2b69c3c6mr8000944wms.1.1678628398284; Sun, 12 Mar 2023 06:39:58 -0700 (PDT) Received: from [192.168.1.16] ([41.42.177.251]) by smtp.gmail.com with ESMTPSA id n11-20020a05600c294b00b003e21638c0edsm5957737wmd.45.2023.03.12.06.39.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Mar 2023 06:39:57 -0700 (PDT) Message-ID: <1e8d503d-decb-e662-3457-19d41c6769e0@gmail.com> Date: Sun, 12 Mar 2023 15:39:55 +0200 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] staging: greybus: eclose macro in a do - while loop To: Julia Lawall Cc: Dan Carpenter , outreachy@lists.linux.dev, pure.logic@nexus-software.ie, johan@kernel.org, elder@kernel.org, gregkh@linuxfoundation.org, greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org References: <20230311135919.9129-1-eng.mennamahmoud.mm@gmail.com> <10d2c15b-ff9f-4634-a013-7640c93435a7@kili.mountain> Content-Language: en-US From: Menna Mahmoud In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On ١١‏/٣‏/٢٠٢٣ ١٧:٠٠, Julia Lawall wrote: > > On Sat, 11 Mar 2023, Menna Mahmoud wrote: > >> On ١١/٣/٢٠٢٣ ١٦:٠٦, Dan Carpenter wrote: >>> On Sat, Mar 11, 2023 at 03:59:19PM +0200, Menna Mahmoud wrote: >>>> " ERROR: Macros with multiple statements should be enclosed in a do - >>>> while loop" >>>> >>>> Reported by checkpath. >>>> >>>> do loop with the conditional expression set to a constant >>>> value of zero (0).This creates a loop that >>>> will execute exactly one time.This is a coding idiom that >>>> allows a multi-line macro to be used anywhere >>>> that a single statement can be used. >>>> >>>> So, enclose `gb_loopback_stats_attrs` macro in do - while (0) to >>>> fix checkpath error >>>> >>>> Signed-off-by: Menna Mahmoud >>>> --- >>> This breaks the build. You need to compile the code before sending a >>> patch. >>> >>> regards, >>> dan carpenter >> >> I see, I thought building the file only enough. appreciate your feedback. > The outreachy tutorial explains how to compile everything in a > subdirectory. > > julia Thanks Julia, I will check it. Menna