From: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To: Karolina Drobnik <karolinadrobnik@gmail.com>,
Greg KH <gregkh@linuxfoundation.org>,
outreachy-kernel@googlegroups.com
Cc: outreachy-kernel@googlegroups.com, forest@alittletooquiet.net,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Joe Perches <joe@perches.com>
Subject: Re: [Outreachy kernel] Re: [PATCH] staging: vt6655: Fix line wrapping in rf.c file
Date: Tue, 19 Oct 2021 15:12:47 +0200 [thread overview]
Message-ID: <2001042.7W5oOxFLzk@localhost.localdomain> (raw)
In-Reply-To: <4c6a85a4934ef977eee07fb7e38b07b8061bfce4.camel@perches.com>
On Tuesday, October 19, 2021 2:26:05 PM CEST Joe Perches wrote:
> On Tue, 2021-10-19 at 11:59 +0100, Karolina Drobnik wrote:
> > Hi,
> >
> > Thank you very much for your comments.
> >
> > On Mon, 2021-10-18 at 17:12 +0200, Greg KH wrote:
> > > Also, these are all just fine as-is for now. A better way to make
> > > these lines smaller is to use better variable and function names
> > > that are shorter and make sense :)
> >
> > I have v2 ready but I'm not sure, given the Joe's patch, if my solution
> > is a satisfactory one. I didn't jump on such refactoring as I'm still
> > learning about the codebase/process and didn't want to muddle the
> > waters (...more than I do already).
> >
> > Greg, what would you prefer? Should I back up with my patch, pick
> > something else and let Joe's patch be merged?
>
> What I suggested is not a patch it's just an example.
Sorry, Joe. I sent a message trying to explain what you were showing to
Karolina with your previous email. Soon after sending my reply, I noticed
that you had already elaborated a bit more.
I hope that you don't mind. If I wrote something that contradicts your
thoughts and intentions please accept my apologies.
Regards,
Fabio
next prev parent reply other threads:[~2021-10-19 13:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 15:05 [PATCH] staging: vt6655: Fix line wrapping in rf.c file Karolina Drobnik
2021-10-18 15:10 ` [Outreachy kernel] " Julia Lawall
2021-10-18 15:12 ` Greg KH
2021-10-19 5:56 ` Joe Perches
2021-10-19 10:59 ` Karolina Drobnik
2021-10-19 11:12 ` Greg KH
2021-10-19 12:26 ` Joe Perches
2021-10-19 13:12 ` Fabio M. De Francesco [this message]
2021-10-19 13:07 ` [Outreachy kernel] " Fabio M. De Francesco
2021-10-19 15:08 ` Karolina Drobnik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2001042.7W5oOxFLzk@localhost.localdomain \
--to=fmdefrancesco@gmail.com \
--cc=forest@alittletooquiet.net \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=karolinadrobnik@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox