From: Dan Carpenter <dan.carpenter@oracle.com>
To: Marco Cesati <marcocesati@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Hans de Goede <hdegoede@redhat.com>,
Larry Finger <Larry.Finger@lwfinger.net>,
linux-staging@lists.linux.dev
Subject: Re: [PATCH 01/33] Staging: rtl8723bs: remove named enums in rtw_mlme.h
Date: Wed, 24 Mar 2021 16:42:45 +0300 [thread overview]
Message-ID: <20210324134245.GN1717@kadam> (raw)
In-Reply-To: <20210324124456.25221-2-marcocesati@gmail.com>
On Wed, Mar 24, 2021 at 01:44:24PM +0100, Marco Cesati wrote:
> Remove the following unnecessary enum names or definitions in
> include/rtw_mlme.h:
>
> enum dot11AuthAlgrthmNum [name]
> enum _band [name]
Sorry, I was unclear. I liked the names fine, it just that _band was a
bad name. It's too vague and what's with the underscore character?
> enum DriverInterface [definition]
> enum scan_result_type [definition]
These are good to delete. And it wouldn't surprise me if you found a
bunch of these enums were duplicates of more standard global enums.
regards,
dan carpenter
next prev parent reply other threads:[~2021-03-24 13:42 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 12:44 [PATCH 00/33] Staging: rtl8723bs: remove unnecessary enum names and definitions Marco Cesati
2021-03-24 12:44 ` [PATCH 01/33] Staging: rtl8723bs: remove named enums in rtw_mlme.h Marco Cesati
2021-03-24 13:42 ` Dan Carpenter [this message]
2021-03-24 15:01 ` Marco Cesati
2021-03-24 12:44 ` [PATCH 02/33] Staging: rtl8723bs: remove named enums in rtw_cmd.h Marco Cesati
2021-03-24 12:44 ` [PATCH 03/33] Staging: rtl8723bs: remove named enums in rtw_eeprom.h Marco Cesati
2021-03-24 12:44 ` [PATCH 04/33] Staging: rtl8723bs: remove named enums in hal_com.h Marco Cesati
2021-03-24 12:44 ` [PATCH 05/33] Staging: rtl8723bs: remove named enums in rtw_recv.h Marco Cesati
2021-03-24 12:44 ` [PATCH 06/33] Staging: rtl8723bs: remove named enums in drv_types.h Marco Cesati
2021-03-24 12:44 ` [PATCH 07/33] Staging: rtl8723bs: remove named enums in rtw_ht.h Marco Cesati
2021-03-24 12:44 ` [PATCH 08/33] Staging: rtl8723bs: remove named enums in wlan_bssdef.h Marco Cesati
2021-03-24 12:44 ` [PATCH 09/33] Staging: rtl8723bs: remove named enums in rtw_mp.h Marco Cesati
2021-03-24 12:44 ` [PATCH 10/33] Staging: rtl8723bs: remove named enums in osdep_service.h Marco Cesati
2021-03-24 12:44 ` [PATCH 11/33] Staging: rtl8723bs: remove named enums in hal_intf.h Marco Cesati
2021-03-24 12:44 ` [PATCH 12/33] Staging: rtl8723bs: remove named enums in rtw_pwrctrl.h Marco Cesati
2021-03-24 12:44 ` [PATCH 13/33] Staging: rtl8723bs: remove named enums in rtl8723b_cmd.h Marco Cesati
2021-03-24 12:44 ` [PATCH 14/33] Staging: rtl8723bs: remove named enums in hal_com_h2c.h Marco Cesati
2021-03-24 12:44 ` [PATCH 15/33] Staging: rtl8723bs: remove named enums in rtw_wifi_regd.h Marco Cesati
2021-03-24 12:44 ` [PATCH 16/33] Staging: rtl8723bs: remove named enums in wifi.h Marco Cesati
2021-03-24 12:44 ` [PATCH 17/33] Staging: rtl8723bs: remove named enums in rtl8723b_hal.h Marco Cesati
2021-03-24 12:44 ` [PATCH 18/33] Staging: rtl8723bs: remove named enums in hal_phy.h Marco Cesati
2021-03-24 12:44 ` [PATCH 19/33] Staging: rtl8723bs: remove named enums in rtw_mlme_ext.h Marco Cesati
2021-03-24 12:44 ` [PATCH 20/33] Staging: rtl8723bs: remove named enums in rtw_xmit.h Marco Cesati
2021-03-24 12:44 ` [PATCH 21/33] Staging: rtl8723bs: remove named enums in rtw_rf.h Marco Cesati
2021-03-24 12:44 ` [PATCH 22/33] Staging: rtl8723bs: remove named enums in HalPwrSeqCmd.h Marco Cesati
2021-03-24 12:44 ` [PATCH 23/33] Staging: rtl8723bs: remove named enums in hal_com_phycfg.h Marco Cesati
2021-03-24 12:44 ` [PATCH 24/33] Staging: rtl8723bs: remove named enums in ieee80211.h Marco Cesati
2021-03-24 12:44 ` [PATCH 25/33] Staging: rtl8723bs: remove named enums in rtw_efuse.h Marco Cesati
2021-03-24 12:44 ` [PATCH 26/33] Staging: rtl8723bs: remove named enums in odm_interface.h Marco Cesati
2021-03-24 12:44 ` [PATCH 27/33] Staging: rtl8723bs: remove named enums in HalBtcOutSrc.h Marco Cesati
2021-03-24 12:44 ` [PATCH 28/33] Staging: rtl8723bs: remove named enums in HalBtc8723b1Ant.h Marco Cesati
2021-03-24 12:44 ` [PATCH 29/33] Staging: rtl8723bs: remove named enums in odm_types.h Marco Cesati
2021-03-24 12:44 ` [PATCH 30/33] Staging: rtl8723bs: remove named enums in odm_DIG.h Marco Cesati
2021-03-24 12:44 ` [PATCH 31/33] Staging: rtl8723bs: remove named enums in HalPhyRf.h Marco Cesati
2021-03-24 12:44 ` [PATCH 32/33] Staging: rtl8723bs: remove named enums in odm.h Marco Cesati
2021-03-24 12:44 ` [PATCH 33/33] Staging: rtl8723bs: remove named enums in HalBtc8723b2Ant.h Marco Cesati
2021-03-26 14:04 ` [PATCH 00/33] Staging: rtl8723bs: remove unnecessary enum names and definitions Greg Kroah-Hartman
2021-03-26 15:37 ` Marco Cesati
2021-03-26 16:09 ` Dan Carpenter
2021-03-26 16:19 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210324134245.GN1717@kadam \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=linux-staging@lists.linux.dev \
--cc=marcocesati@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox