From: Dan Carpenter <dan.carpenter@oracle.com>
To: Marco Cesati <marcocesati@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Hans de Goede <hdegoede@redhat.com>,
Larry Finger <Larry.Finger@lwfinger.net>,
linux-staging@lists.linux.dev
Subject: Re: [PATCH 06/21] Staging: rtl8723bs: remove enums in osdep_service.h
Date: Wed, 24 Mar 2021 21:59:19 +0300 [thread overview]
Message-ID: <20210324185919.GO1717@kadam> (raw)
In-Reply-To: <20210324183847.5595-7-marcocesati@gmail.com>
On Wed, Mar 24, 2021 at 07:38:32PM +0100, Marco Cesati wrote:
> Remove the following unnecessary enum definitions in
> include/osdep_service.h:
>
> enum mstat_f
> enum mstat_status
>
> Signed-off-by: Marco Cesati <marcocesati@gmail.com>
> ---
> .../staging/rtl8723bs/include/osdep_service.h | 23 -------------------
> 1 file changed, 23 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/include/osdep_service.h b/drivers/staging/rtl8723bs/include/osdep_service.h
> index c4d29d65187f..9405bdb2abf0 100644
> --- a/drivers/staging/rtl8723bs/include/osdep_service.h
> +++ b/drivers/staging/rtl8723bs/include/osdep_service.h
> @@ -59,33 +59,10 @@
> extern int RTW_STATUS_CODE(int error_code);
>
> /* flags used for rtw_mstat_update() */
This comment doesn't make sense any more. Also we can delete
rtw_mstat_update(). Feel free to delete this in a follow on patch
instead of resending.
> -enum mstat_f {
> - /* type: 0x00ff */
> - MSTAT_TYPE_VIR = 0x00,
> - MSTAT_TYPE_PHY = 0x01,
regards,
dan carpenter
next prev parent reply other threads:[~2021-03-24 18:59 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 18:38 [PATCH 00/21] Staging: rtl8723bs: remove unreferenced enum definitions Marco Cesati
2021-03-24 18:38 ` [PATCH 01/21] Staging: rtl8723bs: remove enums in rtw_mlme.h Marco Cesati
2021-03-24 18:38 ` [PATCH 02/21] Staging: rtl8723bs: remove enums in hal_com.h Marco Cesati
2021-03-24 18:38 ` [PATCH 03/21] Staging: rtl8723bs: remove enums in drv_types.h Marco Cesati
2021-03-24 18:38 ` [PATCH 04/21] Staging: rtl8723bs: remove enums in wlan_bssdef.h Marco Cesati
2021-03-24 18:38 ` [PATCH 05/21] Staging: rtl8723bs: remove enums in rtw_mp.h Marco Cesati
2021-03-24 18:38 ` [PATCH 06/21] Staging: rtl8723bs: remove enums in osdep_service.h Marco Cesati
2021-03-24 18:59 ` Dan Carpenter [this message]
2021-03-24 18:38 ` [PATCH 07/21] Staging: rtl8723bs: remove enums in hal_intf.h Marco Cesati
2021-03-24 18:38 ` [PATCH 08/21] Staging: rtl8723bs: remove enums in hal_com_h2c.h Marco Cesati
2021-03-24 19:02 ` Dan Carpenter
2021-03-24 18:38 ` [PATCH 09/21] Staging: rtl8723bs: remove enums in rtw_wifi_regd.h Marco Cesati
2021-03-24 18:38 ` [PATCH 10/21] Staging: rtl8723bs: remove enums in wifi.h Marco Cesati
2021-03-24 18:38 ` [PATCH 11/21] Staging: rtl8723bs: remove enums in hal_phy.h Marco Cesati
2021-03-24 18:38 ` [PATCH 12/21] Staging: rtl8723bs: remove enums in rtw_mlme_ext.h Marco Cesati
2021-03-24 18:38 ` [PATCH 13/21] Staging: rtl8723bs: remove enums in rtw_xmit.h Marco Cesati
2021-03-24 18:38 ` [PATCH 14/21] Staging: rtl8723bs: remove enums in rtw_rf.h Marco Cesati
2021-03-24 18:38 ` [PATCH 15/21] Staging: rtl8723bs: remove enums in ieee80211.h Marco Cesati
2021-03-24 18:38 ` [PATCH 16/21] Staging: rtl8723bs: remove enums in odm_interface.h Marco Cesati
2021-03-24 18:38 ` [PATCH 17/21] Staging: rtl8723bs: remove enums in HalBtcOutSrc.h Marco Cesati
2021-03-24 19:05 ` Dan Carpenter
2021-03-24 18:38 ` [PATCH 18/21] Staging: rtl8723bs: remove enums in odm_types.h Marco Cesati
2021-03-24 18:38 ` [PATCH 19/21] Staging: rtl8723bs: remove enums in odm_DIG.h Marco Cesati
2021-03-24 18:38 ` [PATCH 20/21] Staging: rtl8723bs: remove enums in HalPhyRf.h Marco Cesati
2021-03-24 18:38 ` [PATCH 21/21] Staging: rtl8723bs: remove enums in odm.h Marco Cesati
2021-03-24 19:06 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210324185919.GO1717@kadam \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=linux-staging@lists.linux.dev \
--cc=marcocesati@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox