From: Fabio Aiuto <fabioaiuto83@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: linux-staging@lists.linux.dev
Subject: Re: [bug report] staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_INTERRUPT_BASED_TXBCN*
Date: Fri, 26 Mar 2021 09:24:43 +0100 [thread overview]
Message-ID: <20210326082442.GA1452@agape.jhs> (raw)
In-Reply-To: <YFxQSJXXQ4dFPGS4@mwanda>
On Thu, Mar 25, 2021 at 11:56:40AM +0300, Dan Carpenter wrote:
> Hello Fabio Aiuto,
>
> The patch 65f183001f6e: "staging: rtl8723bs: remove unused code
> blocks conditioned by never set CONFIG_INTERRUPT_BASED_TXBCN*" from
> Mar 16, 2021, leads to the following static checker warning:
>
> drivers/staging/rtl8723bs/core/rtw_ap.c:911 start_bss_network()
> warn: inconsistent indenting
>
> drivers/staging/rtl8723bs/core/rtw_ap.c
> 904 rtw_get_capability((struct wlan_bssid_ex *)pnetwork)
> 905 );
> 906
> 907 if (pmlmeext->bstart_bss) {
> 908 update_beacon(padapter, WLAN_EID_TIM, NULL, true);
> 909
> 910 /* issue beacon frame */
>
> The patch accidentally deleted these extra tab for this block.
>
> 911 if (send_beacon(padapter) == _FAIL)
> 912 DBG_871X("issue_beacon, fail!\n");
> 913
> 914 }
> 915
> 916 /* update bc/mc sta_info */
> 917 update_bmc_sta(padapter);
> 918
>
> regards,
> dan carpenter
Thank you Dan,
sent yesterday a fix,
sorry for late,
fabio
next prev parent reply other threads:[~2021-03-26 8:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-25 8:56 [bug report] staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_INTERRUPT_BASED_TXBCN* Dan Carpenter
2021-03-25 9:56 ` [PATCH] staging: rtl8723bs: fix indentation broken by previous patch Fabio Aiuto
2021-03-26 8:24 ` Fabio Aiuto [this message]
2021-03-26 11:03 ` [bug report] staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_INTERRUPT_BASED_TXBCN* Dan Carpenter
2021-03-26 9:17 ` [PATCH] staging: rtl8723bs: fix indentation broken by previous patch Fabio Aiuto
2021-03-26 14:06 ` Greg KH
2021-03-26 15:52 ` [PATCH] Fixes: 65f183001f6e (staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_INTERRUPT_BASED_TXBCN*) Fabio Aiuto
2021-03-26 16:20 ` Greg KH
2021-03-26 17:43 ` Fabio Aiuto
2021-03-26 17:57 ` Fabio Aiuto
2021-03-26 18:06 ` [PATCH] staging: rtl8723bs: fix broken indentation Fabio Aiuto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210326082442.GA1452@agape.jhs \
--to=fabioaiuto83@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox