From: Dan Carpenter <dan.carpenter@oracle.com>
To: Xu Jia <xujia39@huawei.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ross Schmidt <ross.schm.dev@gmail.com>,
Amarjargal Gundjalam <amarjargal16@gmail.com>,
Jason Yan <yanaijie@huawei.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] staging: rtl8723bs: core: Remove unused variable 'res'
Date: Wed, 31 Mar 2021 11:49:59 +0300 [thread overview]
Message-ID: <20210331084959.GH2065@kadam> (raw)
In-Reply-To: <1617178363-34193-1-git-send-email-xujia39@huawei.com>
I've been rejecting these patches until someone updates the callers to
check the return. This patch just silences the warning but the code is
still totally buggy.
regards,
dan carpenter
next prev parent reply other threads:[~2021-03-31 8:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-31 8:12 [PATCH -next] staging: rtl8723bs: core: Remove unused variable 'res' Xu Jia
2021-03-31 8:49 ` Dan Carpenter [this message]
2021-03-31 10:29 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210331084959.GH2065@kadam \
--to=dan.carpenter@oracle.com \
--cc=amarjargal16@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=ross.schm.dev@gmail.com \
--cc=xujia39@huawei.com \
--cc=yanaijie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox