From: Fabio Aiuto <fabioaiuto83@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: gregkh@linuxfoundation.org, dan.carpenter@oracle.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 00/30] staging: rtl8723bs: remove RT_TRACE logs in core/*
Date: Sat, 3 Apr 2021 19:28:59 +0200 [thread overview]
Message-ID: <20210403172858.GA2397@agape.jhs> (raw)
In-Reply-To: <7120836b08b680d54c15fd89b8630ccc67a53116.camel@perches.com>
On Sat, Apr 03, 2021 at 09:17:37AM -0700, Joe Perches wrote:
> On Sat, 2021-04-03 at 17:21 +0200, Fabio Aiuto wrote:
> > On Sat, Apr 03, 2021 at 08:02:25AM -0700, Joe Perches wrote:
> > > On Sat, 2021-04-03 at 11:13 +0200, Fabio Aiuto wrote:
> > > > This patchset removes all RT_TRACE usages in core/ files.
> > >
> > > and hal and include and os_dep
> >
> > Hi,
> >
> > I was just about to send the second patchset relative to hal/ files.
> > The whole has been split up in directories in order to reduce the
> > number of patch per patchset
>
> > It's a good idea, but the patches relative to RT_TRACE removal
> > could be huge
>
> That's really not a significant issue.
> Simplicity in review is also important.
> Mechanization of patch creation can reduce review efforts.
Maybe I wrongly associated simplicity with patch dimensions, but maybe
for patches this simple have expert reviewers some tool for
automatic review?
Is automatic review possible?
>
> Few people are actively working on this particular codebase.
> As far as I can tell no logical defect is being corrected here.
> None of this is likely to be backported.
>
> Applying each individual patch has a 'cost' in maintainer time
> and review effort.
got it
>
> Fewer patches create lower overall costs.
>
> Good luck...
>
I like your idea, and sure I will work in that direction,
for this particular case I wait maintainer's opinion. If
patchsets will be rejected again I will apply the scheme you
proposed, if it will be accepted I will apply the scheme for next
patchsets.
Thank you,
fabio
next prev parent reply other threads:[~2021-04-03 17:29 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-03 9:13 [PATCH v3 00/30] staging: rtl8723bs: remove RT_TRACE logs in core/* Fabio Aiuto
2021-04-03 9:13 ` [PATCH v3 01/30] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_xmit.c Fabio Aiuto
2021-04-03 9:13 ` [PATCH v3 02/30] staging: rtl8723bs: fix condition in if statement " Fabio Aiuto
2021-04-03 9:13 ` [PATCH v3 03/30] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_security.c Fabio Aiuto
2021-04-03 9:13 ` [PATCH v3 04/30] staging: rtl8723bs: fix line exceed warning " Fabio Aiuto
2021-04-03 9:13 ` [PATCH v3 05/30] staging: rtl8723bs: fix spaces around operator issues " Fabio Aiuto
2021-04-03 9:13 ` [PATCH v3 06/30] staging: rtl8723bs: remove all RT_TRACE logs in core/rtw_eeprom.c Fabio Aiuto
2021-04-03 9:13 ` [PATCH v3 07/30] staging: rtl8723bs: fix error prone if conditions " Fabio Aiuto
2021-04-03 9:13 ` [PATCH v3 08/30] staging: rtl8723bs: remove all RT_TRACE logs in core/rtw_pwrctrl.c Fabio Aiuto
2021-04-03 9:13 ` [PATCH v3 09/30] staging: rtl8723bs: fix logical continuation issue " Fabio Aiuto
2021-04-03 9:13 ` [PATCH v3 10/30] staging: rtl8723bs: remove unnecessary parentheses in if-condition " Fabio Aiuto
2021-04-03 9:13 ` [PATCH v3 11/30] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_cmd.c Fabio Aiuto
2021-04-03 9:13 ` [PATCH v3 12/30] staging: rtl8723bs: fix null check conditions " Fabio Aiuto
2021-04-03 9:13 ` [PATCH v3 13/30] staging: rtl8723bs: remove unnecessary parentheses in if condition " Fabio Aiuto
2021-04-03 9:13 ` [PATCH v3 14/30] staging: rtl8723bs: remove commented RT_TRACE calls in core/rtw_mlme.c Fabio Aiuto
2021-04-03 9:13 ` [PATCH v3 15/30] staging: rtl8723bs: remove RT_TRACE logs " Fabio Aiuto
2021-04-03 9:13 ` [PATCH v3 16/30] staging: rtl8723bs: tidy up some error handling " Fabio Aiuto
2021-04-03 9:42 ` Fabio Aiuto
2021-04-03 9:50 ` Fabio Aiuto
2021-04-03 10:04 ` Dan Carpenter
2021-04-03 9:13 ` [PATCH v3 17/30] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_mlme_ext.c Fabio Aiuto
2021-04-03 9:13 ` [PATCH v3 18/30] staging: rtl8723bs: remove commented RT_TRACE calls in core/rtw_recv.c Fabio Aiuto
2021-04-03 9:13 ` [PATCH v3 19/30] staging: rtl8723bs: remove RT_TRACE logs " Fabio Aiuto
2021-04-03 9:13 ` [PATCH v3 20/30] staging: rtl8723bs: added spaces around operator " Fabio Aiuto
2021-04-03 9:13 ` [PATCH v3 21/30] staging: rtl8723bs: split long line " Fabio Aiuto
2021-04-03 9:13 ` [PATCH v3 22/30] staging: rtl8723bs: remove unnecessary parentheses " Fabio Aiuto
2021-04-03 9:13 ` [PATCH v3 23/30] staging: rtl8723bs: fix comparison in if condition " Fabio Aiuto
2021-04-03 15:24 ` Joe Perches
2021-04-03 9:13 ` [PATCH v3 24/30] staging: rtl8723bs: remove commented RT_TRACE call in core/rtw_ioctl_set.c Fabio Aiuto
2021-04-03 9:13 ` [PATCH v3 25/30] staging: rtl8723bs: remove RT_TRACE logs " Fabio Aiuto
2021-04-03 9:13 ` [PATCH v3 26/30] staging: rtl8723bs: place constant on the right side of the test " Fabio Aiuto
2021-04-03 9:13 ` [PATCH v3 27/30] staging: rtl8723bs: remove all RT_TRACE logs in core/rtw_wlan_util.c Fabio Aiuto
2021-04-03 9:13 ` [PATCH v3 28/30] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_sta_mgt.c Fabio Aiuto
2021-04-03 9:13 ` [PATCH v3 29/30] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_ieee80211.c Fabio Aiuto
2021-04-03 9:13 ` [PATCH v3 30/30] staging: rtl8723bs: add spaces around operators " Fabio Aiuto
2021-04-03 15:02 ` [PATCH v3 00/30] staging: rtl8723bs: remove RT_TRACE logs in core/* Joe Perches
2021-04-03 15:21 ` Fabio Aiuto
2021-04-03 16:17 ` Joe Perches
2021-04-03 17:28 ` Fabio Aiuto [this message]
2021-04-03 20:02 ` Joe Perches
2021-04-04 6:48 ` Fabio Aiuto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210403172858.GA2397@agape.jhs \
--to=fabioaiuto83@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox