[PATCH] staging: rtl8188eu: core: add comma within a comment

[PATCH] staging: rtl8188eu: core: add comma within a comment

[Deborah Brouwer]

Add a comma to separate repeated words in a comment. The comma preserves
the meaning of the comment while also stopping the checkpatch warning:
WARNING: Possible repeated word: 'very'.

Signed-off-by: Deborah Brouwer <deborahbrouwer3563@gmail.com>
---
 drivers/staging/rtl8188eu/core/rtw_xmit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_xmit.c b/drivers/staging/rtl8188eu/core/rtw_xmit.c
index ed81cbc5e191..99e44b2c6f36 100644
--- a/drivers/staging/rtl8188eu/core/rtw_xmit.c
+++ b/drivers/staging/rtl8188eu/core/rtw_xmit.c
@@ -1243,7 +1243,7 @@ s32 rtw_free_xmitbuf(struct xmit_priv *pxmitpriv, struct xmit_buf *pxmitbuf)
  * If we turn on USE_RXTHREAD, then, no need for critical section.
  * Otherwise, we must use _enter/_exit critical to protect free_xmit_queue...
  *
- * Must be very very cautious...
+ * Must be very, very cautious...
  *
  */
 
-- 
2.17.1

Re: [Outreachy kernel] [PATCH] staging: rtl8188eu: core: add comma within a comment

[Julia Lawall]

On Sat, 3 Apr 2021, Deborah Brouwer wrote:

> Add a comma to separate repeated words in a comment. The comma preserves
> the meaning of the comment while also stopping the checkpatch warning:
> WARNING: Possible repeated word: 'very'.

Thanks.  That is more understandable.  Isn't this a v2?  If so, there
should be v2 after PATCH and an explanation of the change under the ---

julia


>
> Signed-off-by: Deborah Brouwer <deborahbrouwer3563@gmail.com>
> ---
>  drivers/staging/rtl8188eu/core/rtw_xmit.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8188eu/core/rtw_xmit.c b/drivers/staging/rtl8188eu/core/rtw_xmit.c
> index ed81cbc5e191..99e44b2c6f36 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_xmit.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_xmit.c
> @@ -1243,7 +1243,7 @@ s32 rtw_free_xmitbuf(struct xmit_priv *pxmitpriv, struct xmit_buf *pxmitbuf)
>   * If we turn on USE_RXTHREAD, then, no need for critical section.
>   * Otherwise, we must use _enter/_exit critical to protect free_xmit_queue...
>   *
> - * Must be very very cautious...
> + * Must be very, very cautious...
>   *
>   */
>
> --
> 2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20210403210930.17781-1-deborahbrouwer3563%40gmail.com.
>

Re: [Outreachy kernel] [PATCH] staging: rtl8188eu: core: add comma within a comment

[Deborah Brouwer]

On Sat, Apr 03, 2021 at 11:16:16PM +0200, Julia Lawall wrote:
> 
> 
> On Sat, 3 Apr 2021, Deborah Brouwer wrote:
> 
> > Add a comma to separate repeated words in a comment. The comma preserves
> > the meaning of the comment while also stopping the checkpatch warning:
> > WARNING: Possible repeated word: 'very'.
> 
> Thanks.  That is more understandable.  Isn't this a v2?  If so, there
> should be v2 after PATCH and an explanation of the change under the ---
> 
> julia
Hi Julia, no this is not a v2.  I found the same comment, generating the same
error, in a different file.  Since I changed it in
rtl8723bs/core/rtw_xmit.c [1], I thought I should be consistent and change
it here as well.  

[1] https://lore.kernel.org/r/2944d1a0e8769edb489bb336423625a61d314d05.1617229359.git.deborahbrouwer3563@gmail.com

> 
> 
> >
> > Signed-off-by: Deborah Brouwer <deborahbrouwer3563@gmail.com>
> > ---
> >  drivers/staging/rtl8188eu/core/rtw_xmit.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/rtl8188eu/core/rtw_xmit.c b/drivers/staging/rtl8188eu/core/rtw_xmit.c
> > index ed81cbc5e191..99e44b2c6f36 100644
> > --- a/drivers/staging/rtl8188eu/core/rtw_xmit.c
> > +++ b/drivers/staging/rtl8188eu/core/rtw_xmit.c
> > @@ -1243,7 +1243,7 @@ s32 rtw_free_xmitbuf(struct xmit_priv *pxmitpriv, struct xmit_buf *pxmitbuf)
> >   * If we turn on USE_RXTHREAD, then, no need for critical section.
> >   * Otherwise, we must use _enter/_exit critical to protect free_xmit_queue...
> >   *
> > - * Must be very very cautious...
> > + * Must be very, very cautious...
> >   *
> >   */
> >
> > --
> > 2.17.1
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20210403210930.17781-1-deborahbrouwer3563%40gmail.com.
> >

Re: [Outreachy kernel] [PATCH] staging: rtl8188eu: core: add comma within a comment

[Julia Lawall]

On Sat, 3 Apr 2021, Deborah Brouwer wrote:

> On Sat, Apr 03, 2021 at 11:16:16PM +0200, Julia Lawall wrote:
> >
> >
> > On Sat, 3 Apr 2021, Deborah Brouwer wrote:
> >
> > > Add a comma to separate repeated words in a comment. The comma preserves
> > > the meaning of the comment while also stopping the checkpatch warning:
> > > WARNING: Possible repeated word: 'very'.
> >
> > Thanks.  That is more understandable.  Isn't this a v2?  If so, there
> > should be v2 after PATCH and an explanation of the change under the ---
> >
> > julia
> Hi Julia, no this is not a v2.  I found the same comment, generating the same
> error, in a different file.  Since I changed it in
> rtl8723bs/core/rtw_xmit.c [1], I thought I should be consistent and change
> it here as well.

OK, thanks for the explanation :)

julia

>
> [1] https://lore.kernel.org/r/2944d1a0e8769edb489bb336423625a61d314d05.1617229359.git.deborahbrouwer3563@gmail.com
>
> >
> >
> > >
> > > Signed-off-by: Deborah Brouwer <deborahbrouwer3563@gmail.com>
> > > ---
> > >  drivers/staging/rtl8188eu/core/rtw_xmit.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/staging/rtl8188eu/core/rtw_xmit.c b/drivers/staging/rtl8188eu/core/rtw_xmit.c
> > > index ed81cbc5e191..99e44b2c6f36 100644
> > > --- a/drivers/staging/rtl8188eu/core/rtw_xmit.c
> > > +++ b/drivers/staging/rtl8188eu/core/rtw_xmit.c
> > > @@ -1243,7 +1243,7 @@ s32 rtw_free_xmitbuf(struct xmit_priv *pxmitpriv, struct xmit_buf *pxmitbuf)
> > >   * If we turn on USE_RXTHREAD, then, no need for critical section.
> > >   * Otherwise, we must use _enter/_exit critical to protect free_xmit_queue...
> > >   *
> > > - * Must be very very cautious...
> > > + * Must be very, very cautious...
> > >   *
> > >   */
> > >
> > > --
> > > 2.17.1
> > >
> > > --
> > > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20210403210930.17781-1-deborahbrouwer3563%40gmail.com.
> > >
>