From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F3956D0E for ; Wed, 7 Apr 2021 16:09:30 +0000 (UTC) Received: by mail-wm1-f41.google.com with SMTP id d191so9322499wmd.2 for ; Wed, 07 Apr 2021 09:09:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition; bh=JvelsXiWFhKiuGc95HnXl80V7C2PAh9toMttuEic8p4=; b=IrIk1cIvAGMsMIbtfA6TTDf4CDC8HoNmKqtJ2r9DRCj59ZO4+q9oJtLk0SNeP+QqSg PDs6Szt1xf8k/Vy81oW9lcyhG2yJufDjgayLf7YQTQy/PUt8iP6E3xEJ64q/R8K7kqTe huqXuL9FCwm5zisZd2cywcoQ/PX3+L6dS8gKzUBVziWBP47/P6kPOmBytVStyrlWRUjt /vXJg4XJXjaA5RPEcXVYrPZY1QgmIyLuPIykLN7kszLdy3ySpz3AyOlJNXQwvO+k9+Dy RXjkvbuNTsXpoCDfXUoVJcNXV/RrDg+uIxUf7N0tVZ71nrYzovG7wM9DhQD8Dn5GovCj 5nIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition; bh=JvelsXiWFhKiuGc95HnXl80V7C2PAh9toMttuEic8p4=; b=AKTe4vz7BMv7atLgmSN4qmRdIrv93OwnS+vGOB4AZ+cRFOCgrGGD0czIQMFXJkdMtZ HXi40mF8d6Bm2Lx9f+K71NPBQM4z+fd2D4jvRHHKZyCTXdR4w/ZQF+i5poXoSzeuzzYH SBHs2wdMttYrs6ERC5+P8B+Pv/WAHmx+3TrG9b+seBhwmnetqD7zSTTZDmMq/RAP3Odn l6oNVKE7BEL5t01RpORDLj4KiAab59Br3Gs0fA9/RV6uTvqdkNZhGFvrOF6NJ7hCqjBQ 9jBHzSpUkkesiiaacaB0YmiFJN2zsLcyaVnKIy4gW8eMjaX+Misovh9g6CJ4gwHTDqku k0Ow== X-Gm-Message-State: AOAM531bG65myRxsmvpj0IELkwicovQqsY849iIxGTk4tz2Mj5ABpuVk kbikt3AsjV+SmqflWiJlUIE= X-Google-Smtp-Source: ABdhPJyuSEjgC8gxcdCSq+RmMhMDpIj2VfgSm4mV8lRxLBxVjOmi7Jvkw3oGCeM9Sps9dZfNkLyqaQ== X-Received: by 2002:a1c:df55:: with SMTP id w82mr3826801wmg.162.1617811769001; Wed, 07 Apr 2021 09:09:29 -0700 (PDT) Received: from LEGION ([39.46.7.73]) by smtp.gmail.com with ESMTPSA id j6sm8376112wmq.16.2021.04.07.09.09.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Apr 2021 09:09:28 -0700 (PDT) Date: Wed, 7 Apr 2021 21:09:21 +0500 From: Muhammad Usama Anjum To: hverkuil@xs4all.nl, Neil Armstrong , Mauro Carvalho Chehab , Greg Kroah-Hartman , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , "open list:MESON VIDEO DECODER DRIVER FOR AMLOGIC SOCS" , "open list:MESON VIDEO DECODER DRIVER FOR AMLOGIC SOCS" , "open list:STAGING SUBSYSTEM" , "moderated list:ARM/Amlogic Meson SoC support" , open list Cc: musamaanjum@gmail.com, kernel-janitors@vger.kernel.org, dan.carpenter@oracle.com Subject: [PATCH] staging: media/meson: remove redundant dev_err call Message-ID: <20210407160921.GA1504294@LEGION> X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline devm_ioremap_resource() prints error message in itself. Remove the dev_err call to avoid redundant error message. Signed-off-by: Muhammad Usama Anjum --- drivers/staging/media/meson/vdec/vdec.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/staging/media/meson/vdec/vdec.c b/drivers/staging/media/meson/vdec/vdec.c index 5d4db7a5b4b5..e51d69c4729d 100644 --- a/drivers/staging/media/meson/vdec/vdec.c +++ b/drivers/staging/media/meson/vdec/vdec.c @@ -1008,17 +1008,13 @@ static int vdec_probe(struct platform_device *pdev) r = platform_get_resource_byname(pdev, IORESOURCE_MEM, "dos"); core->dos_base = devm_ioremap_resource(dev, r); - if (IS_ERR(core->dos_base)) { - dev_err(dev, "Couldn't remap DOS memory\n"); + if (IS_ERR(core->dos_base)) return PTR_ERR(core->dos_base); - } r = platform_get_resource_byname(pdev, IORESOURCE_MEM, "esparser"); core->esparser_base = devm_ioremap_resource(dev, r); - if (IS_ERR(core->esparser_base)) { - dev_err(dev, "Couldn't remap ESPARSER memory\n"); + if (IS_ERR(core->esparser_base)) return PTR_ERR(core->esparser_base); - } core->regmap_ao = syscon_regmap_lookup_by_phandle(dev->of_node, -- 2.25.1