From: kernel test robot <lkp@intel.com>
To: Mitali Borkar <mitaliborkar810@gmail.com>,
Larry.Finger@lwfinger.net, florian.c.schilhabel@googlemail.com,
gregkh@linuxfoundation.org
Cc: kbuild-all@lists.01.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com,
mitali_s@me.iitr.ac.in
Subject: Re: [PATCH] staging: rtl8712: fix avoid CamelCase in xmit_osdep.h
Date: Wed, 7 Apr 2021 18:45:06 +0800 [thread overview]
Message-ID: <202104071800.I1nuAGV7-lkp@intel.com> (raw)
In-Reply-To: <YG1l6QIKRMjqgPiD@kali>
[-- Attachment #1: Type: text/plain, Size: 3060 bytes --]
Hi Mitali,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on staging/staging-testing]
url: https://github.com/0day-ci/linux/commits/Mitali-Borkar/staging-rtl8712-fix-avoid-CamelCase-in-xmit_osdep-h/20210407-155925
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git e91cafdf3c18b927e61eb4ee18e4865b8485f24f
config: i386-randconfig-a014-20210407 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/9f510deed38aa66173f9ffc8f21c7d61d96f583f
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Mitali-Borkar/staging-rtl8712-fix-avoid-CamelCase-in-xmit_osdep-h/20210407-155925
git checkout 9f510deed38aa66173f9ffc8f21c7d61d96f583f
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/staging/rtl8712/xmit_linux.c:94:6: warning: no previous prototype for 'r8712_SetFilter' [-Wmissing-prototypes]
94 | void r8712_SetFilter(struct work_struct *work)
| ^~~~~~~~~~~~~~~
vim +/r8712_SetFilter +94 drivers/staging/rtl8712/xmit_linux.c
2865d42c78a912 Larry Finger 2010-08-20 93
f95302eed91061 Ali Bahar 2011-09-04 @94 void r8712_SetFilter(struct work_struct *work)
f95302eed91061 Ali Bahar 2011-09-04 95 {
3f35d9022761e4 Nishka Dasgupta 2019-06-07 96 struct _adapter *adapter = container_of(work, struct _adapter,
8810493fc54e75 Deepak Mishra 2019-06-12 97 wk_filter_rx_ff0);
f95302eed91061 Ali Bahar 2011-09-04 98 u8 oldvalue = 0x00, newvalue = 0x00;
f95302eed91061 Ali Bahar 2011-09-04 99 unsigned long irqL;
f95302eed91061 Ali Bahar 2011-09-04 100
3f35d9022761e4 Nishka Dasgupta 2019-06-07 101 oldvalue = r8712_read8(adapter, 0x117);
f95302eed91061 Ali Bahar 2011-09-04 102 newvalue = oldvalue & 0xfe;
3f35d9022761e4 Nishka Dasgupta 2019-06-07 103 r8712_write8(adapter, 0x117, newvalue);
f95302eed91061 Ali Bahar 2011-09-04 104
6cc6677aee4346 Deepak Mishra 2019-06-12 105 spin_lock_irqsave(&adapter->lock_rx_ff0_filter, irqL);
3f35d9022761e4 Nishka Dasgupta 2019-06-07 106 adapter->blnEnableRxFF0Filter = 1;
6cc6677aee4346 Deepak Mishra 2019-06-12 107 spin_unlock_irqrestore(&adapter->lock_rx_ff0_filter, irqL);
f95302eed91061 Ali Bahar 2011-09-04 108 do {
f95302eed91061 Ali Bahar 2011-09-04 109 msleep(100);
3f35d9022761e4 Nishka Dasgupta 2019-06-07 110 } while (adapter->blnEnableRxFF0Filter == 1);
3f35d9022761e4 Nishka Dasgupta 2019-06-07 111 r8712_write8(adapter, 0x117, oldvalue);
f95302eed91061 Ali Bahar 2011-09-04 112 }
f95302eed91061 Ali Bahar 2011-09-04 113
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 42103 bytes --]
next prev parent reply other threads:[~2021-04-07 10:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 7:57 [PATCH] staging: rtl8712: fix avoid CamelCase in xmit_osdep.h Mitali Borkar
2021-04-07 8:05 ` Greg KH
2021-04-07 10:45 ` kernel test robot [this message]
2021-04-07 16:21 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202104071800.I1nuAGV7-lkp@intel.com \
--to=lkp@intel.com \
--cc=Larry.Finger@lwfinger.net \
--cc=florian.c.schilhabel@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mitali_s@me.iitr.ac.in \
--cc=mitaliborkar810@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox