From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7E2FB70 for ; Fri, 9 Apr 2021 23:02:57 +0000 (UTC) Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1lUznc-00038n-01; Sat, 10 Apr 2021 00:40:24 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id EDAA4C24FC; Sat, 10 Apr 2021 00:39:11 +0200 (CEST) Date: Sat, 10 Apr 2021 00:39:11 +0200 From: Thomas Bogendoerfer To: Andy Shevchenko Cc: Alexander Lobakin , Wei Liu , Rasmus Villemoes , Arnd Bergmann , Bjorn Andersson , Christian Brauner , Andrew Morton , Kees Cook , Mike Rapoport , Corey Minyard , Michael Ellerman , Vasily Gorbik , "Jason J. Herne" , Joerg Roedel , Michael Kelley , Joe Perches , Florian Fainelli , Krzysztof Kozlowski , Greg Kroah-Hartman , Scott Branden , Olof Johansson , Mihai Carabas , Wang Wenhu , Marek Czerski , Hongbo Yao , Mathieu Poirier , Vineeth Vijayan , Heiko Carstens , Peter Oberparleiter , Alexander Egorenkov , Tetsuo Handa , Vlastimil Babka , "Paul E. McKenney" , "Steven Rostedt (VMware)" , linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-hyperv@vger.kernel.org, xen-devel@lists.xenproject.org, linux-xtensa@linux-xtensa.org, openipmi-developer@lists.sourceforge.net, linux-clk@vger.kernel.org, linux-edac@vger.kernel.org, coresight@lists.linaro.org, linux-leds@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-staging@lists.linux.dev, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-arch@vger.kernel.org, kexec@lists.infradead.org, rcu@vger.kernel.org, linux-fsdevel@vger.kernel.org, Richard Henderson , Ivan Kokshaysky , Matt Turner , Catalin Marinas , Will Deacon , "James E.J. Bottomley" , Helge Deller , Benjamin Herrenschmidt , Paul Mackerras , Christian Borntraeger , "David S. Miller" , Jeff Dike , Richard Weinberger , Anton Ivanov , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , Chris Zankel , Max Filippov , Corey Minyard , Paul Walmsley , Michael Turquette , Stephen Boyd , Dinh Nguyen , Mauro Carvalho Chehab , Tony Luck , James Morse , Robert Richter , Suzuki K Poulose , Mike Leach , Leo Yan , Alexander Shishkin , Pavel Machek , Alex Elder , Jakub Kicinski , Sebastian Reichel , Ohad Ben-Cohen , Jens Frederich , Daniel Drake , Jon Nettleton , Eric Biederman , Josh Triplett , Mathieu Desnoyers , Lai Jiangshan , Joel Fernandes , Luis Chamberlain , Iurii Zaikin , Mike Rapoport Subject: Re: [PATCH v2 1/1] kernel.h: Split out panic and oops helpers Message-ID: <20210409223911.GA21445@alpha.franken.de> References: <20210409100250.25922-1-andriy.shevchenko@linux.intel.com> X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210409100250.25922-1-andriy.shevchenko@linux.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) On Fri, Apr 09, 2021 at 01:02:50PM +0300, Andy Shevchenko wrote: > kernel.h is being used as a dump for all kinds of stuff for a long time. > Here is the attempt to start cleaning it up by splitting out panic and > oops helpers. > > There are several purposes of doing this: > - dropping dependency in bug.h > - dropping a loop by moving out panic_notifier.h > - unload kernel.h from something which has its own domain > > At the same time convert users tree-wide to use new headers, although > for the time being include new header back to kernel.h to avoid twisted > indirected includes for existing users. > > Signed-off-by: Andy Shevchenko > Reviewed-by: Bjorn Andersson > Acked-by: Mike Rapoport > Acked-by: Corey Minyard > Acked-by: Christian Brauner > Acked-by: Arnd Bergmann > Acked-by: Kees Cook > Acked-by: Wei Liu > Acked-by: Rasmus Villemoes > Signed-off-by: Andrew Morton > --- > v2: > - fixed all errors with allmodconfig on x86_64 (Andrew) > - checked with allyesconfig on x86_64 > - additionally grepped source code for panic notifier list usage > and converted all users > - elaborated commit message (Luis) > - collected given tags (incl. Andrew's SoB, see below) > > I added Andrew's SoB since part of the fixes I took from him. Andrew, > feel free to amend or tell me how you want me to do. > > arch/mips/kernel/relocate.c | 1 + > arch/mips/sgi-ip22/ip22-reset.c | 1 + > arch/mips/sgi-ip32/ip32-reset.c | 1 + Acked-by: Thomas Bogendoerfer -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]