From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5BBE71 for ; Mon, 12 Apr 2021 09:43:08 +0000 (UTC) IronPort-SDR: OHuygtpoqB0LE5b2OxJPy05H12pT3wwtQKiZsKKXL4hbcqUErpNkc6ZVa6Pzx0VqB9Gjclifg/ 2fp+rwLpCkdg== X-IronPort-AV: E=McAfee;i="6000,8403,9951"; a="279451716" X-IronPort-AV: E=Sophos;i="5.82,216,1613462400"; d="scan'208";a="279451716" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Apr 2021 02:43:06 -0700 IronPort-SDR: c3qofnFRJu4y+V5m3FVtUxb1haaRQdz6XGFkubCHPk2VHDvvzoGGQsabXKRtntCKT63wT/g8lS 2J3/coYr/TPA== X-IronPort-AV: E=Sophos;i="5.82,216,1613462400"; d="scan'208";a="599915096" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Apr 2021 02:43:03 -0700 Received: from paasikivi.fi.intel.com (localhost [127.0.0.1]) by paasikivi.fi.intel.com (Postfix) with SMTP id 5DC89205AA; Mon, 12 Apr 2021 12:42:30 +0300 (EEST) Date: Mon, 12 Apr 2021 12:42:30 +0300 From: Sakari Ailus To: Mitali Borkar Cc: bingbu.cao@intel.com, tian.shu.qiu@intel.com, mchehab@kernel.org, gregkh@linuxfoundation.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com, mitali_s@me.iitr.ac.in Subject: Re: [PATCH 1/6] staging: media: intel-ipu3: replace bit shifts with BIT() macro Message-ID: <20210412094230.GI3@paasikivi.fi.intel.com> References: X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Hi Mitali, On Mon, Apr 12, 2021 at 04:38:39AM +0530, Mitali Borkar wrote: > Added #include and replaced bit shifts by BIT() macro. > This BIT() macro from linux/bitops.h is used to define IPU3_UAPI_GRID_Y_START_EN > and IPU3_UAPI_AWB_RGBS_THR_B_* bitmask. > Use of macro is better and neater. It maintains consistency. > Reported by checkpatch. > > Signed-off-by: Mitali Borkar > --- > drivers/staging/media/ipu3/include/intel-ipu3.h | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/media/ipu3/include/intel-ipu3.h b/drivers/staging/media/ipu3/include/intel-ipu3.h > index edd8edda0647..589d5ccee3a7 100644 > --- a/drivers/staging/media/ipu3/include/intel-ipu3.h > +++ b/drivers/staging/media/ipu3/include/intel-ipu3.h > @@ -5,6 +5,7 @@ > #define __IPU3_UAPI_H > > #include > +#include > > /* from /drivers/staging/media/ipu3/include/videodev2.h */ > > @@ -22,11 +23,11 @@ > #define IPU3_UAPI_MAX_BUBBLE_SIZE 10 > > #define IPU3_UAPI_GRID_START_MASK ((1 << 12) - 1) > -#define IPU3_UAPI_GRID_Y_START_EN (1 << 15) > +#define IPU3_UAPI_GRID_Y_START_EN BIT(15) This header is used in user space where you don't have the BIT() macro. > > /* controls generation of meta_data (like FF enable/disable) */ > -#define IPU3_UAPI_AWB_RGBS_THR_B_EN (1 << 14) > -#define IPU3_UAPI_AWB_RGBS_THR_B_INCL_SAT (1 << 15) > +#define IPU3_UAPI_AWB_RGBS_THR_B_EN BIT(14) > +#define IPU3_UAPI_AWB_RGBS_THR_B_INCL_SAT BIT(15) > > /** > * struct ipu3_uapi_grid_config - Grid plane config -- Kind regards, Sakari Ailus