From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59C9271 for ; Mon, 12 Apr 2021 15:08:46 +0000 (UTC) Received: by mail-pg1-f175.google.com with SMTP id q10so9609945pgj.2 for ; Mon, 12 Apr 2021 08:08:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-disposition:content-transfer-encoding; bh=7c5hbFDJuzW8IbaNLbCCwK5N29exubinPApJnJHDfR0=; b=ITLLe2DYMYPMeZVGTkOR3bOoGfykAoYj/bQy2kCNye+lBUJ4XaLgFBgV6f2/yXfdd7 oFAVX0mQPwwymASavuDGXYqCdTXy47ZVJ/xlr9FH+qYoJ0kyvIHWC7SglHHDqrO50knq erVGGF9AYHklUu3pGvXTBSIB1dK/wjQF3ksPtYKoYc3UTmIXSSS5oIwQ8EYvT/rFv2Qw B9VpY9yz26CcM80Jg4PDwvFix5CNjmrPsjA+feH4HFT9yDVUE0HBsePWEfP2D1E6A0BC k9hnIqKMl0A/k7zYjwFsYK0ENESXfAjEks0+fqqa79661PTy2kc8s1fOcLNn/eQCZcR7 09Tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-disposition :content-transfer-encoding; bh=7c5hbFDJuzW8IbaNLbCCwK5N29exubinPApJnJHDfR0=; b=Iy7+FWdPh8F/jcyy5KRcxsH8rimdvjbpyYeKwlHLyCKOr15KCl931rjBZdHeTMOkuI kDWkgglZxcivSlsosaGiS89EGJO09W2cY4Y8QPJCEavt5LHt96Jjp9Psv2okUEWyEX5a P9+L9YsoEXm6iJHy0P82vFv4AVf7WkW94JQCtuS3BLJJcpLOPfXOmKm1f+5491WHz4+T P63TiACDten9l/VG6IgINTUQMa7jqh98lT1Rg7z61sblDiHNcsq2aFhKNZtvV6CXRoqu ESQ8yHD9fUJ44EgcErSPw6VgHLWso/DCgyx7/KumLl+r+VrP7N6gvpawws7dNlvp8/8g cX0g== X-Gm-Message-State: AOAM530xNdetjdLfzc74x7h9vrq1wyqY3h38TagCBkhfwaE5Zpy0nQdt EXw7L3MerX3GZR96umLPTjQ= X-Google-Smtp-Source: ABdhPJz7KRLv1g9bRdFHzT6lp7tQwKP2uj+NoPFEntDd1eukLWRlre8tS73iPaLZc+mPS/pqqEeSxQ== X-Received: by 2002:aa7:91d1:0:b029:1fe:2a02:73b9 with SMTP id z17-20020aa791d10000b02901fe2a0273b9mr25310238pfa.2.1618240125830; Mon, 12 Apr 2021 08:08:45 -0700 (PDT) Received: from localhost.localdomain ([138.197.212.246]) by smtp.gmail.com with ESMTPSA id k13sm8406233pji.14.2021.04.12.08.08.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Apr 2021 08:08:45 -0700 (PDT) From: DENG Qingfang To: =?iso-8859-1?Q?Ren=E9?= van Dorst Cc: "David S. Miller" , Andrew Lunn , Florian Fainelli , Heiner Kallweit , Jakub Kicinski , Landen Chao , Matthias Brugger , Russell King , Sean Wang , Vivien Didelot , Vladimir Oltean , Rob Herring , Linus Walleij , Greg Kroah-Hartman , Sergio Paracuellos , linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-staging@lists.linux.dev, devicetree@vger.kernel.org, netdev@vger.kernel.org, Weijie Gao , Chuanhong Guo , Frank Wunderlich , Thomas Gleixner , Marc Zyngier Subject: Re: [RFC v4 net-next 1/4] net: phy: add MediaTek PHY driver Date: Mon, 12 Apr 2021 23:08:36 +0800 Message-Id: <20210412150836.929610-1-dqfext@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210412070449.Horde.wg9CWXW8V9o0P-heKYtQpVh@www.vdorst.com> References: <20210412034237.2473017-1-dqfext@gmail.com> <20210412034237.2473017-2-dqfext@gmail.com> <20210412070449.Horde.wg9CWXW8V9o0P-heKYtQpVh@www.vdorst.com> X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Mon, Apr 12, 2021 at 07:04:49AM +0000, René van Dorst wrote: > Hi Qingfang, > > +static void mtk_phy_config_init(struct phy_device *phydev) > > +{ > > + /* Disable EEE */ > > + phy_write_mmd(phydev, MDIO_MMD_AN, MDIO_AN_EEE_ADV, 0); > > For my EEE patch I changed this line to: > > genphy_config_eee_advert(phydev); > > So PHY EEE part is setup properly at boot, instead enable it manual via > ethtool. > This function also takes the DTS parameters "eee-broken-xxxx" in to account > while i> setting-up the PHY. Thanks, I'm now testing with it. > > > + > > + /* Enable HW auto downshift */ > > + phy_modify_paged(phydev, MTK_PHY_PAGE_EXTENDED, 0x14, 0, BIT(4));